Bug 273470 - x11/sfwbar: upgrade to 1.0.b12_1
Summary: x11/sfwbar: upgrade to 1.0.b12_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-31 07:29 UTC by Tino Engel
Modified: 2023-09-04 07:41 UTC (History)
1 user (show)

See Also:


Attachments
git diff for upgrading the port (4.17 KB, patch)
2023-08-31 07:29 UTC, Tino Engel
no flags Details | Diff
git diff for upgrading the port v2 (4.37 KB, patch)
2023-08-31 15:17 UTC, Tino Engel
tino.engel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tino Engel 2023-08-31 07:29:06 UTC
Created attachment 244515 [details]
git diff for upgrading the port

This ticket has has been created for updating the port x11/sfwbar from 1.0_beta9 to 1.0_beta12.
The port-update has been created with help from the upstream maintainer.
Upstream git:
https://github.com/LBCrion/sfwbar

The output of 'git diff --staged > ../`make -VPKGNAME`.diff' has been attached to this bugzilla ticket.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-31 14:55:58 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Q/A: PORTREVISION should be removed

^Triage: would it be possible to lint this port with portclippy?


Thanks!
Comment 2 Tino Engel 2023-08-31 15:17:43 UTC
Created attachment 244525 [details]
git diff for upgrading the port v2

- PORTREVISION has been removed
- port has been linted with portclippy
Comment 3 Tino Engel 2023-08-31 15:23:02 UTC
Hi Fernando,

Thanks for your quick feedback.
Except for the changelog URL, which seems not to be existing, I incorporated the items from your feedback and created a new patch.
Please let me know if there are further findings.

Kind regards, Tino
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-31 18:02:05 UTC
(In reply to Tino Engel from comment #3)
LGTM,

Thanks for the changes. I will queue it for testing.
Stay tuned!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-04 06:34:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e68c986a699a870fe661963912ec6102723313f

commit 9e68c986a699a870fe661963912ec6102723313f
Author:     Tino Engel <tino.engel@mail.de>
AuthorDate: 2023-08-31 18:01:51 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-09-04 06:34:09 +0000

    x11/sfwbar: upgrade to 1.0.b12_1

    PR:             273470
    Reported by:    tino.engel@mail.de (maintainer)

 x11/sfwbar/Makefile  | 33 +++++++++++++++++++++++++++++----
 x11/sfwbar/distinfo  |  6 +++---
 x11/sfwbar/pkg-plist | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 79 insertions(+), 7 deletions(-)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-04 07:41:18 UTC
Committed,

Thanks!