Bug 273542 - .NET ports: fix ipv6 detection
Summary: .NET ports: fix ipv6 detection
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-03 13:59 UTC by Michiel van Baak Jansen
Modified: 2023-09-24 17:27 UTC (History)
2 users (show)

See Also:
driesm: maintainer-feedback+


Attachments
0001-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.-Poi.patch (7.29 KB, patch)
2023-09-03 13:59 UTC, Michiel van Baak Jansen
michiel: maintainer-approval?
Details | Diff
0001-prowlarr-remove-comment-that-should-be-mentioned-in-git-commi.patch (965 bytes, patch)
2023-09-24 12:56 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff
0001-readarr-remove-comment-that-should-be-mentioned-in-git-commi.patch (955 bytes, patch)
2023-09-24 12:57 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff
0001-emby-server-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch (1.45 KB, patch)
2023-09-24 12:59 UTC, Michiel van Baak Jansen
michiel: maintainer-approval?
Details | Diff
0001-jellyfin-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch (1.43 KB, patch)
2023-09-24 13:00 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff
0001-radarr-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch (1.33 KB, patch)
2023-09-24 13:01 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff
0001-lidarr-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch (1.33 KB, patch)
2023-09-24 13:01 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel van Baak Jansen 2023-09-03 13:59:27 UTC
Created attachment 244612 [details]
0001-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.-Poi.patch

we disable ipv6 for .NET programs by setting an environment variable when the system does not have an ipv6 address configured.
The check should ignore ipv6 on local interfaces, and this patch makes it so.

Thanks Keith Chiem for the report and updated command.

Affected ports:
* multimedia/emby-server
* multimedia/jellyfin
* net-p2p/lidarr
* net-p2p/prowlarr
* net-p2p/radarr
* net-p2p/readarr

maintainer-approval for my ports (all the above except multimedia/emby-server)
Let me know if you want seperate prs for each port.
Comment 1 Michiel van Baak Jansen 2023-09-03 14:00:49 UTC
poudriere ok.
Applied patches to my local tree and the following ports are running in production on my setup without problems:
* multimedia/jellyfin
* net-p2p/lidarr
* net-p2p/prowlarr
* net-p2p/radarr
* net-p2p/readarr
Comment 2 Michiel van Baak Jansen 2023-09-17 12:29:56 UTC
net-p2p/readarr part also available in the update of that port here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273896
Comment 3 Michiel van Baak Jansen 2023-09-17 12:35:24 UTC
net-p2p/prowlarr part also available in the update of that port here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273897
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-09-22 17:12:37 UTC
Could you update the patch to only have the bits that are left to commit?

I've added a "maintainer-feedback" for the maintainer of multimedia/emby-server so he's in the loop.
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2023-09-24 11:46:22 UTC
Please drop "Later version by Keith Chiem through email" in all the files.

If he is the author we will specify it in git commit metadata.
Michiel is than the submitter of the patch.
Comment 6 Dries Michiels freebsd_committer freebsd_triage 2023-09-24 11:47:20 UTC
Ok for the Emby-port, seems like a good improvement!
Comment 7 Michiel van Baak Jansen 2023-09-24 12:54:29 UTC
(In reply to Dries Michiels from comment #5)

Ok, patches incoming...
Comment 8 Michiel van Baak Jansen 2023-09-24 12:56:35 UTC
Created attachment 245181 [details]
0001-prowlarr-remove-comment-that-should-be-mentioned-in-git-commi.patch

Removed the comment about updated command. Please credit in commit message.
Comment 9 Michiel van Baak Jansen 2023-09-24 12:57:22 UTC
Created attachment 245182 [details]
0001-readarr-remove-comment-that-should-be-mentioned-in-git-commi.patch

Removed comment about updated command. Please credit in commit message
Comment 10 Michiel van Baak Jansen 2023-09-24 12:59:36 UTC
Created attachment 245183 [details]
0001-emby-server-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch

Updated ipv6 detection command.

Report and updated command by Keith Chiem through email.
Comment 11 Michiel van Baak Jansen 2023-09-24 13:00:17 UTC
Created attachment 245184 [details]
0001-jellyfin-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch

Updated ipv6 detection command.

Report and updated command by Keith Chiem through email.
Comment 12 Michiel van Baak Jansen 2023-09-24 13:01:10 UTC
Created attachment 245185 [details]
0001-radarr-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch

Updated ipv6 detection command.

Report and updated command by Keith Chiem through email.
Comment 13 Michiel van Baak Jansen 2023-09-24 13:01:42 UTC
Created attachment 245186 [details]
0001-lidarr-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.patch

Updated ipv6 detection command.

Report and updated command by Keith Chiem through email.
Comment 14 Michiel van Baak Jansen 2023-09-24 13:02:47 UTC
Comment on attachment 244612 [details]
0001-IPv6-on-localhost-does-not-mean-a-jail-has-IPv6.-Poi.patch

Patch obsoleted by all the seperate port patches.
Comment 15 commit-hook freebsd_committer freebsd_triage 2023-09-24 17:26:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5cf4242d5f468f1663da0df17f0b18b6edd6f581

commit 5cf4242d5f468f1663da0df17f0b18b6edd6f581
Author:     Keith Chiem <keith.chiem@gmail.com>
AuthorDate: 2023-09-24 17:16:28 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2023-09-24 17:24:33 +0000

    .NET ports: improve IPv6 detection in rc script

    An IPv6 address on the localhost does not mean a jail has IPv6.
    Also remove two credit lines as he is now credited in the git log.

    PR:             273542
    Reported by:    michiel@vanbaak.eu
    Approved by:    michiel@vanbaak.eu (maintainer)

 multimedia/emby-server-devel/Makefile       | 2 +-
 multimedia/emby-server/Makefile             | 2 +-
 multimedia/emby-server/files/emby-server.in | 2 +-
 multimedia/jellyfin/Makefile                | 2 +-
 multimedia/jellyfin/files/jellyfin.in       | 2 +-
 net-p2p/lidarr/Makefile                     | 1 +
 net-p2p/lidarr/files/lidarr.in              | 2 +-
 net-p2p/prowlarr/files/prowlarr.in          | 1 -
 net-p2p/radarr/Makefile                     | 1 +
 net-p2p/radarr/files/radarr.in              | 2 +-
 net-p2p/readarr/files/readarr.in            | 1 -
 11 files changed, 9 insertions(+), 9 deletions(-)
Comment 16 Dries Michiels freebsd_committer freebsd_triage 2023-09-24 17:27:35 UTC
Committed, thanks!