Bug 273689 - audio/pamixer: Fails to build with GCC 13: error: expected identifier before '__is_convertible'
Summary: audio/pamixer: Fails to build with GCC 13: error: expected identifier before ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks: 273397
  Show dependency tree / graph
 
Reported: 2023-09-10 07:54 UTC by Lorenzo Salvadore
Modified: 2023-11-18 09:43 UTC (History)
1 user (show)

See Also:

Attachments
Patch for Pamixer (1.28 KB, patch)
2023-10-02 05:03 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2023-09-10 07:54:56 UTC 
This bug report blocks the update of GCC_DEFAULT to 13. This webpage can help finding a fix: https://gcc.gnu.org/gcc-13/porting_to.html

g++13 -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13 -isystem /usr/local/include  -isystem /usr/local/include  -c -o pulseaudio.o pulseaudio.cc
In file included from /usr/include/c++/v1/__functional/weak_result_type.h:16,
                 from /usr/include/c++/v1/__functional/invoke.h:14,
                 from /usr/include/c++/v1/__functional_base:15,
                 from /usr/include/c++/v1/string:520,
                 from device.hh:23,
                 from device.cc:19:
/usr/include/c++/v1/type_traits:1770:8: error: expected identifier before '__is_convertible'
 1770 | struct __is_convertible
      |        ^~~~~~~~~~~~~~~~

Full log: https://pkg-status.freebsd.org/package18/data/124amd64-default-foo/2023-09-06_17h55m19s/logs/errors/pamixer-1.4.15_7.log

There are other bugs similar to this one, such as bug #273671 or bug #273674.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-10-02 05:03:02 UTC 
Created attachment 245369 [details]
Patch for Pamixer

Update to 1.6 and remove dependency of GCC
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-10-02 05:03:37 UTC 
Builds on 13.2-RELEASE, not runtime tested
Comment 3 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-11-18 08:16:40 UTC 
New, more recent logs:

https://pkg-status.freebsd.org/package23/data/132i386-default-foo/2023-11-10_07h46m19s/logs/errors/pamixer-1.4.15_8.log
https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-10_07h48m13s/logs/errors/pamixer-1.4.15_8.log

Thanks for the patch. I suggest you commit it. If there is any runtime issue, users can open bug reports here on bugzilla; moreover, it is an unmaintained port without any other port depending on it, so expectations and risks are lower.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-18 09:42:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=018df382e2e61b94ce1a614417f719f2246369ec

commit 018df382e2e61b94ce1a614417f719f2246369ec
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-11-18 09:39:53 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-11-18 09:40:00 +0000

    audio/pamixer: Update to version 1.6

    Removes dependency of GCC
    No changelog provided by upstream

    PR:             273689

 audio/pamixer/Makefile | 14 ++++++--------
 audio/pamixer/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 11 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-11-18 09:43:16 UTC 
Let's bump this for now as suggested by Lorenzo