Created attachment 244779 [details] retry.patch This is the same 'retry' that Debian carry[1] and is useful in general shell mechanics. It has some useful features and is an improvement on forever rolling your own in a shell loop. [1] https://packages.debian.org/testing/utils/retry
Created attachment 244781 [details] retry.patch: removed GH_TAGNAME, set it from DISTVERSION properly
Hi, Thank you for your patch! Do you have a specific reason to use USE_GITHUB instead of the upstream provided distfile? Generally, we prefer to use an upstream provided distfile when one is available as this would be what upstream thinks everybody should use. I already fixed it on my local branch before committing but wanted to check whether you have a specific reason for this.
Thanks for looking at this submission. Sheesh, I somehow missed there was a proper release distfile and cranked on with USE_GITHUB by rote! Thanks for spotting. Would you like me to resubmit a new port reflecting the change or will you commit your fixed one directly?
> Would you like me to resubmit a new port reflecting the change or will you commit your fixed one directly? I'd say it would be reasonable if you update the patch yourself. Here are three more things to improve: - USES should be USES=, not USES+= (as there is nothing conditional here). - When using the upstream provided distfile, add tar:bz2 to USES. The underlying ports framework will then automagically pull the bz2 which is smaller. - HAS_CONFIGURE should be 'yes', not '1'
Just to be clear: You don't have to "resubmit". You can simply update the patch file of this PR. No need to open a new PR :)
Thanks for the feedback. I'm afraid I am now confused about your mention of upstream distfile. I thought you meant "use the GitHub hosted release[1]" and that I still had elements of fetching-by-tag left over from my first diff. But as far as I can tell my second diff does use the GitHub release[2] directly. I can't see the author is indicating another preferred distfile beyond RPM and APT shaped builds, so I'm a bit lost. Removing USE_GITHUB as you suggest without a new MASTER_SITE gets me into problems straightaway, of course! Incidentally, I don't think USES tar:bzip2 is used for GitHub[3], unless the magic goes deeper. But this just adds to my understanding that you're talking about another upstream than me. Please could you set me right? [1] https://github.com/minfrin/retry/releases [2] https://codeload.github.com/minfrin/retry/tar.gz/retry-1.0.5?dummy=... [3] https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.sites.mk#L1127
If you look at the GitHub release page [1] you can see that there are five artifacts. The two named "Source code" with the little archive icon are artifacts that GitHub automatically generates on each tag creation. These artifacts are basically just on-the-fly generated archives from the repository at that tag. The upstream author does not need to do anything. They just show up automatically. In contrast to that, you will see three more artifacts. These are not generated by GitHub. These are artifacts where the upstream author goes like "Yeah, this is what I want everybody to use to build their packages". USE_GITHUB pulls the auto-generated "Source code" archives. However, when upstream does provide dist files it's preferred to use those. Something like MASTER_SITES=https://github.com/minfrin/${PORTNAME}/releases/download/${PORTNAME}-${DISTVERSION}/ Hope that helps. [1] https://github.com/minfrin/retry/releases
Created attachment 244819 [details] retry.patch: use release distfile Thanks for the instructive comments, that's much clearer to me now. New patch attached.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c046a1681579b4ff0dd479c2313bd73c0238967c commit c046a1681579b4ff0dd479c2313bd73c0238967c Author: Jon Stuart <freebsd@zikomo.xyz> AuthorDate: 2023-09-14 15:58:26 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2023-09-15 13:51:25 +0000 misc/retry: Add new port A utility to retry a command until the command succeeds. PR: 273730 Approved by: zirias (mentor) Reviewed by: diizzy Differential Revision: https://reviews.freebsd.org/D41862 misc/Makefile | 1 + misc/retry/Makefile (new) | 20 ++++++++++++++++++++ misc/retry/distinfo (new) | 3 +++ misc/retry/pkg-descr (new) | 8 ++++++++ 4 files changed, 32 insertions(+)
Committed with minor modifications - thanks! :) You'll also be listed as an additional contributor: https://reviews.freebsd.org/D41875
Thanks for all your help with this!