Bug 273741 - x11/xfce4-terminal: outdated pkg-message
Summary: x11/xfce4-terminal: outdated pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-12 13:22 UTC by Anton Saietskii
Modified: 2023-09-12 19:43 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xfce)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-09-12 13:22:25 UTC 
pkg-message mentions editing ~/.config/xfce4/terminal/terminalrc, but Terminal switched to xfconf since version 1.1.0, so no terminalrc now. Additionally, slim tabs option isn't hidden anymore (please see the screenshot: https://imgur.com/TNwDqKL.png).

Due to both options listed being configurable through the GUI, I would propose simply removing pkg-message — there's no other info inside.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-09-12 14:00:03 UTC 
Thanks for reporting this.

I honestly forgot about the pkg-message when I last updated the port.

I'm taking a look at this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-12 19:41:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=60a8481ad2aad372d93eb84c9312bf8ac7ffb46a

commit 60a8481ad2aad372d93eb84c9312bf8ac7ffb46a
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-09-12 19:40:24 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-09-12 19:40:24 +0000

    x11/xfce4-terminal: Remove outdated pkg-message

    With the update to 1.1.0 xfce4-terminal is using xfconf so the part
    about "terminalrc" does not apply anymore.

    Also, the "slim tabs" option is now exposed in the UI.

    PR:             273741

 x11/xfce4-terminal/Makefile                    |  1 -
 x11/xfce4-terminal/files/pkg-message.in (gone) | 23 -----------------------
 2 files changed, 24 deletions(-)
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2023-09-12 19:43:25 UTC 
Old pkg-message removed.

Thank you!