Bug 273759 - New port: deskutils/nanonote – a minimalist note taking application
Summary: New port: deskutils/nanonote – a minimalist note taking application
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL: https://github.com/agateau/nanonote
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-13 13:15 UTC by Vidar Karlsen
Modified: 2023-09-18 18:52 UTC (History)
2 users (show)

See Also:

Attachments
git format-patch, editors/nanonote (3.75 KB, patch)
2023-09-13 13:15 UTC, Vidar Karlsen 		vidar: maintainer-approval+
Details | Diff
git format-patch, deskutils/nanonote (3.38 KB, patch)
2023-09-17 14:39 UTC, Vidar Karlsen 		vidar: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vidar Karlsen 2023-09-13 13:15:50 UTC 
Created attachment 244805 [details]
git format-patch, editors/nanonote

Nanonote is a minimalist Qt5 note taking application.

WWW: https://github.com/agateau/nanonote

QA:
- portlint -AC: ok
- portclippy:   ok
- poudriere testport ok for:
  * 13.2 amd64
  * 13.2 arm64
  * 12.4 i386
  * 12.4 amd64
Comment 1 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-15 16:02:17 UTC 
Thank you for your submission.

Qt5 is nearing end-of-life and there are already numerous editors in ports.
Could you check with upstream what their plans for Qt6 support are?
Comment 2 Vidar Karlsen 2023-09-16 14:49:14 UTC 
(In reply to Joel Bodenmann from comment #1)

Yes, the upstream developer uses it on a daily basis and intends to port it to Qt6 in the future.
Comment 3 Graham Perrin 2023-09-16 18:36:21 UTC 
Nice :-)

Drive-by comment: deskutils/ might be a better category. 

Consider <https://www.freshports.org/search.php?stype=name&method=match&query=note&num=100&orderby=category&orderbyupdown=asc&search=Search&format=plaintext&minimal=1&branch=head>
Comment 4 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-17 00:18:03 UTC 
(In reply to Vidar Karlsen from comment #0)
Comment 5 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-17 09:46:34 UTC 
Upstream provides an official distfile. Whenever possible, we prefer using the upstream provided distfile instead of USE_GITHUB.
This will most likely also negate the need for GH_TUPLE.

Could you please update the port accordingly and re-run all QA/tests?
Comment 6 Vidar Karlsen 2023-09-17 14:39:03 UTC 
Created attachment 244974 [details]
git format-patch, deskutils/nanonote

Updated patch:
- Moved port to deskutils
- Download the release tarball instead of USE_GITHUB

QA tests passed: same as previous patch (portlint, portclippy, poudriere)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-18 18:51:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=82818d45a6e46e830bfa69ea69b62d280fe7016e

commit 82818d45a6e46e830bfa69ea69b62d280fe7016e
Author:     Vidar Karlsen <vidar@karlsen.tech>
AuthorDate: 2023-09-13 13:12:22 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-09-18 18:50:12 +0000

    deskutils/nanonote: Add new port

    Nanonote is a minimalist note taking application.

    PR:                     273759
    Approved by:            zirias (mentor)
    Differential Revision:  https://reviews.freebsd.org/D41891

 deskutils/Makefile                 |  1 +
 deskutils/nanonote/Makefile (new)  | 21 +++++++++++++++++++++
 deskutils/nanonote/distinfo (new)  |  3 +++
 deskutils/nanonote/pkg-descr (new) |  5 +++++
 deskutils/nanonote/pkg-plist (new) |  9 +++++++++
 5 files changed, 39 insertions(+)
Comment 8 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-18 18:52:18 UTC 
Committed, thanks!