Bug 273941 - x11/xfce4-docklike-plugin: Update to 0.4.1
Summary: x11/xfce4-docklike-plugin: Update to 0.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-19 11:11 UTC by Guido Falsi
Modified: 2023-10-07 07:35 UTC (History)
1 user (show)

See Also:
bsd: maintainer-feedback+

Attachments
patch v1 (5.62 KB, patch)
2023-09-19 11:11 UTC, Guido Falsi 		no flags Details | Diff
patch v2 (5.63 KB, patch)
2023-10-02 16:01 UTC, Guido Falsi 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2023-09-19 11:11:29 UTC 
Created attachment 245018 [details]
patch v1

Hi!

I have noticed a new version is available and prepared an update patch.

The patches in files are now included upstream, and there is no need for GL_TAGNAME.

I also could not find any need for libinotify, so I removed the dependency.

The port builds fine in poudriere on all supported OS versions.

I've ran it locally shortly (I usually don't have this one installed) and looks fine at runtime.

Can you test and approve this patch?

Thanks in advance.
Comment 1 Quentin Baker 2023-09-20 00:16:07 UTC 
Thanks for the update - I'm glad upstream fixed those patches.

I will give this a test this coming weekend and confirm.
Comment 2 Graham Perrin 2023-10-01 14:55:35 UTC 
^Triage: 

* status
* remove a deprecated keyword.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2023-10-01 19:17:00 UTC 
@maintainer

Hi again,

did you have time to test this?

Can you approve?

Thanks in advance!
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-10-02 16:01:29 UTC 
Created attachment 245383 [details]
patch v2

Updated patch to apply to latest ports tree.

No functional change intended.
Comment 5 Quentin Baker 2023-10-04 04:56:21 UTC 
I ran it through my dev setup, seems to be fine. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-07 07:29:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1333140510495670f6f071c9452e2dc56925c342

commit 1333140510495670f6f071c9452e2dc56925c342
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-10-07 07:27:40 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-10-07 07:27:40 +0000

    x11/xfce4-docklike-plugin: Update to 0.4.1

    - Remove unneeded dependency
    - Let GL helper use DISTVERSION as the TAG (removing GL_TAGNAME)
    - Remove unneeded LDFLAGS
    - Remove patches now included upstream

    PR:             273941
    Approved by:    Quentin Baker <bsd@quentb.com> (maintainer)

 x11/xfce4-docklike-plugin/Makefile                   | 13 +++++--------
 x11/xfce4-docklike-plugin/distinfo                   |  6 +++---
 .../files/patch-src_Helpers.cpp (gone)               | 11 -----------
 .../files/patch-src_Wnck.cpp (gone)                  | 20 --------------------
 x11/xfce4-docklike-plugin/pkg-plist                  | 14 ++++++++++++++
 5 files changed, 22 insertions(+), 42 deletions(-)
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2023-10-07 07:35:50 UTC 
Update committed. Thanks for the review/approval!