Bug 273993 - net/libpfctl: fails to build b/c of double .include
Summary: net/libpfctl: fails to build b/c of double .include
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kristof Provost
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 09:02 UTC by Tassilo Philipp
Modified: 2024-02-05 18:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kp)

Attachments
patch removing the superflous line (230 bytes, patch)
2023-09-21 09:02 UTC, Tassilo Philipp 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tassilo Philipp 2023-09-21 09:02:06 UTC 
Created attachment 245088 [details]
patch removing the superflous line

# make
/!\ libpfctl-0.3: Makefile errors /!\

you cannot include bsd.port[.pre].mk twice

*** Error code 1

Stop.
make: stopped in /usr/ports/net/libpfctl



PS: this also makes portlint(1) much happier
Comment 1 Tassilo Philipp 2023-09-21 09:19:59 UTC 
forgot to add, just in case:

$ uname -v
FreeBSD 13.2-RELEASE-p3 GENERIC
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-21 12:03:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1654c9de038953bbd679bde86dcbf779bf7395ab

commit 1654c9de038953bbd679bde86dcbf779bf7395ab
Author:     Tassilo Philipp <tphilipp@potion-studios.com>
AuthorDate: 2023-09-21 09:11:13 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-09-21 12:00:24 +0000

    net/libpfctl: remove double include

    PR:             273993
    Reviewed by:    kp

 net/libpfctl/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Comment 3 Ed Maste freebsd_committer freebsd_triage 2024-02-05 18:29:23 UTC 
Closing as the patch was committed. Thanks!