Bug 274001 - finance/gnucash: since 5.3_1, guile framework might select guile 3.0 but pkg-plist hardcodes 2.2
Summary: finance/gnucash: since 5.3_1, guile framework might select guile 3.0 but pkg-...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 17:29 UTC by Chad Jacob Milios
Modified: 2023-09-22 07:15 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chad Jacob Milios 2023-09-21 17:29:33 UTC
To reproduce error, install lang/guile3 then try to build finance/gnucash.

My quick fix was to `sed -e s+/2.2/+/%%GUILE_VER%%/+ pkg-plist`.

I did not investigate whether the selection of guile 3.0 added any additional .scm or .go [or other] files to work/stage that wouldn't be there when 2.2 gets used instead. That might be prudent to verify.

see also:
https://cgit.freebsd.org/ports/commit/?id=7edcfaeb079e3285b299ef619ab9d09d46c447a2
http://bugs.freebsd.org/260960
https://reviews.freebsd.org/D40194
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-09-21 17:52:09 UTC
Hi,

Thanks for reporting this. I was not aware of this problem.

Apart from adapting the plist, the port will need to be adapted to reference the correct guile version ad a dependency.

I need a little time to investigate the issue and test possible solutions.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2023-09-21 18:00:30 UTC
(In reply to Guido Falsi from comment #1)

Correcting myself. Correct dependency should be added by USES=guile.

So fixing the plist could actually be enough.

I'm going to test some patches.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-22 07:12:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9dcd118a53f92a83e6c3e7d2c1720acd37e7b9fc

commit 9dcd118a53f92a83e6c3e7d2c1720acd37e7b9fc
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2023-09-22 07:11:39 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2023-09-22 07:12:28 +0000

    finance/gnucash: Fix packaging when guile3 is being used

    After commit 7edcfaeb079e3285b299ef619ab9d09d46c447a2 the guile
    version being depended upon can be configured by users via
    DEFAULT_VERSIONS.

    This patch adapts the plist to this option. [1]

    While here, also remove some unneeded dependencies. [2]

    PR:             274001 [1]
    Reported by:    poudriere [2]

 finance/gnucash/Makefile  |   8 +-
 finance/gnucash/pkg-plist | 436 +++++++++++++++++++++++-----------------------
 2 files changed, 220 insertions(+), 224 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2023-09-22 07:15:23 UTC
Committed suggested changes. This should be fixed now. I'll close the issue.

If any problems come up, feel free to reopen or file a new bug report!