Bug 274035 - net-mgmt/snmptt: update from 1.4.2 to 1.5
Summary: net-mgmt/snmptt: update from 1.4.2 to 1.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL: https://snmptt.sourceforge.net/change...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-23 02:08 UTC by nistor
Modified: 2023-10-04 20:09 UTC (History)
2 users (show)

See Also:
nistor: maintainer-feedback+

Attachments
Patch file for update from 1.4.2 to 1.5.0 (1.34 KB, patch)
2023-09-23 02:08 UTC, nistor 		no flags Details | Diff
Git diff of snmptt (1.36 KB, patch)
2023-10-04 03:02 UTC, nistor 		nistor: maintainer-approval+
Details | Diff
Patch with tabs validated (1.35 KB, patch)
2023-10-04 14:48 UTC, nistor 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nistor 2023-09-23 02:08:43 UTC 
Created attachment 245133 [details]
Patch file for update from 1.4.2 to 1.5.0

SNMPTT update from 1.4.2 to 1.5.0
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-09-23 03:54:41 UTC 
Your patch does not apply.

Please prepare the patch using "git format-patch" or "git diff" against the ports tree.
Comment 2 nistor 2023-10-04 03:02:23 UTC 
Created attachment 245422 [details]
Git diff of snmptt

File has been generated using `git diff` in the patch format.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-10-04 03:20:20 UTC 
(In reply to nistor from comment #2)

I found the problem: for some reason, all tabs have been converted to spaces in your patch.  Don't do that please.  Make sure your patch survives the transport to bugzilla unmolested!  This can e.g. haben when you copy-paste by mouse from a terminal window.  Don't do that.  Instead use a file transfer tool like scp or sftp.

Please resubmit the patch without this destruction.
Comment 4 nistor 2023-10-04 14:48:39 UTC 
Created attachment 245434 [details]
Patch with tabs validated

Direct patch piped into a file, sorry about that!
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-10-04 17:02:52 UTC 
This one applies!  Thanks for reworking it!

On commit, I will replace PORTVERSION with DISTVERSION as per policy.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-10-04 20:04:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b7c9b830d330d5cc74861a0c910b1ed1b099c346

commit b7c9b830d330d5cc74861a0c910b1ed1b099c346
Author:     Jon Nistor <nistor@snickers.org>
AuthorDate: 2023-10-04 17:02:04 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-04 20:01:39 +0000

    net-mgmt/snmptt: update to 1.5

    Changelog: https://snmptt.sourceforge.net/changelog.shtml

    PR:             274035

 net-mgmt/snmptt/Makefile                  |  6 +++---
 net-mgmt/snmptt/distinfo                  |  6 +++---
 net-mgmt/snmptt/files/patch-snmptt (gone) | 13 -------------
 3 files changed, 6 insertions(+), 19 deletions(-)