Bug 274045 - accessibility/at-spi2-core: unbreak after 5e22fb86a2856fbf331305dca882072099b38ad
Summary: accessibility/at-spi2-core: unbreak after 5e22fb86a2856fbf331305dca882072099b...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-23 11:55 UTC by Anton Saietskii
Modified: 2023-09-23 13:19 UTC (History)
1 user (show)

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments
poudriere build log (19.54 KB, text/plain)
2023-09-23 11:55 UTC, Anton Saietskii
no flags Details
unbreaking patch (805 bytes, patch)
2023-09-23 12:35 UTC, Anton Saietskii
vsasjason: maintainer-approval?
Details | Diff
poudriere build log with patch applied (226.97 KB, text/plain)
2023-09-23 12:36 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-09-23 11:55:56 UTC
Created attachment 245159 [details]
poudriere build log

Project name: at-spi2-core
Project version: 2.48.4
C compiler for the host machine: cc (clang 14.0.5 "FreeBSD clang version 14.0.5 (https://github.com/llvm/llvm-project.git llvmorg-14.0.5-0-gc12386ae247c)")
C linker for the host machine: cc ld.lld 14.0.5
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -fvisibility=hidden: YES 
Checking for function "bind_textdomain_codeset" : NO 
Found pkg-config: /usr/local/bin/pkgconf (2.0.3)
Run-time dependency dbus-1 found: YES 1.14.10
Run-time dependency glib-2.0 found: YES 2.78.0
Run-time dependency gobject-2.0 found: YES 2.78.0
Run-time dependency gio-2.0 found: YES 2.78.0
Checking for function "dlopen" : YES 
Run-time dependency gmodule-2.0 found: YES 2.78.0
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency libxml-2.0 found: NO (tried pkgconfig)

meson.build:147:13: ERROR: Dependency "libxml-2.0" not found, tried pkgconfig

A full log can be found at /wrkdirs/usr/ports/accessibility/at-spi2-core/work/at-spi2-core-2.48.4/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
===>  Script "configure" failed unexpectedly.
Comment 1 Anton Saietskii 2023-09-23 12:35:36 UTC
Created attachment 245160 [details]
unbreaking patch
Comment 2 Anton Saietskii 2023-09-23 12:36:53 UTC
Created attachment 245161 [details]
poudriere build log with patch applied
Comment 3 Anton Saietskii 2023-09-23 12:54:17 UTC
(In reply to Anton Saietskii from comment #1)

Note: I didn't touch PORTREVISION intentionally according to Porter's Handbook 5.2.3:
> Build fixes which cause a package to become compilable where it was previously failing. As long as the changes do not introduce any functional change on any other platforms on which the port did previously build. Since PORTREVISION reflects the content of the package, if the package was not previously buildable then there is no need to increase PORTREVISION to mark a change.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2023-09-23 12:56:13 UTC
It's not a regression but a regular bug. The spurious libxml2 dependency existed in 2.48.0 as well. According to my poudriere logs libxml2 is bootlegged via glib.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-09-23 13:18:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b87eb7985bfeaac9c71e3c01826b585db7c9bad0

commit b87eb7985bfeaac9c71e3c01826b585db7c9bad0
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-09-23 13:05:03 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-09-23 13:17:43 +0000

    accessibility/at-spi2-core: unbreak build with glib/MANPAGES=off

    meson.build:147:13: ERROR: Dependency "libxml-2.0" not found, tried pkgconfig

    libxml2 is only used by tests which cannot be disabled. devel/glib20 has it in
    LIB_DEPENDS due to USE_GNOME=libxslt:build -> libxslt_USE_GNOME_IMPL=libxml2
    without specifying :build suffix.

    PR:             274045
    Reported by:    Anton Saietskii
    Submitted by:   Olivier Duchateau (based on)

 accessibility/at-spi2-core/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-09-23 13:18:55 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d5790309c4a0c5fa52eab0033d28a4b5e4e9a236

commit d5790309c4a0c5fa52eab0033d28a4b5e4e9a236
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-09-23 13:05:03 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-09-23 13:18:31 +0000

    accessibility/at-spi2-core: unbreak build with glib/MANPAGES=off

    meson.build:147:13: ERROR: Dependency "libxml-2.0" not found, tried pkgconfig

    libxml2 is only used by tests which cannot be disabled. devel/glib20 has it in
    LIB_DEPENDS due to USE_GNOME=libxslt:build -> libxslt_USE_GNOME_IMPL=libxml2
    without specifying :build suffix.

    PR:             274045
    Reported by:    Anton Saietskii
    Submitted by:   Olivier Duchateau (based on)

    (cherry picked from commit b87eb7985bfeaac9c71e3c01826b585db7c9bad0)

 accessibility/at-spi2-core/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)