Bug 274064 - net-im/telegram-desktop: update to 4.9.3
Summary: net-im/telegram-desktop: update to 4.9.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL: https://github.com/telegramdesktop/td...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-24 16:01 UTC by Anton Saietskii
Modified: 2023-09-26 07:11 UTC (History)
1 user (show)

See Also:


Attachments
v1 (5.61 KB, patch)
2023-09-24 16:01 UTC, Anton Saietskii
no flags Details | Diff
poudriere build log (62.45 KB, application/x-xz)
2023-09-24 16:02 UTC, Anton Saietskii
no flags Details
v2 (5.86 KB, patch)
2023-09-25 00:06 UTC, Anton Saietskii
no flags Details | Diff
poudriere build log v2 (62.36 KB, application/x-xz)
2023-09-25 00:06 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-09-24 16:01:01 UTC
Created attachment 245190 [details]
v1
Comment 1 Anton Saietskii 2023-09-24 16:02:09 UTC
Created attachment 245191 [details]
poudriere build log
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-24 17:09:07 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 3 Anton Saietskii 2023-09-24 17:13:03 UTC
(In reply to Fernando Apesteguía from comment #2)

Nothing really meaningful in that changelog, but added a link. BTW, 4.8.4, which is in tree currently, doesn't build at all after glib+glibmm update, so this is not just update, but unbreak as well.
Comment 4 Anton Saietskii 2023-09-25 00:06:00 UTC
Created attachment 245201 [details]
v2

Revised patch to remove c++17 as c++20 being in use now, and appropriate switch added automatically.
No more patches for this version expected.
Comment 5 Anton Saietskii 2023-09-25 00:06:27 UTC
Created attachment 245202 [details]
poudriere build log v2
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-25 10:26:05 UTC
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/dbus-1/services/org.telegram.desktop.service
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Hi Anton, could you have a look at this?
Comment 7 Anton Saietskii 2023-09-25 12:56:28 UTC
(In reply to Fernando Apesteguía from comment #6)

Fernando, I'm not very smart and always felt in desperate fear when heard about plist due to total absence of understanding how to work with it... But I can try if you'll tell me how to trigger that.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-25 13:49:49 UTC
(In reply to Anton Saietskii from comment #7)
Hi Anton,

The pkg-plist file is where all the files installed by the package are listed.
Before creating the package, the ports framekwork creates a "fake" installation in a directory called "stage". Then, it compares the contents of this directory with the contents of the pkg-plist file.

What the error means is: "There is something that got installed in "stage" dir that is not recorded in the pkg-plist.

Have a look at this: https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkg-plist and let me know if you find any difficulties.
Comment 9 Anton Saietskii 2023-09-25 13:57:07 UTC
(In reply to Fernando Apesteguía from comment #8)

Fernando, got it, thanks. But I still don't understand how to _trigger_ error. I just run poudriere bulk and it creates me a package without failure on plist differences...
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-09-25 15:09:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a6a9ad85d351525e0a974e5e9ae36a30b30155a

commit 6a6a9ad85d351525e0a974e5e9ae36a30b30155a
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2023-09-25 15:08:32 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2023-09-25 15:08:32 +0000

    net-im/telegram-desktop: update to 4.9.3 release (+)

    Telegram Desktop 4.9.3 is latest release which supports Qt 5.15.8 before migrating to Qt 5.15.10 API

    PR:     274043, 274064

 net-im/telegram-desktop/Makefile                        | 12 +++---------
 net-im/telegram-desktop/distinfo                        |  6 +++---
 ...inux_base__system__media__controls__linux.cpp (gone) | 17 -----------------
 ...tch-cmake_external_glib_cppgir_CMakeLists.txt (gone) | 13 -------------
 ...h-cmake_external_glib_cppgir_tools_cppgir.cpp (gone) | 13 -------------
 ...cmake_external_glib_cppgir_tools_function.hpp (gone) |  8 --------
 ...-cmake_external_glib_cppgir_tools_genbase.cpp (gone) |  8 --------
 ...ch-cmake_external_glib_cppgir_tools_genns.cpp (gone) | 13 -------------
 net-im/telegram-desktop/pkg-plist                       |  1 +
 9 files changed, 7 insertions(+), 84 deletions(-)
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-26 07:11:31 UTC
^Triage: assigning to committer who actually resolved the issue.