Bug 274136 - [patch] www/chromium: chrome.runtime.getPlatformInfo is broken
Summary: [patch] www/chromium: chrome.runtime.getPlatformInfo is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-chromium (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2023-09-27 23:26 UTC by Dominik Gleich
Modified: 2023-09-29 10:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chromium)

Attachments
patch-chrome_browser_extensions_api_runtime_chrome__runtime__api__delegate.cc (593 bytes, text/plain)
2023-09-27 23:26 UTC, Dominik Gleich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Gleich 2023-09-27 23:26:04 UTC 
Created attachment 245299 [details]
patch-chrome_browser_extensions_api_runtime_chrome__runtime__api__delegate.cc

This is a recurrence of bug #212925

The attached patch restores the expected behavior.

Chrome runtime api delegate patch file
Comment 1 Robert Nagy freebsd_committer freebsd_triage 2023-09-28 12:04:47 UTC 
Thanks for the patch, but I would rather return linux here,
as I am pretty sure that extension developers using this API
will never think about anything else than major platforms
and we definitely want to take the linux path here as well.

I will commit such a patch soon.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-29 10:33:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c47361598b73b5e6e180b3ee1bbbaca833dbac63

commit c47361598b73b5e6e180b3ee1bbbaca833dbac63
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-09-29 10:30:53 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-09-29 10:32:35 +0000

    www/*chromium: update to 117.0.5938.132

    Security:       https://vuxml.freebsd.org/freebsd/6d9c6aae-5eb1-11ee-8290-a8a1599412c6.html
    PR:             274139, 274136

 www/chromium/Makefile                                      |  2 +-
 www/chromium/distinfo                                      | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...rome_browser_ui_views_frame_tab__strip__region__view.cc |  4 ++--
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 www/chromium/files/patch-net_dns_address__info.cc          |  9 +++++++--
 www/ungoogled-chromium/Makefile                            |  2 +-
 www/ungoogled-chromium/distinfo                            | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 .../files/patch-net_dns_address__info.cc                   |  9 +++++++--
 13 files changed, 78 insertions(+), 42 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-29 10:33:44 UTC 
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e55df4c8f8e0abf4f83177d75c24ffacfef2fd11

commit e55df4c8f8e0abf4f83177d75c24ffacfef2fd11
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-09-29 10:30:53 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-09-29 10:33:28 +0000

    www/*chromium: update to 117.0.5938.132

    Security:       https://vuxml.freebsd.org/freebsd/6d9c6aae-5eb1-11ee-8290-a8a1599412c6.html
    PR:             274139, 274136
    (cherry picked from commit c47361598b73b5e6e180b3ee1bbbaca833dbac63)

 www/chromium/Makefile                                      |  2 +-
 www/chromium/distinfo                                      | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...rome_browser_ui_views_frame_tab__strip__region__view.cc |  4 ++--
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 www/chromium/files/patch-net_dns_address__info.cc          |  9 +++++++--
 www/ungoogled-chromium/Makefile                            |  2 +-
 www/ungoogled-chromium/distinfo                            | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 .../files/patch-net_dns_address__info.cc                   |  9 +++++++--
 13 files changed, 78 insertions(+), 42 deletions(-)