Bug 274139 - www/chromium: fails to build in stable/12 because EAI_NODATA is not defined
Summary: www/chromium: fails to build in stable/12 because EAI_NODATA is not defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-28 02:16 UTC by david
Modified: 2023-09-29 13:58 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description david 2023-09-28 02:16:12 UTC
Please refer to the email thread starting with https://lists.freebsd.org/archives/freebsd-ports/2023-September/004433.html

From the poudriere build log on my build machine, running:
FreeBSD 12.4-STABLE #256 stable/12-n236282-b083794291d2: Wed Sep 27 10:26:39 UTC 2023     root@freebeast.catwhisker.org:/common/S1/obj/usr/src/amd64.amd64/sys/GENERIC  amd64 1204500 1204500

with the ports tree at main-n634807-080478034ac8:

FAILED: obj/net/dns/dns/address_info.o
c++ -MMD -MF obj/net/dns/dns/address_info.o.d -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D_GNU_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DBASE_USE_PERFETTO_CLIENT_LIBRARY=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DGOOGLE_PROTOBUF_INTERNAL_DONATE_STEAL_INLINE=0 -DHAVE_PTHREAD -DUSE_SYSTEM_LIBEVENT=1 -DNET_IMPLEMENTATION -DENABLE_BUILT_IN_DNS -DUSE_GIO -DUSING_SYSTEM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DU_FINAL=final -DU_NOEXCEPT=noexcept -DU_OVERRIDE=override -DU_IMPORT=U_EXPORT -I../.. -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -Igen/shim_headers/libevent_shim -Igen/shim_headers/icui18n_shim -Igen/shim_headers/icuuc_shim -I../../net/third_party/quiche/overrides -I../../net/third_party/quiche/src/quiche/common/platform/default -I../../net/third_party/quiche/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/abseil-cpp -I../../third_party/boringssl/src/include -Igen/net/third_party/quiche/src -I../../third_party/zlib -I../../third_party/ced/src -I../../third_party/brotli/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fdata-sections -ffunction-sections -fno-unique-section-names -fno-omit-frame-pointer -g0 -fprofile-use=../../chrome/build/pgo_profiles/chrome-linux-5938-1694193273-92041abba5ed60196170382dbce223833adce5c9.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -DPROTOBUF_ALLOW_DEPRECATED=1 -Wexit-time-destructors -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -c ../../net/dns/address_info.cc -o obj/net/dns/dns/address_info.o
../../net/dns/address_info.cc:81:47: error: use of undeclared identifier 'EAI_NODATA'
    if (os_error != EAI_NONAME && os_error != EAI_NODATA)
                                              ^
1 error generated.


As noted in the cited email message, this does not occur in 13 because of:
commit 870d2ff3052822dd6b46f2c07c442926d637130b
Author: Mike Karels <karels@FreeBSD.org>
Date:   Wed Nov 2 10:43:04 2022 -0500

    netdb.h: re-enable EAI_ADDRFAMILY, EAI_NODATA

    EAI_ADDRFAMILY and EAI_NODATA are not in RFC 3493, but are available
    and used in many other systems.  It is desirable to have at least one
    of them in order to distinguish between names that do not resolve and
    those that do not have the requested address type.  A change to
    getaddrinfo() will use EAI_ADDRFAMILY.  Both were "#if 0"; re-enable,
    conditioned on __BSD_VISIBLE, and update comments.  Also add comments
    and __BSD_VISIBLE conditional for the last three EAI errors, which
    are not in the RFC or POSIX.  Note, all of these are available in
    NetBSD and OpenBSD, and EAI_ADDRFAMILY and EAI_NODATA are available
    in Linux (glibc).

    Reviewed in https://reviews.freebsd.org/D37139 with related changes.

    Reviewed by:    bz

    (cherry picked from commit 40e4e12bd84154626d5b46c3e862c79da25bc403)
Comment 1 Tatsuki Makino 2023-09-29 03:58:47 UTC
This is due to the following patch being applied.

https://cgit.freebsd.org/ports/commit/www/chromium/files/patch-net_dns_address__info.cc?id=6e5c224fe143c44f11ee82f31e0424872b41f0de

This just seems to be reassigning the reason for the error, but does it affect anything other than the logs changing?
12.x is EoL in 3 more months though :)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-09-29 10:33:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c47361598b73b5e6e180b3ee1bbbaca833dbac63

commit c47361598b73b5e6e180b3ee1bbbaca833dbac63
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-09-29 10:30:53 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-09-29 10:32:35 +0000

    www/*chromium: update to 117.0.5938.132

    Security:       https://vuxml.freebsd.org/freebsd/6d9c6aae-5eb1-11ee-8290-a8a1599412c6.html
    PR:             274139, 274136

 www/chromium/Makefile                                      |  2 +-
 www/chromium/distinfo                                      | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...rome_browser_ui_views_frame_tab__strip__region__view.cc |  4 ++--
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 www/chromium/files/patch-net_dns_address__info.cc          |  9 +++++++--
 www/ungoogled-chromium/Makefile                            |  2 +-
 www/ungoogled-chromium/distinfo                            | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 .../files/patch-net_dns_address__info.cc                   |  9 +++++++--
 13 files changed, 78 insertions(+), 42 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-09-29 10:33:43 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e55df4c8f8e0abf4f83177d75c24ffacfef2fd11

commit e55df4c8f8e0abf4f83177d75c24ffacfef2fd11
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2023-09-29 10:30:53 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2023-09-29 10:33:28 +0000

    www/*chromium: update to 117.0.5938.132

    Security:       https://vuxml.freebsd.org/freebsd/6d9c6aae-5eb1-11ee-8290-a8a1599412c6.html
    PR:             274139, 274136
    (cherry picked from commit c47361598b73b5e6e180b3ee1bbbaca833dbac63)

 www/chromium/Makefile                                      |  2 +-
 www/chromium/distinfo                                      | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...rome_browser_ui_views_frame_tab__strip__region__view.cc |  4 ++--
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 www/chromium/files/patch-net_dns_address__info.cc          |  9 +++++++--
 www/ungoogled-chromium/Makefile                            |  2 +-
 www/ungoogled-chromium/distinfo                            | 14 +++++++-------
 .../files/patch-chrome_app_generated__resources.grd        | 12 ++++++------
 ...ons_api_runtime_chrome__runtime__api__delegate.cc (new) | 13 +++++++++++++
 ...nents_password__manager_core_browser_login__database.cc |  8 ++++----
 .../files/patch-net_dns_address__info.cc                   |  9 +++++++--
 13 files changed, 78 insertions(+), 42 deletions(-)
Comment 4 david 2023-09-29 13:58:27 UTC
Just a confirmation that my builder, running:
FreeBSD 12.4-STABLE #257 stable/12-n236283-5f446a12dac2: Fri Sep 29 10:49:40 UTC 2023     root@freebeast.catwhisker.org:/common/S1/obj/usr/src/amd64.amd64/sys/GENERIC  amd64 1204500 1204500

was able to build chromium-117.0.5938.132.pkg after updating the ports tree to main-n634954-c47361598b73.

Thank you!