Bug 274157 - multimedia/Bento4 compiles on aarch64 now
Summary: multimedia/Bento4 compiles on aarch64 now
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-29 14:36 UTC by FiLiS
Modified: 2023-10-30 22:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)

Attachments
remove BROKEN_aarch64 line from Makefile (473 bytes, patch)
2023-09-29 14:36 UTC, FiLiS 		no flags Details | Diff
bump portrevision (372 bytes, patch)
2023-10-30 11:03 UTC, FiLiS 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description FiLiS 2023-09-29 14:36:06 UTC 
Created attachment 245321 [details]
remove BROKEN_aarch64 line from Makefile

It looks like the build problems on aarch64 are gone, now.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-10-24 00:12:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=70ffe0b1207902af82d8b70ef47e55b8e4c85cb3

commit 70ffe0b1207902af82d8b70ef47e55b8e4c85cb3
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2023-10-24 00:07:26 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2023-10-24 00:11:59 +0000

    multimedia/Bento4: compiles on aarch64

    Bento4 is no broken anymore in aarch64.

    PR:             274157
    Reported by:    FiLiS <freebsdbugs@filis.org>

 multimedia/Bento4/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2023-10-24 00:13:34 UTC 
Committed, thanks
Comment 3 FiLiS 2023-10-30 11:03:53 UTC 
Created attachment 245994 [details]
bump portrevision
Comment 4 FiLiS 2023-10-30 11:04:44 UTC 
forgot to bump portrevision, patch attached
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2023-10-30 11:10:57 UTC 
(In reply to FiLiS from comment #4)

According to porter handbook (https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portrevision) PRTREVISION bump is not required here.

"The package was not previously buildable [for this arch], then there is no need to increase PORTREVISION to mark a change"
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2023-10-30 22:46:06 UTC 
For now I close this PR as Fixed, let me know if you think differently