Created attachment 245342 [details] 0001-emulators-winetricks-Update-to-20230903.patch Hello, this is an patch for an update to 20230903 ChangeLog: No Changelog available. Thank you in advance! Regards, Alexander Vereeken
Latest upstream release is 20230212 and you are creating a new version 20230903 based on commit 29e1006. This will break upstream versions. Have you tried a better approach with Porter's Handbook: --- Example 18. Using USE_GITHUB to Access a Commit Between Two Versions If the current version of the software uses a Git tag, and the port needs to be updated to a newer, intermediate version, without a tag, use git-describe(1) to find out the version to use: % git describe --tags f0038b1 v0.7.3-14-gf0038b1 --- ChangeLog: https://github.com/Winetricks/winetricks/compare/20230212...29e1006
Hello, can you tell me how this can break upstream versions? If the maintainer decides to create an newer version then the date from the release date will be taken so its any case higher than my current date if an new version gets released. I did the exact same thing two years ago in c801d31c9ddf68f34af1011b5a8585c0daa0d8aa.
I agree that there doesn't seem to be a problem with the versioning. PKGVERSION will increment monotonously as required. If the port needs to switch to a different versioning scheme, PORTEPOCH can always be incremented.
Hello Alexander and Robert, Yes, you are both right about it. I did some confusion about upstream versions and this port but it all make sense now. Thanks and sorry for the noise :)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a08b41c963ff874fe32c764475cc975bceb5a4e7 commit a08b41c963ff874fe32c764475cc975bceb5a4e7 Author: Alexander Vereeken <Alexander88207@protonmail.com> AuthorDate: 2023-10-03 08:25:42 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-10-03 08:27:42 +0000 emulators/winetricks: Update to 20230903 ChangeLog: https://github.com/Winetricks/winetricks/compare/20230212...29e1006 PR: 274186 emulators/winetricks/Makefile | 3 +- emulators/winetricks/distinfo | 6 +- .../winetricks/files/patch-src_winetricks (new) | 94 ++++++++++++++++++++++ 3 files changed, 99 insertions(+), 4 deletions(-)
Committed, thanks!