Created attachment 245465 [details] patch Hi. New version of net-mgmt/check_mysql_health. Please commit somebody.
Thank you for your submission. Would you like to become maintainer of this port?
Also, is there a changelog for this update?
Ok. Let's try. * 3.0.0.5 update GLPlugin, fix valdiff&lookback * 3.0.0.4 was a bad idea. now if there is no cache activity, there are no perfdata * 3.0.0.3 use the last good value for hitrates of there is absolutely no database activity * 3.0.0.2 default --lookback 3600 only if not given on the commandline fix version string * 3.0.0.1 default --lookback 3600 * 3.0 new structure, using Monitoring::GLPlugin
Thank you for supplying the changelog. A link to an online changelog is fine, too. I'll include it into the commit. Would you like to become maintainer of this port? It is currently unmaintained.
Interestingly, the port fails to build on amd64 but not other architectures: ===> Building for check_mysql_health-3.0.0.5 Making all in plugins-scripts /bin/echo "#! #PERL# -w" | /usr/bin/awk -f ./subst > check_mysql_health /bin/echo "# nagios: -epn" >> check_mysql_health /bin/echo >> check_mysql_health if [ "yes" == "yes" ]; then /bin/echo i am standalone; for m in ../GLPlugin/lib/Monitoring/GLPlugin/Commandline/Extraopts.pm ../GLPlugin/lib/Monitoring/GLPlugin/Commandline/Getopt.pm ../GLPlugin/lib/Monitoring/GLPlugin/Commandline.pm ../GLPlugin/lib/Monitoring/GLPlugin.pm ../GLPlugin/lib/Monitoring/GLPlugin/Item.pm ../GLPlugin/lib/Monitoring/GLPlugin/TableItem.pm ../GLPlugin/lib/Monitoring/GLPlugin/DB.pm ../GLPlugin/lib/Monitoring/GLPlugin/DB/DBI.pm ../GLPlugin/lib/Monitoring/GLPlugin/DB/CSF.pm ../GLPlugin/lib/Monitoring/GLPlugin/DB/Item.pm ../GLPlugin/lib/Monitoring/GLPlugin/DB/TableItem.pm; do /bin/sed -e 's/^1;//g' < $m | /bin/sed -e '/^__END__/,$d' | /bin/sed -e '/^__PACKAGE__/,$d' | /usr/bin/awk -f ./subst >> check_mysql_health; done fi i am standalone /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /bin/sh: /bin/sed: not found /usr/bin/awk: illegal primary in regular expression ^#! ?\/.*\/[a-z]{0,2}awk at source line number 44 source file ./subst context is /^#! ?\/.*\/[a-z]{0,2}awk/ {sub(/^#! ?\/.*\/[a-z]{0,2}awk/,"#! >>> /usr/bin/awk") <<< ;} *** Error code 2 Stop. Please check and resubmit as appropriate.
On a second attempt, the port builds. Either my setup was wrong or there is some sort of flakiness.
May be you tried to build it without Makefile.am patch. I can try maintain this port. Also may be it too early, but on the official site this version is marked as test version. https://labs.consol.de/de/nagios/check_mysql_health/index.html, see German localization.
(In reply to Kirill from comment #7) No, the patch is definitely there. What helped was adding USES=autoreconf, but then it still fails processing the awk script. It fails on some platforms only weirdly enough.
I couldn't get this port to build on armv7. Are you okay with that? It's not an essential platform and I would be okay with pushing the update regardless.
I don't mind.
Okay. You may receive emails indicating build failures. If you find the problem, feel free to submit patches!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=980be78e8501e633c7f6c7e9a3def58015b35b96 commit 980be78e8501e633c7f6c7e9a3def58015b35b96 Author: Kirill <kirill@varnakov.com> AuthorDate: 2023-10-07 03:30:49 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-09 07:40:28 +0000 net-mgmt/check_mysql_health: update to 3.0.0.5 Submitter becomes maintainer. Changelog: * 3.0.0.5 update GLPlugin, fix valdiff&lookback * 3.0.0.4 was a bad idea. now if there is no cache activity, there are no perfdata * 3.0.0.3 use the last good value for hitrates of there is absolutely no database activity * 3.0.0.2 default --lookback 3600 only if not given on the commandline fix version string * 3.0.0.1 default --lookback 3600 * 3.0 new structure, using Monitoring::GLPlugin PR: 274308 net-mgmt/check_mysql_health/Makefile | 7 ++++--- net-mgmt/check_mysql_health/distinfo | 6 +++--- .../files/patch-plugins-scripts_Makefile.am (new) | 11 +++++++++++ 3 files changed, 18 insertions(+), 6 deletions(-)
Thank you for your contribution.
Created attachment 245545 [details] patch2 Not at all. I added to USES autoreconf and gmake in patch 2. Could you commit it? And I could reproduce strange error by running command several times: cat Classes/Mysql/Component/InstanceSubsystem.pm | /usr/bin /awk -v N=100 -f ./subst Looks like Broken pipe error, which appears rarely.
(In reply to Kirill from comment #14) You could try to replace the cat with a redirection like so: /usr/bin/awk -v N=100 -f ./subst <Classes/Mysql/Component/InstanceSubsystem.pm Perhaps that avoids the issue (can't have a broken pipe if there is no pipe). I'll see that I can get your fix up committed shortly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=672b1b7c1e414c3882f4a2452c7a5585c949ca78 commit 672b1b7c1e414c3882f4a2452c7a5585c949ca78 Author: Kirill <kirill@varnakov.com> AuthorDate: 2023-10-16 03:19:58 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-10-19 07:07:25 +0000 net-mgmt/check_mysql_health: attempt to fix the build Seems like USES=autoreconf may be required. PR: 274308 net-mgmt/check_mysql_health/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)