Bug 274313 - net/samba413: fix build with lld 17
Summary: net/samba413: fix build with lld 17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks: 273753
  Show dependency tree / graph
 
Reported: 2023-10-06 18:18 UTC by Dimitry Andric
Modified: 2023-10-15 16:03 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (timur)

Attachments
net/samba413: fix build with lld 17 (785 bytes, patch)
2023-10-06 18:18 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-10-06 18:18:08 UTC 
Building net/samba413 with lld 17 results in the following link errors:

runner ['cc', '-Wl,--as-needed', '-Wl,--version-script=/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/replace.vscript', '-shared', 'lib/replace/replace.c.2.o', 'lib/replace/strptime.c.2.o', 'lib/replace/cwrap.c.2.o', 'lib/replace/xattr.c.2.o', '-o/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/libreplace-samba4.so', '-Wl,-Bstatic', '-Wl,-Bdynamic', '-L/usr/local/lib', '-L/usr/local/lib', '-fstack-protector-strong', '-L/usr/local/lib', '-Wl,-z,relro,-z,now', '-Wl,-no-undefined', '-Wl,--export-dynamic']
ld: error: version script assignment of 'local' to symbol '_end' failed: symbol not defined
ld: error: version script assignment of 'local' to symbol '__bss_start' failed: symbol not defined
ld: error: version script assignment of 'local' to symbol '_edata' failed: symbol not defined
cc: error: linker command failed with exit code 1 (use -v to see invocation)

Since the linker version scripts are generated dynamically, suppress
errors with lld >= 17 due to these undefined symbols.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-10-06 18:18:39 UTC 
Created attachment 245470 [details]
net/samba413: fix build with lld 17
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-15 15:46:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8bc0f1e6d3d18811c33a876273d591c04b2a8b44

commit 8bc0f1e6d3d18811c33a876273d591c04b2a8b44
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-09-29 10:29:25 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-10-15 15:44:42 +0000

    net/samba413: fix build with lld 17

    Building net/samba413 with lld 17 results in the following link errors:

      runner ['cc', '-Wl,--as-needed', '-Wl,--version-script=/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/replace.vscript', '-shared', 'lib/replace/replace.c.2.o', 'lib/replace/strptime.c.2.o', 'lib/replace/cwrap.c.2.o', 'lib/replace/xattr.c.2.o', '-o/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/libreplace-samba4.so', '-Wl,-Bstatic', '-Wl,-Bdynamic', '-L/usr/local/lib', '-L/usr/local/lib', '-fstack-protector-strong', '-L/usr/local/lib', '-Wl,-z,relro,-z,now', '-Wl,-no-undefined', '-Wl,--export-dynamic']
      ld: error: version script assignment of 'local' to symbol '_end' failed: symbol not defined
      ld: error: version script assignment of 'local' to symbol '__bss_start' failed: symbol not defined
      ld: error: version script assignment of 'local' to symbol '_edata' failed: symbol not defined
      cc: error: linker command failed with exit code 1 (use -v to see invocation)

    Since the linker version scripts are generated dynamically, suppress
    errors with lld >= 17 due to these undefined symbols.

    PR:             274313
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2023Q4

 net/samba413/Makefile | 4 ++++
 1 file changed, 4 insertions(+)