Bug 274328 - net-p2p/tremotesf: enable "test" make target and cleanup
Summary: net-p2p/tremotesf: enable "test" make target and cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-07 11:22 UTC by Anton Saietskii
Modified: 2023-10-09 07:46 UTC (History)
1 user (show)

See Also:


Attachments
v0 (3.08 KB, patch)
2023-10-07 11:22 UTC, Anton Saietskii
no flags Details | Diff
poudriere logs (14.14 KB, application/x-xz)
2023-10-07 11:25 UTC, Anton Saietskii
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2023-10-07 11:22:37 UTC
Created attachment 245479 [details]
v0
Comment 1 Anton Saietskii 2023-10-07 11:25:44 UTC
Created attachment 245480 [details]
poudriere logs

"poudriere testport" log + "make test" output inside builder jail as non-root

Partial (most important one) output snippet of "test" target:

[  0% 1/1] cd /wrkdirs/usr/ports/net-p2p/tremotesf/work/.build && /usr/local/bin/ctest --force-new-ctest-process
Test project /wrkdirs/usr/ports/net-p2p/tremotesf/work/.build
    Start 1: itemlistupdater_test
1/6 Test #1: itemlistupdater_test .............   Passed    0.07 sec
    Start 2: log_test
2/6 Test #2: log_test .........................   Passed    0.02 sec
    Start 3: demangle_test
3/6 Test #3: demangle_test ....................   Passed    0.02 sec
    Start 4: requestrouter_test
4/6 Test #4: requestrouter_test ...............   Passed    6.17 sec
    Start 5: pathutils_test
5/6 Test #5: pathutils_test ...................   Passed    0.05 sec
    Start 6: tracker_test
6/6 Test #6: tracker_test .....................   Passed    0.03 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   6.38 sec
pbuild@releng132-default:~ $ ^D
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-10-07 15:52:15 UTC
Thank you for the touchup.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-10-09 07:42:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c856cc4a9ce5b73901430cea4868ed401152aed

commit 6c856cc4a9ce5b73901430cea4868ed401152aed
Author:     Anton Saietskii <vsasjason@gmail.com>
AuthorDate: 2023-10-07 09:59:20 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-09 07:40:30 +0000

    net-p2p/tremotesf: enable "test" make target and cleanup

    www/cpp-httplib cannot be used for tests as CMake explicitly checks for
    version not higher than 0.12, so pull in latest supported from GitHub
    instead.

    While here:
    * Switch to full commit hash for libtremotesf to reduce potential risk
      of collisions
    * Switch "Concurrent" Qt dependency from "build+lib" to "build" type as
      bin/tremotesf doesn't link against it; bump PORTREVISION as package
      dependencies changed
    * Process Makefile with portfmt once more

    PR:             274328

 net-p2p/tremotesf/Makefile | 19 ++++++++++---------
 net-p2p/tremotesf/distinfo |  8 +++++---
 2 files changed, 15 insertions(+), 12 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-10-09 07:46:34 UTC
Thank you for your contribution.