Bug 274367 - x11-toolkits/wxgtk32: Update to 3.2.4
Summary: x11-toolkits/wxgtk32: Update to 3.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://www.wxwidgets.org/news/2023/1...
Keywords:
Depends on: 275078 275082 275192
Blocks: 275484
  Show dependency treegraph
 
Reported: 2023-10-09 07:30 UTC by Nuno Teixeira
Modified: 2023-12-14 07:46 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)
eduardo: merge-quarterly-


Attachments
Update to 3.2.2.1 (3.79 KB, patch)
2023-10-09 07:30 UTC, Nuno Teixeira
no flags Details | Diff
Bump consumers (19.51 KB, patch)
2023-10-09 07:34 UTC, Nuno Teixeira
no flags Details | Diff
Update to 3.2.3 (4.25 KB, patch)
2023-10-23 10:42 UTC, Nuno Teixeira
no flags Details | Diff
Bump consumers, refresh (19.49 KB, patch)
2023-10-23 10:44 UTC, Nuno Teixeira
no flags Details | Diff
cmake version #fail ld (6.39 KB, patch)
2023-11-03 11:30 UTC, Nuno Teixeira
no flags Details | Diff
CMake version v2 (WIP) (7.41 KB, patch)
2023-11-04 08:07 UTC, Daniel Engberg
no flags Details | Diff
CMake version v3 (WIP) (6.85 KB, patch)
2023-11-05 17:25 UTC, Daniel Engberg
no flags Details | Diff
CMake version 4 (Buildable, clean logs) (50.91 KB, patch)
2023-11-07 09:53 UTC, Nuno Teixeira
no flags Details | Diff
Update to 3.2.3: portclippy, portfmt (7.40 KB, patch)
2023-11-11 21:30 UTC, Nuno Teixeira
no flags Details | Diff
Update to 3.2.4 (7.40 KB, patch)
2023-11-14 12:06 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-10-09 07:34:12 UTC
Created attachment 245520 [details]
Bump consumers

Consumers list:
----
astro/opencpn:USE_WX=           3.0+
astro/phd2:USE_WX=              3.2+
audio/audacity:USE_WX=          3.2+
audio/spek:USE_WX=              3.2+
cad/PrusaSlicer:USE_WX=         3.2
cad/kicad-devel:USE_WX=         3.2
cad/kicad:USE_WX=               3.2
comms/chirp:USE_WX=     3.2
comms/cubicsdr:USE_WX=          3.2
comms/cwstudio:USE_WX=          3.0+
comms/freedv:USE_WX=    3.0+
comms/gnuradio:USE_WX=          3.2
comms/limesuite:USE_WX+=        3.2
comms/quisk:USE_WX=             3.2
comms/trustedqsl:USE_WX=                3.2
databases/grass7:USE_WX=                3.2
databases/grass8:USE_WX=                3.2
deskutils/treesheets:USE_WX=            3.2
deskutils/xchm:USE_WX=          3.0+
devel/codeblocks:USE_WX=                3.0+
devel/wxformbuilder:USE_WX=             3.0+
editors/rehex:USE_WX=           3.0+
editors/wxhexeditor:USE_WX=             3.0+
emulators/libretro-pcsx2:USE_WX=        3.0+
emulators/playonbsd:USE_WX=             3.2
games/0ad:USE_WX=               3.0+
games/golly:USE_WX=             3.2
games/openyahtzee:USE_WX=               3.2
games/springlobby:USE_WX=               3.0+
games/trenchbroom:USE_WX=               3.0+
graphics/diff-pdf:USE_WX=               3.0+
graphics/electricsheep:USE_WX=          3.2
graphics/hugin:USE_WX=          3.0+
graphics/matplotplusplus:USE_WX=                3.2+
graphics/py-mayavi:USE_WX=              3.2
graphics/py-visvis:USE_WX=              3.0+
graphics/wxsvg:USE_WX=          3.2+
lang/erlang-runtime21:                          USE_WX=3.2+ \
lang/erlang-runtime22:                          USE_WX=3.2+ \
lang/erlang-runtime23:                          USE_WX=3.2+ \
lang/erlang-runtime24:                          USE_WX=3.2+ \
lang/erlang-runtime25:                          USE_WX=3.2+ \
lang/erlang-runtime26:                          USE_WX=3.2+ \
lang/erlang-wx:USE_WX=          3.2+
lang/erlang:                            USE_WX=3.2+ \
math/gnuplot:USE_WX=            3.0+
math/saga:USE_WX=               3.2+
math/sound-of-sorting:USE_WX=           3.0+
misc/pyobd:USE_WX=              3.2
multimedia/dvdstyler:USE_WX=            3.2+
multimedia/photofilmstrip:USE_WX=               3.2
science/gnudatalanguage:USE_WX=         3.0+
science/opensph:USE_WX=         3.2
security/veracrypt:USE_WX=              3.0+
sysutils/passwordsafe:USE_WX=           3.0+
x11-fm/4pane:USE_WX=            3.0+
x11-toolkits/py-wxPython4:USE_WX=               3.2
----

Build logs:
https://people.freebsd.org/~eduardo/logs/wxgtk32/logs/consumers/

Run tests:
----
RUN OK
deskutils/treesheets
audio/audacity
editors/wxhexeditor
games/golly
math/saga
----

Thanks
Comment 2 Älven 2023-10-14 01:13:31 UTC
Update to 3.2.3
https://www.wxwidgets.org/news/2023/10/wxwidgets-3.2.3-released/

Changes since 3.2.2

This release contains many important bug fixes, including for some regressions in the previous 3.2.x releases, as well as build system improvements and a few optimizations.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-10-14 09:50:52 UTC
(In reply to Andrey Korobkov from comment #2)

Thanks Andrey, I will update patches and do new tests asap.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-10-23 10:42:47 UTC
Created attachment 245822 [details]
Update to 3.2.3

- Pet stage-qa

Logs: https://people.freebsd.org/~eduardo/logs/wxgtk32/

Run tests ok:
deskutils/treesheets
audio/audacity
editors/wxhexeditor
games/golly
math/saga
cad/kicad
editors/rehex
sysutils/passwordsafe
astro/phd2
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-10-23 10:44:29 UTC
Created attachment 245823 [details]
Bump consumers, refresh

Logs: https://people.freebsd.org/~eduardo/logs/wxgtk32/3.2.3/logs/
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-11-01 19:29:30 UTC
Is there a reason going from libpng.so to libpng16.so ?
Some distros have moved to CMake (Arch and Alpine for example) but LGTM otherwise and not a hard requirement.
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-01 19:42:39 UTC
(In reply to Daniel Engberg from comment #6)

stage-qa complainted about libpng.so not used as lib depend:
0x0000000000000001 NEEDED Shared library: [libpng16.so.16]
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-03 09:02:03 UTC
(In reply to Daniel Engberg from comment #6)

Already working on switching to cmake build.

While wx install instructions only mentions configure build, I've found a good example at https://gitlab.archlinux.org/archlinux/packaging/packages/wxwidgets/-/blob/main/PKGBUILD?ref_type=heads

Cheers
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-03 10:43:32 UTC
Hum, what a strange error about gtk3 found but ld fails... 

(config)
-- Found GTK3: /usr/local/include/gtk-3.0;/usr/local/include/pango-1.0;/usr/local/include/cairo;/usr/local/include/gdk-pixbuf-2.0;/usr/local/include;/usr/local/include/freetype2;/usr/local/include/harfbuzz;/usr/l
ocal/include/dbus-1.0;/usr/local/lib/dbus-1.0/include;/usr/local/include/glib-2.0;/usr/local/lib/glib-2.0/include;/usr/local/include/atk-1.0;/usr/local/include/pixman-1;/usr/local/include/libpng16;/usr/local/incl
ude/gio-unix-2.0;/usr/local/include/fribidi;/usr/local/include/libepoll-shim;/usr/local/include/at-spi2-atk/2.0;/usr/local/include/at-spi-2.0

(build)
ld: error: unable to find library -lgtk-3
ld: error: unable to find library -lgdk-3
ld: error: unable to find library -lharfbuzz
ld: error: unable to find library -lpangocairo-1.0
ld: error: unable to find library -lpango-1.0
ld: error: unable to find library -latk-1.0
ld: error: unable to find library -lcairo
ld: error: unable to find library -lcairo-gobject
ld: error: unable to find library -lgdk_pixbuf-2.0
ld: error: unable to find library -lgio-2.0
ld: error: unable to find library -lglib-2.0
ld: error: unable to find library -lintl
Comment 10 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-03 11:30:16 UTC
Created attachment 246079 [details]
cmake version #fail ld
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2023-11-04 08:07:31 UTC
Created attachment 246095 [details]
CMake version v2 (WIP)

Use USES= localbase:ldflags helper
Disable detection of SDL and gspell
Comment 12 Daniel Engberg freebsd_committer freebsd_triage 2023-11-04 08:10:03 UTC
Thanks for working on this!

This should now build and I disabled some detections of dependencies to remove noise, not sure about the libgnomevfs dependency? This is enabled by default by upstream but we don't seem to satisfy it (wxUSE_MIMETYPE:BOOL=ON).

Best regards,
Daniel
Comment 13 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-05 09:06:55 UTC
(In reply to Daniel Engberg from comment #12)

Hello!

With latest patch:
###
[100% 796/796] /usr/local/bin/cmake -E cmake_symlink_library lib/libwx_gtk3u_xrc-3.2.so.0.2.1  lib/libwx_gtk3u_xrc-3.2.so.0 lib/libwx_gtk3u_xrc-3.2.so && :
ninja: Entering directory `/wrkdirs/usr/ports/x11-toolkits/wxgtk32/work-gtk3/.build/locale'
ninja: fatal: chdir to '/wrkdirs/usr/ports/x11-toolkits/wxgtk32/work-gtk3/.build/locale' - No such file or directory
*** Error code 1
###

Don't know if it could be related to:
###
-- Checking for module 'gnome-vfs-2.0'
--   Package 'gnome-vfs-2.0', required by 'virtual:world', not found
-- libgnomevfs not found, library won't be used to associate MIME type
###

I will continue to check cmake options and see if it is something missing.

Cheers
Comment 14 Daniel Engberg freebsd_committer freebsd_triage 2023-11-05 11:11:28 UTC
It doesn't fail on my build box using a dirty env so I'm rebuilding with only wxgtk32 to see if it fails. In that case I "hopefully" only need to compare what packages are installed and find out why.
Comment 15 Daniel Engberg freebsd_committer freebsd_triage 2023-11-05 17:21:40 UTC
It fails because when the NLS option is enabled it tries execute:

post-build-NLS-on:
        @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale
Comment 16 Daniel Engberg freebsd_committer freebsd_triage 2023-11-05 17:25:37 UTC
Created attachment 246140 [details]
CMake version v3 (WIP)

Add missing libs
Comment out post-build-NLS-on
Comment 17 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-07 09:53:32 UTC
Created attachment 246173 [details]
CMake version 4 (Buildable, clean logs)

- Cleanup LIB_DEPENDS
- Put port options working
- Add specific OPT_LIB_DEPENDS where needed
- Add more cmake build options to match old version
- Disable more detections to reduce noise and to prevent problems in dirty enviroments
- Patched cmake to fix "bad symlink" in bin/wx-config (absolute -> relative)
- NLS if disabled as I didn't found any reference to it in cmake config files.
  Closest I found is:
  wx_option(wxUSE_INTL "use internationalization system")
  wx_option(wxUSE_XLOCALE "use x-locale support (requires wxLocale)")

- Looking for opinions if a COPYSHARE is needed to install:
  %%NLS%%share/locale/<COUNTRY>/LC_MESSAGES/wxstd-3.2.mo files.

Tested gtk2 and gtk3 flavors and options.

All building test was made on 15-CURRENT under poudriere-devel.
Ready to do run tests.
Comment 18 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-11 21:30:52 UTC
Created attachment 246248 [details]
Update to 3.2.3: portclippy, portfmt

- Pet portclippy
- Reformat with portfmt

cmake build gives some plist changes and ignores NLS option.
Let's stick with configure build to keep changes as minimum possible.

Will refresh consumers list soon and if everything ok with exp-run, I'll commit it.
Comment 19 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-13 11:05:31 UTC
==> exp-run: OK

Notes: 
[11:30:39] Failed ports: games/spring:build [1] comms/gnuradio:build [2]
[11:30:39] Skipped ports: games/springlobby
[11:30:39] Ignored ports: graphics/electricsheep

[1]: Broken
[2]: Build failing:
https://pkg-status.freebsd.org/beefy12/data/140releng-amd64-default/d5268d5f7157/logs/errors/gnuradio-3.8.4.0_13.log
(Not related with this PR)

Consumers: USE_WX 3.0+ 3.2
---
astro/opencpn
astro/phd2
audio/audacity
audio/spek
cad/PrusaSlicer
cad/kicad-devel
cad/kicad
comms/chirp
comms/cubicsdr
comms/cwstudio
comms/freedv
comms/gnuradio
comms/limesuite
comms/quisk
comms/trustedqsl
databases/grass7
databases/grass8
deskutils/treesheets
deskutils/xchm
devel/codeblocks
devel/wxformbuilder
editors/rehex
editors/wxhexeditor
emulators/libretro-pcsx2
emulators/playonbsd
games/0ad
games/golly
games/openyahtzee
games/springlobby
games/trenchbroom
graphics/diff-pdf
graphics/electricsheep
graphics/hugin
graphics/matplotplusplus
graphics/py-mayavi
graphics/py-visvis
graphics/wxsvg
lang/erlang-runtime21
lang/erlang-runtime22
lang/erlang-runtime23
lang/erlang-runtime24
lang/erlang-runtime25
lang/erlang-runtime26
lang/erlang-wx
lang/erlang
math/gnuplot
math/saga
math/sound-of-sorting
misc/pyobd
multimedia/dvdstyler
multimedia/photofilmstrip
science/gnudatalanguage
science/opensph
security/veracrypt
sysutils/passwordsafe
x11-fm/4pane
x11-toolkits/py-wxPython4
---

==> run-test: OK
---
deskutils/treesheets
audio/audacity
editors/wxhexeditor
games/golly
math/saga
cad/kicad
editors/rehex
sysutils/passwordsafe
astro/phd2
---

Should commit it today.
MFH to quarterly will take place in about a week to be sure that everything is ok.
Comment 20 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-13 11:18:09 UTC
Ai caramba, a new release! 3.2.4

Working on that...
Comment 21 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-14 12:06:55 UTC
Created attachment 246304 [details]
Update to 3.2.4
Comment 22 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-21 13:04:57 UTC
Good news!

I was able to apply 2 patches from OpenBSD and PrusaSlicer now builds ok: #275082
Comment 23 commit-hook freebsd_committer freebsd_triage 2023-11-22 11:14:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=818c20c1aa833f8f648f80c77f4eb3aafdb00299

commit 818c20c1aa833f8f648f80c77f4eb3aafdb00299
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-11-22 10:38:56 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-11-22 11:13:41 +0000

    cad/PrusaSlicer: Fix build with wxWidgets 3.2.4

    - Patches taken from OpenBSD port

    PR:             274367, 275082
    Approved by:    portmgr (build fix blanket)
    MFH:            2023Q4

 .../patch-src_slic3r_GUI_PhysicalPrinterDialog.cpp (new)      | 11 +++++++++++
 cad/PrusaSlicer/files/patch-src_slic3r_GUI_Plater.cpp         | 11 ++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)
Comment 24 commit-hook freebsd_committer freebsd_triage 2023-11-22 12:01:12 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d2fe51b145a2d8117b7a3b8baf0b2b76d01d27d

commit 8d2fe51b145a2d8117b7a3b8baf0b2b76d01d27d
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-11-22 10:38:56 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-11-22 11:15:15 +0000

    cad/PrusaSlicer: Fix build with wxWidgets 3.2.4

    - Patches taken from OpenBSD port

    PR:             274367, 275082
    Approved by:    portmgr (build fix blanket)
    MFH:            2023Q4

    (cherry picked from commit 818c20c1aa833f8f648f80c77f4eb3aafdb00299)

 .../patch-src_slic3r_GUI_PhysicalPrinterDialog.cpp (new)      | 11 +++++++++++
 cad/PrusaSlicer/files/patch-src_slic3r_GUI_Plater.cpp         | 11 ++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)
Comment 25 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-23 11:11:39 UTC
Consumers and run-test OK.
Comment 26 commit-hook freebsd_committer freebsd_triage 2023-11-23 11:23:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e469df520bef0163bba99153f24b1de06d9364f8

commit e469df520bef0163bba99153f24b1de06d9364f8
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-11-23 10:35:40 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-11-23 10:44:26 +0000

    x11-toolkits/wxgtk32: Update to 3.2.4

    - Pet portlint, portclippy and portfmt

    ChangeLog:
            https://www.wxwidgets.org/news/2023/11/wxwidgets-3.2.4-released/
            https://www.wxwidgets.org/news/2023/10/wxwidgets-3.2.3-released/
            https://www.wxwidgets.org/news/2023/02/wxwidgets-3.2.2.1-released/
            https://www.wxwidgets.org/news/2023/02/wxwidgets-3.2.2-released/

    PR:             274367
    Approved by:    desktop (maintainer timeout, >1 month)
    MFH:            2023Q4

 x11-toolkits/wxgtk32/Makefile  | 84 ++++++++++++++++++++++--------------------
 x11-toolkits/wxgtk32/distinfo  |  6 +--
 x11-toolkits/wxgtk32/pkg-plist | 32 ++++++++--------
 3 files changed, 64 insertions(+), 58 deletions(-)
Comment 27 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-23 11:38:42 UTC
- Add PR dep on audacity for MFH
Comment 28 Ivan Rozhuk 2023-11-23 18:01:17 UTC
Build fail:

c++ -shared -fPIC -o /tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib/libwx_gtk3u_xrc-3.2.so.0.2.2  xrcdll_xh_activityindicator.o xrcdll_xh_animatctrl.o xrcdll_xh_bannerwindow.o xrcdll_xh_bmp.o xrcdll_xh_bmpcbox.o xrcdll_xh_bmpbt.o xrcdll_xh_bttn.o xrcdll_xh_cald.o xrcdll_xh_chckb.o xrcdll_xh_chckl.o xrcdll_xh_choic.o xrcdll_xh_choicbk.o xrcdll_xh_clrpicker.o xrcdll_xh_cmdlinkbn.o xrcdll_xh_collpane.o xrcdll_xh_combo.o xrcdll_xh_comboctrl.o xrcdll_xh_dataview.o xrcdll_xh_datectrl.o xrcdll_xh_dirpicker.o xrcdll_xh_dlg.o xrcdll_xh_editlbox.o xrcdll_xh_filectrl.o xrcdll_xh_filepicker.o xrcdll_xh_fontpicker.o xrcdll_xh_frame.o xrcdll_xh_gauge.o xrcdll_xh_gdctl.o xrcdll_xh_grid.o xrcdll_xh_html.o xrcdll_xh_hyperlink.o xrcdll_xh_infobar.o xrcdll_xh_listb.o xrcdll_xh_listbk.o xrcdll_xh_listc.o xrcdll_xh_mdi.o xrcdll_xh_menu.o xrcdll_xh_notbk.o xrcdll_xh_odcombo.o xrcdll_xh_panel.o xrcdll_xh_propdlg.o xrcdll_xh_radbt.o xrcdll_xh_radbx.o xrcdll_xh_scrol.o xrcdll_xh_scwin.o xrcdll_xh_htmllbox.o xrcdll_xh_simplebook.o xrcdll_xh_sizer.o xrcdll_xh_slidr.o xrcdll_xh_spin.o xrcdll_xh_split.o xrcdll_xh_srchctrl.o xrcdll_xh_statbar.o xrcdll_xh_stbmp.o xrcdll_xh_stbox.o xrcdll_xh_stlin.o xrcdll_xh_sttxt.o xrcdll_xh_text.o xrcdll_xh_tglbtn.o xrcdll_xh_timectrl.o xrcdll_xh_toolb.o xrcdll_xh_toolbk.o xrcdll_xh_tree.o xrcdll_xh_treebk.o xrcdll_xh_unkwn.o xrcdll_xh_wizrd.o xrcdll_xmlres.o xrcdll_xmlrsall.o xrcdll_xh_bookctrlbase.o -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib    -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib   -Wl,-soname,libwx_gtk3u_xrc-3.2.so.0  -Wl,--undefined-version -fstack-protector-strong   -pthread -Wl,--undefined-version -fstack-protector-strong -L/usr/local/lib      -L/usr/local/lib -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lgthread-2.0 -pthread -lglib-2.0 -lintl -lX11 -lXxf86vm -lSM -L/usr/local/lib -lxkbcommon -L/usr/local/lib -lgspell-1 -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lglib-2.0 -lintl -lgobject-2.0 -lenchant-2 -L/usr/local/lib -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -lglib-2.0 -lintl -lgobject-2.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -L/usr/local/lib -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lXtst -L/usr/local/lib -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lharfbuzz -lfreetype -lfontconfig -lpng -lz -ljpeg -L/usr/local/lib -ltiff -llzma -ljbig    -pthread  -Wl,--undefined-version -fstack-protector-strong   -L/usr/local/lib  -Wl,--version-script,/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/version-script -lz -L/usr/local/lib -lsecret-1 -lglib-2.0 -lintl -lgobject-2.0 -lgio-2.0 -lexecinfo -L/usr/local/lib -lcurl -llzma -L/usr/local/lib -lm -L/usr/local/lib -lpcre2-32  -lwx_gtk3u_html-3.2 -lwx_gtk3u_core-3.2 -lwx_baseu_xml-3.2 -lwx_baseu-3.2 -lz -L/usr/local/lib -lsecret-1 -lglib-2.0 -lintl -lgobject-2.0 -lgio-2.0 -lexecinfo -L/usr/local/lib -lcurl -llzma -L/usr/local/lib -lm
(cd /tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib/; rm -f libwx_gtk3u_xrc-3.2.so libwx_gtk3u_xrc-3.2.so.0; ln -s libwx_gtk3u_xrc-3.2.so.0.2.2 libwx_gtk3u_xrc-3.2.so.0; ln -s libwx_gtk3u_xrc-3.2.so.0 libwx_gtk3u_xrc-3.2.so)
c++ -shared -fPIC -o /tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib/libwx_gtk3u_aui-3.2.so.0.2.2  auidll_framemanager.o auidll_dockart.o auidll_floatpane.o auidll_auibook.o auidll_auibar.o auidll_tabmdi.o auidll_tabart.o auidll_xh_aui.o auidll_xh_auitoolb.o   -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib    -L/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib   -Wl,-soname,libwx_gtk3u_aui-3.2.so.0  -Wl,--undefined-version -fstack-protector-strong   -pthread -Wl,--undefined-version -fstack-protector-strong -L/usr/local/lib      -L/usr/local/lib -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lgthread-2.0 -pthread -lglib-2.0 -lintl -lX11 -lXxf86vm -lSM -L/usr/local/lib -lxkbcommon -L/usr/local/lib -lgspell-1 -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lglib-2.0 -lintl -lgobject-2.0 -lenchant-2 -L/usr/local/lib -lgtk-3 -lgdk-3 -lharfbuzz -lpangocairo-1.0 -lpango-1.0 -lglib-2.0 -lintl -lgobject-2.0 -latk-1.0 -lcairo -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -L/usr/local/lib -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -L/usr/local/lib -lXtst -L/usr/local/lib -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lharfbuzz -lfreetype -lfontconfig -lpng -lz -ljpeg -L/usr/local/lib -ltiff -llzma -ljbig    -pthread  -Wl,--undefined-version -fstack-protector-strong   -L/usr/local/lib  -Wl,--version-script,/tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/version-script -lz -L/usr/local/lib -lsecret-1 -lglib-2.0 -lintl -lgobject-2.0 -lgio-2.0 -lexecinfo -L/usr/local/lib -lcurl -llzma -L/usr/local/lib -lm -L/usr/local/lib -lpcre2-32  -lwx_gtk3u_core-3.2 -lwx_baseu-3.2 -lz -L/usr/local/lib -lsecret-1 -lglib-2.0 -lintl -lgobject-2.0 -lgio-2.0 -lexecinfo -L/usr/local/lib -lcurl -llzma -L/usr/local/lib -lm
(cd /tmp/ports/usr/ports/x11-toolkits/wxgtk32/work-gtk3/wxWidgets-3.2.4/lib/; rm -f libwx_gtk3u_aui-3.2.so libwx_gtk3u_aui-3.2.so.0; ln -s libwx_gtk3u_aui-3.2.so.0.2.2 libwx_gtk3u_aui-3.2.so.0; ln -s libwx_gtk3u_aui-3.2.so.0 libwx_gtk3u_aui-3.2.so)
./src/unix/glegl.cpp:813:11: error: use of undeclared identifier 'gs_alreadySetSwapInterval'
    if ( !gs_alreadySetSwapInterval.count(this) )
          ^
./src/unix/glegl.cpp:822:13: error: use of undeclared identifier 'gs_alreadySetSwapInterval'
            gs_alreadySetSwapInterval.insert(this);
            ^
2 errors generated.



# make showconfig
===> The following configuration options are available for wx32-gtk3-3.2.4:
     GSTREAMER=off: Multimedia support via GStreamer
     MSPACK=off: Microsoft archives support
     NLS=on: Native Language Support
     WEBKIT=off: WebKit webpage renderer support
Comment 29 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-23 20:37:00 UTC
(In reply to Ivan Rozhuk from comment #28)

> error: use of undeclared identifier

What release/clang does it happens?
Tomorrow I will redo testport with custum config:

> ===> The following configuration options are available for wx32-gtk3-3.2.4:
>     GSTREAMER=off: Multimedia support via GStreamer
>     MSPACK=off: Microsoft archives support
>     NLS=on: Native Language Support
>     WEBKIT=off: WebKit webpage renderer support
Comment 30 robbak 2023-11-24 00:18:57 UTC
They know about this problem upstream - it happens builging with X11 and not wayland:

https://groups.google.com/g/wx-dev/c/8MWHatAuPcw

>   Oops, sorry, we should definitely define gs_alreadySetSwapInterval outside of 
>   GDK_WINDOWING_WAYLAND check. I'll try to fix this a.s.a.p.
Comment 31 robbak 2023-11-24 00:20:38 UTC
Github issue: 

https://github.com/wxWidgets/wxWidgets/issues/24076
Comment 32 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-24 07:54:26 UTC
(In reply to robbak from comment #31)
Thanks for issue link. As soon a fix is committed I will include it in port.

Cheers
Comment 33 robbak 2023-12-01 13:16:32 UTC
Patch has been committed upstream. Very simple solution - just remove the #ifdef GDK_WINDOWING_WAYLAND check.

https://github.com/vadz/wxWidgets/commit/5a7fba56390b319de2b7ec2f8c244d6144c5ebea
Comment 34 Nuno Teixeira freebsd_committer freebsd_triage 2023-12-02 11:55:34 UTC
(In reply to robbak from comment #33)

Waiting for 24076 to be closed and fix commited upstream (it was committed on a fork).
Comment 35 Mikhail T. 2023-12-02 21:18:50 UTC
(In reply to robbak from comment #30)
> They know about this problem upstream - it happens builging with X11 and not wayland

Frankly, I'm disappointed, that, although the problem and the fix for it were known to the ports-maintainers for a week, it still broke my build yesterday :(
Comment 36 Nuno Teixeira freebsd_committer freebsd_triage 2023-12-02 21:24:59 UTC
(In reply to Mikhail T. from comment #35)

I'm glad that fix is in the hands of upstream.

> Waiting for 24076 to be closed and fix commited upstream
Comment 37 commit-hook freebsd_committer freebsd_triage 2023-12-14 07:42:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7bd358e3891840cce005e92e88533dc8b1ba441c

commit 7bd358e3891840cce005e92e88533dc8b1ba441c
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-12-14 07:30:07 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-12-14 07:39:24 +0000

    x11-toolkits/wxgtk32: Fix build without WAYLAND

    - Apply temporary upstream patch to fix issue

    PR:             274367, 275484
    Approved by:    portmgr (build fix blanket)

 x11-toolkits/wxgtk32/Makefile | 3 +++
 x11-toolkits/wxgtk32/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 38 Nuno Teixeira freebsd_committer freebsd_triage 2023-12-14 07:46:27 UTC
Closing this PR now.
Thanks all!