Created attachment 245548 [details] Remove sockdebug The packing list for nut-devel contains references to the "sockdebug" program which is an internal NUT debugging tool that really should not be installed for production. Also, the reference to sockdebug.8.gz was missing %%MANPAGES%%.
Just changing the packing list will cause it to fail to create a package. What about removing the file from being installed? Try running make check-orphans with the patch applied. Besides, it might be removed when upstream next updates their sources.
The correct fix is to remove --with-dev from CONFIGURE_ARGS. This should remove additional development tools as well. I'll test a patch for this tonight, as it will remove more than just sockdebug.
Removing --with-dev removes 86 files. And removing it in the -devel port makes no sense unless I make the same change in the regular nut port. I will add a DEV option to both ports, and make the DEV option optional.
I don't believe the removal of sockdebug from the packing list is directly related to the --with-dev option. The regular nut port does not have sockdebug in the packing list. This patch removes sockdebug from the nut-devel packing list, which results in it matching the content of the packing list from the regular nut port. FWIW, I am all in favor of making the --with-dev option conditional in both nut and nut-devel, but that won't completely address the issue.
It is. ALso, try your patch using, make check-orphans or make package You will see your patch will fail to package.
I certainly don't see sockdebug in the standard nut port: denny % /cache/FreeBSD-ports $ grep -r sockdebug sysutils/nut* sysutils/nut-devel/0001-Remove-sockdebug-from-the-packing-list.patch:Subject: [PATCH] Remove sockdebug from the packing list. sysutils/nut-devel/0001-Remove-sockdebug-from-the-packing-list.patch:-libexec/sockdebug sysutils/nut-devel/0001-Remove-sockdebug-from-the-packing-list.patch:@@ -271,7 +270,6 @@ libexec/sockdebug sysutils/nut-devel/0001-Remove-sockdebug-from-the-packing-list.patch:-man/man8/sockdebug.8.gz denny % /cache/FreeBSD-ports $ It's also not there in the current git mirror: https://raw.githubusercontent.com/freebsd/freebsd-ports/main/sysutils/nut/pkg-plist
Also, agree that make check-orphans is an issue, but make package appears to work for me.
make package should also fail. The ultimate test is poudriere.
Okay, I will to defer to you as I am not a FreeBSD Ports expert.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=faa546d2d9cd0f01e0030c7f7a79afb635b05f87 commit faa546d2d9cd0f01e0030c7f7a79afb635b05f87 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2023-10-11 02:09:40 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2023-10-11 02:50:49 +0000 sysutils/nut-devel: Fix MANPAGES plist PR: 274395 sysutils/nut-devel/pkg-plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4da0d4b17cba94ae605f3541234a7436d723c170 commit 4da0d4b17cba94ae605f3541234a7436d723c170 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2023-10-11 02:44:01 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2023-10-11 02:50:50 +0000 sysutils/nut*: Optionally install developer files Most users do not need files needed for nut development. Make them optional. PR: 274395 MFH: 2023Q4 sysutils/nut-devel/Makefile | 9 ++- sysutils/nut-devel/pkg-plist | 172 +++++++++++++++++++++---------------------- sysutils/nut/Makefile | 12 ++- sysutils/nut/pkg-plist | 166 ++++++++++++++++++++--------------------- 4 files changed, 184 insertions(+), 175 deletions(-)
Looking at the commit for nut-devel, shouldn't libexec/sockdebug be prefixed?
With the commit, I am back to the same error that I started off with for a dependent package. It is expecting sockdebug to be present because it is unconditionally in the packing list. --- ===> Staging for pfSense-pkg-nut-2.8.1 ===> pfSense-pkg-nut-2.8.1 depends on package: nut-devel>=0 - not found ===> Installing for nut-devel-2023.10.07_1 ===> Checking if nut-devel is already installed ===> Registering installation for nut-devel-2023.10.07_1 as automatic pkg-static: Unable to access file /usr/ports/sysutils/nut-devel/work/stage/usr/local/libexec/sockdebug:No such file or directory *** Error code 1 Stop. make[2]: stopped in /usr/ports/sysutils/nut-devel *** Error code 1 Stop. make[1]: stopped in /usr/ports/sysutils/nut-devel *** Error code 1 Stop. make: stopped in /usr/ports/sysutils/pfSense-pkg-nut
Try fetching again. I committed a fix for this last error.
That works. Thanks Cy.
A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7a175c13de0006f86a98a7ae3257306c969a4bdb commit 7a175c13de0006f86a98a7ae3257306c969a4bdb Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2023-10-11 02:44:01 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2023-10-14 00:01:14 +0000 sysutils/nut*: Optionally install developer files Most users do not need files needed for nut development. Make them optional. PR: 274395 (cherry picked from commit 4da0d4b17cba94ae605f3541234a7436d723c170) sysutils/nut-devel/Makefile | 9 ++- sysutils/nut-devel/pkg-plist | 172 +++++++++++++++++++++---------------------- sysutils/nut/Makefile | 12 ++- sysutils/nut/pkg-plist | 166 ++++++++++++++++++++--------------------- 4 files changed, 184 insertions(+), 175 deletions(-)
A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=74492e5846227829e1de160a0940f3893daa3930 commit 74492e5846227829e1de160a0940f3893daa3930 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2023-10-11 02:09:40 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2023-10-14 00:00:59 +0000 sysutils/nut-devel: Fix MANPAGES plist PR: 274395 (cherry picked from commit faa546d2d9cd0f01e0030c7f7a79afb635b05f87) sysutils/nut-devel/pkg-plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fixed.