Bug 274438 - net-p2p/monero-cli: Update to 0.18.3.1
Summary: net-p2p/monero-cli: Update to 0.18.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-12 19:44 UTC by Toni B
Modified: 2023-10-19 10:36 UTC (History)
1 user (show)

See Also:


Attachments
Patch to update monero-cli from 0.18.2.2 to 0.18.3.1 (1.46 KB, patch)
2023-10-12 19:44 UTC, Toni B
no flags Details | Diff
Patch to update monero-cli from 0.18.2.2 to 0.18.3.1 (fixed) (1.44 KB, patch)
2023-10-16 06:27 UTC, Toni B
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toni B 2023-10-12 19:44:27 UTC
Created attachment 245587 [details]
Patch to update monero-cli from 0.18.2.2 to 0.18.3.1

Hi

I'd like to contribute a patch to upgrade monero-cli to 0.18.3.1

I built it with poudriere on a 13.2p4 jail and have it running normally in another 13.2p4 system.

Changelog: https://github.com/monero-project/monero/releases/tag/v0.18.3.1
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-16 05:04:49 UTC
Your patch is defective: all the tabs have been replaced with spaces.  When submitting patches, make sure they have not been molested in any way.  Ideally prepare patches by making a commit to the FreeBSD ports repository.  Then run "git format-patch" to generate a patch file, which you then upload.  Do not copy/paste with your mouse from a console window, that may destroy tabs.
Comment 2 Toni B 2023-10-16 06:27:26 UTC
Created attachment 245666 [details]
Patch to update monero-cli from 0.18.2.2 to 0.18.3.1 (fixed)

Untouched diff file
Comment 3 Toni B 2023-10-16 06:29:14 UTC
(In reply to Robert Clausecker from comment #1)
"Do not copy/paste with your mouse from a console window, that may destroy tabs."

Guilty as charged. That's exactly what I did. I wasn't aware it would be a problem because of white space and was lazy transferring the file from the VM where it was created. The new patch is the original untouched diff file.

Sorry for the waste of time.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-10-18 18:43:13 UTC
Thank you for the enhanced patch.

Would you like to take up maintainership of this unmaintained port?
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-10-19 07:09:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dd4aa61a9e9d623aa62f2ff529e933f240aa0223

commit dd4aa61a9e9d623aa62f2ff529e933f240aa0223
Author:     Toni B <tonidasbabes88@gmail.com>
AuthorDate: 2023-10-18 18:42:45 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-19 07:07:31 +0000

    net-p2p/monero-cli: update to 0.18.3.1

    Changelog: https://github.com/monero-project/monero/releases/tag/v0.18.3.1

    PR:             274438

 net-p2p/monero-cli/Makefile | 7 +------
 net-p2p/monero-cli/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 9 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-19 07:13:38 UTC
Thank you for your contribution.

If you want to maintain this port in the future, feel free to set the MAINTAINER field to your email address in a future submission.
Comment 7 Toni B 2023-10-19 10:36:57 UTC
(In reply to Robert Clausecker from comment #6)
Thank you for the offer, but I need to get more experience before I take that responsibility. Right now I can only do very simple version bumps.