Bug 274603 - misc/py-colored: update to v2.2.3
Summary: misc/py-colored: update to v2.2.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://gitlab.com/dslackw/colored/-/...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-20 04:31 UTC by Pavel Timofeev
Modified: 2023-10-23 01:58 UTC (History)
1 user (show)

See Also:


Attachments
port patch (1.31 KB, patch)
2023-10-20 04:31 UTC, Pavel Timofeev
timp87: maintainer-approval+
Details | Diff
port patch 2 (1.40 KB, patch)
2023-10-22 14:58 UTC, Pavel Timofeev
timp87: maintainer-approval+
Details | Diff
port patch 3 (1.42 KB, patch)
2023-10-22 19:03 UTC, Pavel Timofeev
timp87: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2023-10-20 04:31:44 UTC
Created attachment 245752 [details]
port patch

- update to v2.2.3
- handle switch to pyproject.toml (pep517)
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-21 21:10:53 UTC
The build fails (on i386/amd64 FreeBSD 13.2) as follows:

===>  Building for py39-colored-2.2.3
* Getting build dependencies for wheel...

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pyproject_hooks/_impl.py", line 321, in _call_hook
    raise BackendUnavailable(data.get('traceback', ''))
pyproject_hooks._impl.BackendUnavailable: Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pyproject_hooks/_in_process/_in_process.py", line 77, in _build_backend
    obj = import_module(mod_path)
  File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'flit_core'

ERROR Backend 'flit_core.buildapi' is not available.
*** Error code 1

Please check and resubmit.
Comment 2 Pavel Timofeev 2023-10-22 05:13:56 UTC
Well, I can't reproduce this error.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-10-22 05:40:36 UTC
(In reply to Pavel Timofeev from comment #2)

Are you building in Poudriere?  It is likely that you have the required dependency installed but forgot to list it in the Makefile.  When building with Poudriere, only dependencies declared in the Makefile are installed into the builder jail.
Comment 4 Pavel Timofeev 2023-10-22 14:58:43 UTC
Created attachment 245798 [details]
port patch 2

Sorry, here is the right one
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-10-22 17:02:07 UTC
Thank you for the update.

Are you sure the dependency on devel/py-flit-core@${PY_FLAVOR} is only needed for building and not also to run the software?  Note that build dependencies are not registered in the built package and can be deinstalled after building (when installing binary packaged, they aren't installed at all).

Please let me know what the situation is.  I can add the dependency to RUN_DEPENDS if required.
Comment 6 Pavel Timofeev 2023-10-22 19:03:59 UTC
Created attachment 245805 [details]
port patch 3

Yes, I'm sure
It is requiring flit-core for build only https://gitlab.com/dslackw/colored/-/blob/master/pyproject.toml?ref_type=heads#L2
Also I have just verified it manually

Notices python version requirement. Put it into Makefile.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-10-23 01:54:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d3566f3e6f5d3f23f1339c1434662520b3dc97ef

commit d3566f3e6f5d3f23f1339c1434662520b3dc97ef
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2023-10-20 02:55:36 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-23 01:51:29 +0000

    misc/py-colored: update to v2.2.3

    - update to v2.2.3
    - handle switch to pyproject.toml (pep517)

    Changelog: https://gitlab.com/dslackw/colored/-/blob/2.2.3/CHANGES.md?ref_type=tags

    PR:             274603

 misc/py-colored/Makefile | 8 +++++---
 misc/py-colored/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 6 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-10-23 01:58:36 UTC
Thank you for your contribution.