Bug 274611 - editors/mg: Update to 20231016
Summary: editors/mg: Update to 20231016
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-20 15:19 UTC by Mark Willson
Modified: 2023-10-27 06:38 UTC (History)
2 users (show)

See Also:


Attachments
Git format-patch (6.77 KB, patch)
2023-10-20 15:19 UTC, Mark Willson
no flags Details | Diff
Git format-patch (7.35 KB, patch)
2023-10-23 08:50 UTC, Mark Willson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Willson 2023-10-20 15:19:24 UTC
Created attachment 245761 [details]
Git format-patch

Update mg to the version released as part of OpenBSD 7.4. Change origin of source tar ball.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-10-21 20:33:11 UTC
Is there a changelog for this update?

Please regenerate the patches with "make makepatch" instead of using hand-rolled patches.  This reduces the amount of noise on future updates.

You should be able to avoid the != in STAGEGRP by setting

    STAGEGRP= ${.MAKE.GID}
Comment 2 Mark Willson 2023-10-23 08:50:51 UTC
Created attachment 245817 [details]
Git format-patch
Comment 3 Mark Willson 2023-10-23 08:55:57 UTC
Updated patch. 

I've added a change log to the git commit message.  Patch files have been created with make makepatch. Modified Makefile to remove STAGEGRP!= - thanks.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-10-24 02:58:05 UTC
Unfortunately .MAKE.GID is not defined in the version of make we ship on 12.4 so the port fails to build there.  I'll put a workaround in which we can remove after FreeBSD 12 is EOL.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-10-27 06:34:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b47b76304ccebb0a40acd56f1687e232f0ebedeb

commit b47b76304ccebb0a40acd56f1687e232f0ebedeb
Author:     Mark Willson <cdr.nil@gmail.com>
AuthorDate: 2023-10-23 08:45:40 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-10-27 06:32:10 +0000

    editors/mg: Update to OpenBSD 7.4 version; modify location of source tarball

    Changes in this release:

      * New command set-tab-width to change the tabulator width on a per-buffer
        basis.
      * Let the space-to-tabstop command move to the right position even if
        the line contains tabs, control characters, or non-ASCII bytes.
      * Fall back to /bin/sh if $SHELL is undefined.
      * Fix parsing of tag files with duplicate entries. Instead of erroring
        out, ignore duplicates. Fixes using /var/db/libc.tags again.
      * Change the visit-tags-table command to immediately load the tag
        file, and drop the lazy mechanics.
      * Do not leak memory in pop-tag-mark if it fails to switch buffers.
      * Fix a read buffer overrun caused by -u arguments longer than 1023 bytes.
      * Fix a write buffer overrun on the stack caused by blink-and-insert
        matching a very long line that is not currently visible in the
        window.
      * Skip checking permissions of conffile with access(2).
      * Resurrect no-tab-mode and add it to the list of modes that can be
        set with set-default-mode.

    From: https://www.openbsd.org/74.html

    PR:             274611

 editors/mg/Makefile                   | 10 ++++----
 editors/mg/distinfo                   |  6 ++---
 editors/mg/files/patch-Makefile       | 27 +++-----------------
 editors/mg/files/patch-def.h (new)    | 10 ++++++++
 editors/mg/files/patch-fileio.c (new) | 19 ++++++++++++++
 editors/mg/files/patch-main.c (new)   | 47 +++++++++++++++++++++++++++++++++++
 editors/mg/files/patch-tags.c (new)   | 11 ++++++++
 7 files changed, 99 insertions(+), 31 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-10-27 06:38:02 UTC
Thank you for your contribution.