Bug 274667 - net/libyang2: update to 2.1.128 fixes net/frr8 regression
Summary: net/libyang2: update to 2.1.128 fixes net/frr8 regression
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Cochard
URL: https://github.com/CESNET/libyang/rel...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-23 09:35 UTC by Franco Fichtner
Modified: 2023-11-08 15:25 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (olivier)

Attachments
2.1.128 patch (1.61 KB, patch)
2023-10-23 09:35 UTC, Franco Fichtner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2023-10-23 09:35:31 UTC 
Created attachment 245819 [details]
2.1.128 patch

Hi,

There appears to be a regression in the latest libyang version available in ports. For more details see:

https://github.com/FRRouting/frr/issues/14626

Apparently libyang already pushed an update so I've added it here.


Cheers,
Franco
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2023-11-08 09:01:07 UTC 
testbuilds@work
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2023-11-08 09:33:18 UTC 
(In reply to Kurt Jaeger from comment #1)
testbuilds are fine.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-08 11:22:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d4ca64c4d64209b53134142675ed159ed738da9b

commit d4ca64c4d64209b53134142675ed159ed738da9b
Author:     Olivier Cochard <olivier@FreeBSD.org>
AuthorDate: 2023-11-08 11:16:21 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2023-11-08 11:21:46 +0000

    net/libyang2: Update to 2.1.128

    Fix net/frr8 regression ("Can no longer match a prefix-list in a route-map").

    PR:             274667
    Reported by:    Franco Fichtner <franco@opnsense.org>

 net/frr8/Makefile      | 2 +-
 net/libyang2/Makefile  | 2 +-
 net/libyang2/distinfo  | 6 +++---
 net/libyang2/pkg-plist | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
Comment 4 Olivier Cochard freebsd_committer freebsd_triage 2023-11-08 11:24:05 UTC 
Thanks for your patch and test!
Comment 5 Franco Fichtner 2023-11-08 11:24:59 UTC 
Thanks, but can we try to retain authorship please now that we are on git?
Comment 6 Olivier Cochard freebsd_committer freebsd_triage 2023-11-08 11:51:33 UTC 
(In reply to Franco Fichtner from comment #5)
I've used a `git apply ~/0001-net-libyang2-appears-to-fix-issues-with-FRR-vs.-vers.patch`.

Would you like another way ?
Comment 7 Franco Fichtner 2023-11-08 11:52:44 UTC 
With a git patch better to use "git am" and "git commit --amend" to modify the commit message.


Thanks,
Franco
Comment 8 Renato Botelho freebsd_committer freebsd_triage 2023-11-08 15:25:20 UTC 
(In reply to Olivier Cochard from comment #6)
you can use `git am` to preserve authorship of the git patch, or, if you do `git apply`, as you did, just remember to add `--author="Real Name <email@address.com>" parameter on `git commit`