Created attachment 245831 [details] NotiMail port Server-side email notification manager with push support
Thank you for your submission. I apologise for the delay in getting this one processed. Please check the following issues: - we don't want leading v in PORTVERSION. Please instead set DISTVERSIONPREFIX= v DISTVERSION= 0.11.2 - GH_TAGNAME defaults to ${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX} which is correct in your case. Please discard the line that sets it. - PREFIX is predefined in SUB_LIST, no need to set it yourself - please remove the leading and trailing === from pkg-message - this needs USE_RC_SUBR - python versions before 3.6 are not supported, so please remove 3.6+ - no files or directories should be owned by nobody. You could avoid this by using the account daemon instead. - check if it is appropriate to use the @sample mechanism for your config.ini - your pkg-plist already sets up correct permissions for /var/cache/notimail and /var/log/notimal, so no need to instruct the user to change permissions - are you sure /var/cache is the right directory for a database file? Daemons must be able to cope with /var/cache being cleared at any point in time. If thee database needs to be preserved, put it into /var/db.
Friendly ping
Created attachment 257742 [details] Patch for NotiMail 2.0.1 - trying to follow the requests Sorry for the delay, I intended to generate the port directly for the new version but didn't create it due to lack of time. I’ve fixed the requests and prepared the patch for the new release – let me know if there’s anything to fix or correct. Thank you!
(In reply to Stefano Marinelli from comment #3) Looking good! Will commit with my next batch. That said, I'll copy-edit your pkg-message to remove step 1 as the @sample mechanism ensures the sample configuration file is copied to the non-sample file on installation. One minor issue that I can fix on commit: the letter case between package name and upstream name differs. We generally prefer to use the same letter case as upstream. Is it okay if I change the port to use the same letter case as upstream? If yes, shall I also change the name of the installed binary to use mixed case?
(In reply to Robert Clausecker from comment #4) Perfect, thank you! Of course, go ahead with the changes you think are necessary to make it better integrated in the ports and more consistent with the general rules. It's fine for me to use mixed case even for binary - after all, the final goal is for the user to use it via the rc script, so I don't think it will be a problem if it's not all in lowercase.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=27ecd7d58ffddc87a191128ad8cb9921539f53fa commit 27ecd7d58ffddc87a191128ad8cb9921539f53fa Author: Stefano Marinelli <stefano@dragas.it> AuthorDate: 2025-02-22 17:33:01 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2025-03-16 10:19:26 +0000 mail/notimail: Server-side email notification manager with push support NotiMail is a server-side email notification manager that utilizes various push providers for real-time alerts, conserving mobile battery life without compromising on notification immediacy. WWW: https://github.com/draga79/NotiMail PR: 274676 mail/notimail/Makefile (new) | 36 +++++++++++++++++++++++ mail/notimail/distinfo (new) | 3 ++ mail/notimail/files/notimail.in (new) | 49 ++++++++++++++++++++++++++++++++ mail/notimail/files/pkg-message.in (new) | 9 ++++++ mail/notimail/pkg-descr (new) | 3 ++ mail/notimail/pkg-plist (new) | 5 ++++ 6 files changed, 105 insertions(+)
Thank you for your contribution. Sorry for the slow commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c4d49261bebee27d93a717222128eaa3520c0086 commit c4d49261bebee27d93a717222128eaa3520c0086 Author: Zsolt Udvari <uzsolt@FreeBSD.org> AuthorDate: 2025-03-19 19:51:13 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2025-03-19 19:52:37 +0000 mail/notimail: Hook to the build PR: 274676 Reported by: antoine mail/Makefile | 1 + 1 file changed, 1 insertion(+)