Created attachment 245954 [details] 1.3.8 to 1.3.11 patch Change updates nfsen to v1.3.11 and use active source repository (same as nfdump).
^Triage: [tags] in issue Titles are deprecated.
Current version in ports is broken, it doesn't work with nfdump 1.7.x Either this patch should be merged, or the port deprecated.
(In reply to chadf from comment #0) chadf thank you for the patch! The nfsen port currently has no maintainer, so it is a bit slow and difficult to get patches merged. Would you like to take over maintainership of the port? :)
(In reply to Einar Bjarni Halldórsson from comment #2) +1 this should absolutely get merged
This update needs a bit more of work before getting merged. chadf, can you have a look? ====> Running Q/A tests (stage-qa) Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for 'libexec/nfsen/Nfcomm.pm.bak' Error: '%%PERL%%' is an invalid shebang you need USES=shebangfix for 'libexec/nfsen/NfConf.pm.bak' Warning: port uses /usr/local/var instead of /var Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. Warning: /wrkdirs/usr/ports/net-mgmt/nfsen/work/pkg-message not in UCL format, will be shown on initial install only. Warning: See https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message *** Error code 1
I wasn't able get the shebang error. However, it does seem to be referencing the backup files from reinplace. I've got it down to these: ====> Running Q/A tests (stage-qa) Warning: port uses /usr/local/var instead of /var Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. /usr/local/var may be needed for legacy data purposes. Perhaps a legacy directory option could be added in the future, but I'd rather not try to combine it with the version update patch. It requires perl 5.10.1+, so all ports supported versions of perl should work out of the box. Also, when trying out portlint, I get: WARN: /usr/ports/net-mgmt/nfsen/files/patch-etc_nfsen-dist.conf: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. However, running 'make makepatch' doesn't seem to resolve it. If the remaining warnings seems acceptable, I will submit an updated patch file.
(In reply to chadf from comment #6) Yes, please. Send the update and then we will try from there :-) Thanks!
Created attachment 246433 [details] 1.3.8 to 1.3.11 patch (v2)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0223f14e38ca8a9477cdc1e0a9b6af29dd642f52 commit 0223f14e38ca8a9477cdc1e0a9b6af29dd642f52 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-11-20 08:10:43 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-11-22 08:46:17 +0000 net-mgmt/nfsen: Update to 1.3.11 While here, don't generate backup files after replacing. Otherwise poudriere complains about wrong shebangs in the .bak files. PR: 274776 Reported by: chadf@triularity.org net-mgmt/nfsen/Makefile | 31 ++++++++++++---------- net-mgmt/nfsen/distinfo | 6 ++--- net-mgmt/nfsen/files/patch-etc_nfsen-dist.conf | 12 ++++----- .../nfsen/files/patch-libexec_NfSenRRD.pm (gone) | 11 -------- net-mgmt/nfsen/files/pkg-message.in (new) | 17 ++++++++++++ 5 files changed, 43 insertions(+), 34 deletions(-)
Committed, Thanks!