Created attachment 245972 [details] games/moonlight-qt Fix missing openssl error when building on Freebsd 12.4-RELEASE Fix missing openssl when building on Freebsd 12.4-RELEASE There is openssl.pc in /usr/libdata/pkgconf on FreeBSD 13.2-RELEASE. But there is nothing on 12.4-RELEASE.So 'PKGCONF += openssl' in .pro file will faild on it. Openssl 1.1.1q is the native part of the system.It should not be checked for the existence of this dependency without limiting the openssl version. Now i delete PKGCONF += openssl and manual add LDFLAGS to it on 12.4-RELEASE . Log URL: https://pkg-status.freebsd.org/beefy5/data/124i386-default/16bdcaa2bc90/logs/moonlight-qt-5.0.0.log Build URL: https://pkg-status.freebsd.org/beefy5/build.html?mastername=124i386-default&build=16bdcaa2bc90
Created attachment 246058 [details] Fix build error for 12.4-RELEASE and Update to 5.0.1 for moonlight-qt Fix build error for 12.4-RELEASE on FreeBSD. And Update vertion to 5.0.1.
Review: https://reviews.freebsd.org/D42443
Is there a changelog for this update? There's no need to open a Phabricator revision for such a simple patch. Is the patch on Phabricator the same one you attached here? If not, which one would you like to see committed? MFH is impossible as the port is not present on the quarterly branch.
(In reply to Robert Clausecker from comment #3) The version 5.0.1 is upstream's Update. From: https://github.com/moonlight-stream/moonlight-qt/releases/tag/v5.0.1 Relative changelog with linux/BSD: Bugfixes: Fixed connection issue streaming from some hosts running GeForce Experience or Sunshine v0.20 and earlier. Fixed incorrect detection of libva-drm library on Linux.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=619b513bbc9da75f616382b85cfec4a9681e34a3 commit 619b513bbc9da75f616382b85cfec4a9681e34a3 Author: Armin Zhu <lisp_25689@163.com> AuthorDate: 2023-11-02 05:32:40 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-11-07 00:16:49 +0000 games/moonlight-qt: Update to 5.0.1 Changelog: https://github.com/moonlight-stream/moonlight-qt/releases/tag/v5.0.1 PR: 274791 games/moonlight-qt/Makefile | 2 +- games/moonlight-qt/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=87f3f099796e80d9b44ef03fc2f63bdc52fa30fa commit 87f3f099796e80d9b44ef03fc2f63bdc52fa30fa Author: Armin Zhu <lisp_25689@163.com> AuthorDate: 2023-10-29 13:41:39 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-11-07 00:16:49 +0000 games/moonlight-qt: Fix build error for 12.4-RELEASE There is openssl.pc in /usr/libdata/pkgconf on FreeBSD 13.2-RELEASE. But there is nothing on 12.4-RELEASE.So 'PKGCONF += openssl' in .pro file will fail on it. Openssl 1.1.1q is the native part of the system. It should check for the existence of this dependency without limiting the openssl version. I have deleted PKGCONF += openssl and manual add appropriate LDFLAGS on 12.4-RELEASE PR: 274791 games/moonlight-qt/Makefile | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-)
Thank you for your submission.