Bug 274801 - audio/guitarix-lv2: Fails to build, can't determine version of faust
Summary: audio/guitarix-lv2: Fails to build, can't determine version of faust
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/brummer10/guitarix...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-29 21:19 UTC by Daniel Engberg
Modified: 2025-01-18 17:27 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch for Makefile (1.37 KB, patch)
2024-03-18 00:54 UTC, gebhart 		no flags Details | Diff
Unbreak guitarix lv2 (1.28 KB, patch)
2024-10-05 05:48 UTC, Loïc Bartoletti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-10-30 03:18:23 UTC 
Unfortunately this port is broken with the latest faust.
I've let the upstream know a few days ago, but they still didn't fix it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-30 03:21:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f428abcfef4a36327aa88d29d2ba48abf376ad0c

commit f428abcfef4a36327aa88d29d2ba48abf376ad0c
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-30 03:19:17 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-10-30 03:19:17 +0000

    audio/guitarix-lv2: Broken: fails to find latest faust

    PR:             274801
    Reported by:    Daniel Engberg <diizzy@FreeBSD.org>

 audio/guitarix-lv2/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-04 05:38:02 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f35d895b40c27be1a421b980236ec92589aabd3a

commit f35d895b40c27be1a421b980236ec92589aabd3a
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-10-30 03:19:17 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-11-04 05:37:29 +0000

    audio/guitarix-lv2: Broken: fails to find latest faust

    PR:             274801
    Reported by:    Daniel Engberg <diizzy@FreeBSD.org>

    (cherry picked from commit f428abcfef4a36327aa88d29d2ba48abf376ad0c)

 audio/guitarix-lv2/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-11-04 17:47:43 UTC 
This issue has already been fixed up stream:

https://github.com/brummer10/guitarix/commit/5871254109fc953ba83b495c7c6627da73e19852

See if you can apply the fix.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2023-11-04 17:49:03 UTC 
(In reply to Robert Clausecker from comment #4)


This issue has been fixed, but there is another one, the build failure, that I just reported yesterday.
Comment 6 gebhart 2024-03-18 00:54:33 UTC 
Created attachment 249250 [details]
patch for Makefile
Comment 7 gebhart 2024-03-18 01:00:21 UTC 
Comment on attachment 249250 [details]
patch for Makefile

faust is not necessary to build/run it, only for developers according to the author.
So this patch simply removes the faust dependency and builds here without a problem on FreeBSD 13.2 on amd64 + i386 and 14.0 aarch64.
Comment 8 Loïc Bartoletti freebsd_committer freebsd_triage 2024-10-05 05:48:03 UTC 
Created attachment 254011 [details]
Unbreak guitarix lv2

yuri,

This is a patch to build guitarix 0.44.1. Nothing special, except a new patch for a wrong open mode in a wscript file.

Tested on FreeBSD 14.1
poudriere OK 14.1 amd64
Comment 9 Loïc Bartoletti freebsd_committer freebsd_triage 2024-10-05 05:48:53 UTC 
I haven't tested with the latest version of guitarix (0.46) since the tarball doesn't include all submodules...
Comment 10 Loïc Bartoletti freebsd_committer freebsd_triage 2024-10-05 06:36:35 UTC 
yuri@ I made some progress on guitarix 0.46.0: https://github.com/lbartoletti/freebsd-ports/tree/guitarix-lv2-0.46.0

However, there is a problem with my GH_TUPLE/submodules for NAM and RT_Neural
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2025-01-18 17:27:58 UTC 
Removed from tree in commit c74e0978db066b9e6684678745d1dbdbb63088e0