Bug 275069 - games/jaggedalliance2: unbreak amd64 build on fbsd 14+
Summary: games/jaggedalliance2: unbreak amd64 build on fbsd 14+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-14 05:53 UTC by Martin Neubauer
Modified: 2023-11-18 20:27 UTC (History)
2 users (show)

See Also:
timp87: maintainer-feedback+
fuz: merge-quarterly+

Attachments
Fix for amd64 on FBSD14 (442 bytes, patch)
2023-11-14 05:53 UTC, Martin Neubauer 		m.ne: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2023-11-14 05:53:27 UTC 
Created attachment 246289 [details]
Fix for amd64 on FBSD14

Extend the fix from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274601 to cover amd64 as well.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-11-16 20:55:08 UTC 
I'll go ahead and just remove the ARCH check altogether.

This goes under blanket approval for build fixes.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-18 20:24:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e3aeb5c7a93b7b9b6df753648e0669143476916d

commit e3aeb5c7a93b7b9b6df753648e0669143476916d
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-11-16 20:53:33 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-18 20:20:41 +0000

    games/jaggedalliance2: extend 14.0+ build fix to all architectures

    The fix seems to be needed on amd64 too, so apply it to all
    architectures just in case.

    Reported by:    Martin Neubauer <m.ne@gmx.net>
    Approved by:    portmgr (build fix blanket)
    PR:             275069, 274601
    MFH:            2023Q4

 games/jaggedalliance2/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-18 20:25:29 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=481fc59a5fde8489b9a9583144b24204d255b2fb

commit 481fc59a5fde8489b9a9583144b24204d255b2fb
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-11-16 20:53:33 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-18 20:24:40 +0000

    games/jaggedalliance2: extend 14.0+ build fix to all architectures

    The fix seems to be needed on amd64 too, so apply it to all
    architectures just in case.

    Reported by:    Martin Neubauer <m.ne@gmx.net>
    Approved by:    portmgr (build fix blanket)
    PR:             275069, 274601
    MFH:            2023Q4

    (cherry picked from commit e3aeb5c7a93b7b9b6df753648e0669143476916d)

 games/jaggedalliance2/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-11-18 20:27:58 UTC 
Thank you for the report.