Bug 275082 - cad/PrusaSlicer: Fails to build with x11-toolkits/wxgtk32 3.2.4
Summary: cad/PrusaSlicer: Fails to build with x11-toolkits/wxgtk32 3.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks: 274367
  Show dependency treegraph
 
Reported: 2023-11-14 15:28 UTC by Nuno Teixeira
Modified: 2023-11-22 12:01 UTC (History)
2 users (show)

See Also:


Attachments
Update to 2.6.1 (987 bytes, patch)
2023-11-15 10:30 UTC, Nuno Teixeira
no flags Details | Diff
Update to 2.6.1: Fix build (3.20 KB, patch)
2023-11-21 12:58 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2023-11-14 15:28:37 UTC
Certanly related to:

audio/audacity fix with wx 3.2.4:

https://github.com/wxWidgets/wxWidgets/pull/23309
https://github.com/NixOS/nixpkgs/pull/266945#issuecomment-1807292941

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275078

Could you update to 2.6.1 version so we can check if it is ready to wx update?

Thanks 

---
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/slic3r/GUI/Plater.cpp:4900:13: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical]
        if (sidebar->show_reslice(ready_to_slice) |
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                  ||
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/slic3r/GUI/Plater.cpp:4900:13: note: cast one or both operands to int to silence this warning
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/slic3r/GUI/Plater.cpp:5284:11: error: call to member function 'load_files' is ambiguous
    if (! load_files({ into_path(filename) }).empty()) {
          ^~~~~~~~~~
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/slic3r/GUI/Plater.hpp:177:25: note: candidate function
    std::vector<size_t> load_files(const std::vector<boost::filesystem::path>& input_files, bool load_model = true, bool load_config = true, bool imperial_units = false);
                        ^
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/slic3r/GUI/Plater.hpp:181:10: note: candidate function
    bool load_files(const wxArrayString& filenames, bool delete_after_load = false);
         ^
7 warnings and 1 error generated.
---
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-15 10:30:18 UTC
Created attachment 246328 [details]
Update to 2.6.1

2.6.1 still fail with wx 3.2.4:
https://github.com/prusa3d/PrusaSlicer/issues/11671
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-21 12:58:36 UTC
Created attachment 246463 [details]
Update to 2.6.1: Fix build

- add patches from OpenBSD port
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-11-22 09:55:35 UTC
Version 2.6.1 runs ok, but I was not able to test printer since I don't have one and for that I will commit fix needed to build with wxWidgets 3.2.4 only.

No portrevision bump needed at this stage. All wx consumers will be bumped when 3.2.4 commit is out.

Thanks
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-22 11:14:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=818c20c1aa833f8f648f80c77f4eb3aafdb00299

commit 818c20c1aa833f8f648f80c77f4eb3aafdb00299
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-11-22 10:38:56 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-11-22 11:13:41 +0000

    cad/PrusaSlicer: Fix build with wxWidgets 3.2.4

    - Patches taken from OpenBSD port

    PR:             274367, 275082
    Approved by:    portmgr (build fix blanket)
    MFH:            2023Q4

 .../patch-src_slic3r_GUI_PhysicalPrinterDialog.cpp (new)      | 11 +++++++++++
 cad/PrusaSlicer/files/patch-src_slic3r_GUI_Plater.cpp         | 11 ++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-11-22 12:01:11 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d2fe51b145a2d8117b7a3b8baf0b2b76d01d27d

commit 8d2fe51b145a2d8117b7a3b8baf0b2b76d01d27d
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-11-22 10:38:56 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-11-22 11:15:15 +0000

    cad/PrusaSlicer: Fix build with wxWidgets 3.2.4

    - Patches taken from OpenBSD port

    PR:             274367, 275082
    Approved by:    portmgr (build fix blanket)
    MFH:            2023Q4

    (cherry picked from commit 818c20c1aa833f8f648f80c77f4eb3aafdb00299)

 .../patch-src_slic3r_GUI_PhysicalPrinterDialog.cpp (new)      | 11 +++++++++++
 cad/PrusaSlicer/files/patch-src_slic3r_GUI_Plater.cpp         | 11 ++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)