Bug 275095 - net/frr[89]: fix frr-reload finding frr-reload.py
Summary: net/frr[89]: fix frr-reload finding frr-reload.py
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-14 21:48 UTC by R. Christian McDonald
Modified: 2023-11-16 17:22 UTC (History)
2 users (show)

See Also:
linimon: maintainer-feedback? (olivier)

Attachments
net/frr[89]: fix frr-reload finding frr-reload.py (3.12 KB, patch)
2023-11-14 21:48 UTC, R. Christian McDonald 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description R. Christian McDonald 2023-11-14 21:48:08 UTC 
Created attachment 246319 [details]
net/frr[89]: fix frr-reload finding frr-reload.py
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2023-11-15 08:48:29 UTC 
Does frr-reload work on your side ?

# grep frr /etc/rc.conf
frr_vtysh_boot="YES"
frr_enable="yes"

# cat /usr/local/etc/frr/frr.conf
hostname router
!

# service frr start
Checking intergrated config...
Checking vtysh.conf
OK
Starting zebra.
2023/11/15 09:45:14 ZEBRA: [NNACN-54BDA][EC 4043309110] Disabling MPLS support (no kernel support)
Starting mgmtd.
Starting babeld.
(etc.)
[84569|staticd] done
Waiting for children to finish applying config...

# vtysh -c "show running-config"
Building configuration...

Current configuration:
!
hostname router
!
end

# frr-reload
Exiting: failed to connect to any daemons.
Traceback (most recent call last):
  File "/usr/local/sbin/frr-reload.py", line 2036, in <module>
    if not vtysh.is_config_available() or not reload_ok:
  File "/usr/local/sbin/frr-reload.py", line 94, in is_config_available
    output = self("configure")
  File "/usr/local/sbin/frr-reload.py", line 82, in __call__
    raise VtyshException(
__main__.VtyshException: vtysh returned status 1 for command "configure"
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-16 10:40:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84962599a83eff316bcc34cd0665d2ffeb8500b5

commit 84962599a83eff316bcc34cd0665d2ffeb8500b5
Author:     R. Christian McDonald <rcm@rcm.sh>
AuthorDate: 2023-11-14 21:43:11 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2023-11-16 10:39:30 +0000

    net/frr[89]: fix frr-reload finding frr-reload.py

    PR:             275095
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 net/frr8/Makefile | 9 ++++-----
 net/frr9/Makefile | 8 ++++----
 2 files changed, 8 insertions(+), 9 deletions(-)
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2023-11-16 10:41:33 UTC 
The problem was on my side (old libyang2 version).
Thanks for your patch.
Comment 4 R. Christian McDonald 2023-11-16 17:22:56 UTC 
(In reply to Olivier Cochard from comment #3)
Awesome, thanks for committing it :)