Bug 275150 - net-p2p/jackett: update to 0.21.1239 and set mono 6.8 as dependency
Summary: net-p2p/jackett: update to 0.21.1239 and set mono 6.8 as dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/Jackett/Jackett/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-17 10:51 UTC by Ralf van der Enden
Modified: 2023-11-24 07:11 UTC (History)
2 users (show)

See Also:
fuz: merge-quarterly+


Attachments
Update jackett to 0.21.1226 (27.44 KB, patch)
2023-11-17 10:51 UTC, Ralf van der Enden
tremere: maintainer-approval+
Details | Diff
Update jackett to 0.21.1234 and set dependency to lang/mono6.8 (3.25 KB, patch)
2023-11-19 22:16 UTC, Ralf van der Enden
tremere: maintainer-approval+
Details | Diff
Update jackett to 0.21.1239 and set dependency to lang/mono6.8 (5.82 KB, patch)
2023-11-21 09:47 UTC, Ralf van der Enden
tremere: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2023-11-17 10:51:45 UTC
Created attachment 246371 [details]
Update jackett to 0.21.1226

Q&A:
poudriere: testport ok (14.0-RELEASE;amd64)
Makefile portclippy/portmft processed

Feel free to squash the patch into one commit
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-11-18 20:24:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4e555294195ea735baa5d1a074af6d30ffebc25

commit b4e555294195ea735baa5d1a074af6d30ffebc25
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-10-31 11:35:27 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-18 20:20:41 +0000

    net-p2p/jackett: update to 0.21.1226

    Changelog: https://github.com/Jackett/Jackett/releases

    PR:             275150

 net-p2p/jackett/Makefile  |  2 +-
 net-p2p/jackett/distinfo  |  6 +++---
 net-p2p/jackett/pkg-plist | 14 ++++++++++++--
 3 files changed, 16 insertions(+), 6 deletions(-)
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-11-18 20:32:05 UTC
Thank you for your contribution.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-19 16:28:07 UTC
Can jackett work with mono6?
Right now in 2023Q4, sonarr needs mono6 but jacket requieres mono5 which conflicts with mono6
Comment 4 Ralf van der Enden 2023-11-19 22:16:42 UTC
Created attachment 246434 [details]
Update jackett to 0.21.1234 and set dependency to lang/mono6.8
Comment 5 Ralf van der Enden 2023-11-19 22:19:51 UTC
(In reply to Fernando Apesteguía from comment #3)
I completely missed the fact that I was using USES=mono and set my default mono to 6.8

I've added a patch for the new version which also set the dependency to mono6.8 and drops the USES=mono

Sorry for missing this.
Comment 6 Ralf van der Enden 2023-11-21 08:56:29 UTC
Reopened this one to address the mono6 issue
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-11-21 09:01:04 UTC
Could you rebase this patch so it applies on top of the current main branch?  The update to 0.21.1226 has already been committed, so your new patch cannot be applied as is.
Comment 8 Ralf van der Enden 2023-11-21 09:47:11 UTC
Created attachment 246459 [details]
Update jackett to 0.21.1239 and set dependency to lang/mono6.8
Comment 9 Ralf van der Enden 2023-11-21 09:51:13 UTC
(In reply to Robert Clausecker from comment #7)
I looked at the previous patches and it seems by checking the patch checkbox it loses the format-patch layout.

Therefore I uploaded the new patch (I updated to 0.21.1239 this morning) with it unchecked. Hopefully that helps.
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-11-21 18:52:26 UTC
Comment on attachment 246459 [details]
Update jackett to 0.21.1239 and set dependency to lang/mono6.8

(In reply to Ralf van der Enden from comment #9)

With the patch box unticked, the attachment has MIME type application/mbox and it cannot be viewed in the browser at all.  Note that you can always get the attachment as is by removing &action=diff from the URL.

I've re-added the patch flag so the attachment can be viewed as a diff.
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-22 08:51:40 UTC
Please, remember to merge to 2023Q4 too.
Comment 12 Ralf van der Enden 2023-11-22 15:38:40 UTC
(In reply to Fernando Apesteguía from comment #11)
Is that something I should do always or just with big changes ?
Comment 13 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-22 15:56:39 UTC
(In reply to Ralf van der Enden from comment #12)
Merging to a quarterly branch is for bug fixing and security issues.

In this case the quarterly branch is broken in the sense that sonarr in Q4 and jackett in Q4 are incompatible because the required mono versions are incompatibles with each other, so jackett should be merged.
Comment 14 Robert Clausecker freebsd_committer freebsd_triage 2023-11-22 18:13:45 UTC
Will take care of that on commit, thanks for the reminder.
Comment 15 commit-hook freebsd_committer freebsd_triage 2023-11-24 06:16:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2390530de4d1c58a5b15de03533c7fffbdb6ce34

commit 2390530de4d1c58a5b15de03533c7fffbdb6ce34
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-11-18 21:57:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-24 06:12:38 +0000

    net-p2p/jackett: update to 0.21.1239

     - depend on mono6.8 explicitly and drop USES=mono

    Changelog: https://github.com/Jackett/Jackett/releases

    PR:             275150
    Reported by:    fernape
    MFH:            2023Q4

 net-p2p/jackett/Makefile  | 4 ++--
 net-p2p/jackett/distinfo  | 6 +++---
 net-p2p/jackett/pkg-plist | 1 +
 3 files changed, 6 insertions(+), 5 deletions(-)
Comment 16 commit-hook freebsd_committer freebsd_triage 2023-11-24 06:18:36 UTC
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5293754c89b207f4306cca4372a5329275b73020

commit 5293754c89b207f4306cca4372a5329275b73020
Author:     Ralf van der Enden <tremere@cainites.net>
AuthorDate: 2023-11-18 21:57:52 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-24 06:17:18 +0000

    net-p2p/jackett: update to 0.21.1239

     - depend on mono6.8 explicitly and drop USES=mono

    Changelog: https://github.com/Jackett/Jackett/releases

    PR:             275150
    Reported by:    fernape
    MFH:            2023Q4

    (cherry picked from commit 2390530de4d1c58a5b15de03533c7fffbdb6ce34)

 net-p2p/jackett/Makefile  |  4 ++--
 net-p2p/jackett/distinfo  |  6 +++---
 net-p2p/jackett/pkg-plist | 32 +++++++++++++++++++++++---------
 3 files changed, 28 insertions(+), 14 deletions(-)
Comment 17 Robert Clausecker freebsd_committer freebsd_triage 2023-11-24 06:19:59 UTC
Thank you for your contribution.
Comment 18 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-24 07:11:10 UTC
(In reply to Robert Clausecker from comment #17)
Thank you!!!