Bug 275234 - net/cloudflared: Update startup order to after networking is available
Summary: net/cloudflared: Update startup order to after networking is available
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-21 14:46 UTC by freebsd
Modified: 2023-12-21 16:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (egypcio)


Attachments
Patch to update REQUIRE to "DAEMON NETWORKING" (387 bytes, patch)
2023-11-21 14:46 UTC, freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2023-11-21 14:46:49 UTC
Created attachment 246466 [details]
Patch to update REQUIRE to "DAEMON NETWORKING"

Currently net/cloudflared has a declared REQUIRE of "cleanvar SERVERS".

SERVERS is defined as "This is a dummy dependency, for early-start servers relying on some basic configuration."

However since net/cloudflared requires network connectivity in order to function properly in most use cases (primarily "tunnel run"), it fails to start in these cases.

Updating the REQUIRE statement to "DAEMON NETWORKING", ensures that network connections including dependent connection types such as ppp are initialized before startup.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-12-21 16:31:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5eedbbde710a0180447fcdc27f4907e95bcac11f

commit 5eedbbde710a0180447fcdc27f4907e95bcac11f
Author:     Vinícius Zavam <egypcio@FreeBSD.org>
AuthorDate: 2023-12-21 16:24:50 +0000
Commit:     Vinícius Zavam <egypcio@FreeBSD.org>
CommitDate: 2023-12-21 16:24:50 +0000

    net/cloudflared: Update startup order

    PR:             275234
    Reported by:    freebsd % void.stash.in.net

 net/cloudflared/Makefile             | 1 +
 net/cloudflared/files/cloudflared.in | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)