Created attachment 246467 [details] update mail/claws-mail and associate plugins to new versions (3.20.0 and 4.2.0) 20th November 2023 Claws Mail 4.2.0 / 3.20.0 CLAWS MAIL RELEASE NOTES http://www.claws-mail.org Claws Mail is a GTK+ based, user-friendly, lightweight, and fast email client. New in this release: ~~~~~~~~~~~~~~~~~~~~ * An easy way to open any folder on start-up has been added: Right-click a folder and choose 'Open on start-up'. This can also be configured on the 'Folder list' tab of the /Configuration/Preferences/Display/Summaries page. * Spam statistics have been added to the session statistics. * It is now possible to save message attachments only, without the other message parts. * QuickSearch: support for a "v H V" search expression has been added and the 'y S' expression has been removed ('v X-Label S' can be used instead). * font/* and chemical/* MIME types are now recognised. * The image viewer now works correctly when not auto-loading images. * Icon Themes: it is no longer possible to install or remove system themes. * IMAP: Support for SCRAM-SHA-{224,256,384,512} authentication mechanisms has been added. * IMAP: The statusbar now shows that expunge is happening. * The GData plugin has been removed. * The Fancy plugin no longer requires libsoup or libsoup-gnome. * The LiteHTML Viewer plugin has been synchronised with litehtml 0.7. * The LiteHTML viewer plugin will now only be built automatically if libgumbo 0.12 or newer is available. Building with libgumbo 0.10 must be explicitly requested using --enable-litehtml_viewer-plugin. * For extra debug output use --enable-more-addressbook-debug and --enable-more-ldap-debug. * Added translation: Portuguese * Updated translations: Brazilian Portuguese, Catalan, Czech, French, Polish, Russian, Slovak, Spanish, Swedish, Traditional Chinese, Turkish. * bug fixes: * bug 4491, 'address autocompletion list does not expand in height with the number of matches' * bug 4618, 'Rate limit by remote breaks queued/marked actions (Delete/Move)' * bug 4631, 'Embedding external editor crashes Claws-Mail on Wayland' * bug 4637, 'Segmentation fault when using SUMMARY is empty' * bug 4645, 'fails to check for perl-ExtUtils::Embed' * bug 4648, 'fails to build with gcc 13' * bug 4658, 'Headers unfolded incorrectly in message view' * bug 4664, 'OAUTH2 overwrites passwords even for plaintext logins' * bug 4666, 'fancy plugin doesn't build with libwebkit2gtk-4.1' * bug 4670, 'To/CC incorrectly escaped with a trailing backslash' * bug 4679, 'The correct date header is interpreted incorrectly to display strange date.' * bug 4693, 'Hang and crash when enable disable SVG Rendering prefs' * when starting with msgview hidden, toggling msgview to show it would use incorrect height * update quicksearch history list when changing type * wrong message which is shown when mail can't be sent * when redirecting, disable queueing * arbitrary paste restriction * when queueing or drafting a msg with an attachment which no longer exists, use the correct label on the button of the warning dialogue * using a custom header in found_in_addressbook match expressions * URIs may contain the '$' dollar sign * OAuth2, Update on-disk tokens as well when in-memory tokens are updated * Microsoft POP3 OAuth2 protocol
This patch does version update with some fixes: - integrates patch from PR 274190, as it does no harm here and potencially addresses the issue with LDAP option - re-adds Fancy plugin for GTK3 build, it was removed when this plugin could no longer been used with GTK2 build - marks GData and LiteHTML Viewer plugins as broken (expecting issues bloking the build to be resolved sometime soon) - makes plugins meta port handle broken plugins graciously, removing them from list of plugins to build Both GTK2 and GTK3 builds was tested locally, main port and all plugins, with some run time testing as well - neither build nor run time problems detected.
Full builds and run tests were done on both FreeBSD 13 and 14.
With updated devel/gumbo as offered in Bug 275327, mail/claws-mail-litehtml_viewer build and runs again, so when processed, it would be no longer broken and patches to plugin's Makefile could be omitted.
As PR 275327 is submitted, I am going to send new patch reflecting this.
Please switch to GTK3 as the default.
Now that bug #275327 has been addressed. I'll give your patch some serious testing and see if I can manage gtk(2|3) options as well. Thanks! --Chris
(In reply to Chris Hutchinson from comment #6) Anything special you like to test? I just did full build for both GTK2 and GTK3 versions, everything built in clear fresh FreeBSD 14-STABLE jails. I just need to create new patch matching current git repository...
(In reply to bsd from comment #7) I can concur. I had the same results. If you feel like updating the patch. I'll approve it. Thanks! --Chris
Created attachment 249082 [details] patch against mail/claws-mail and plugins OK. I made time to do this today. Tested against releng/13,14 and CURRENT. This is a slightly revised patch from the original submitted and it's against a ports tree pulled down this afternoon. This is ready for commit. Thanks! --Chris
Comment on attachment 246467 [details] update mail/claws-mail and associate plugins to new versions (3.20.0 and 4.2.0) Please use the one I submitted. Thanks for all your time and effort!
Created attachment 251221 [details] patch3 I've made some changes to the patch. Can you review them? - Use IGNORE instead of BROKEN in fancy and gdata plugins because this is broken by design, nothing we can fix. - Enable litehtml_viewer again. - Clean up dependencies. - Disable GDK deprecation warnings flooding the build log. - Enable i18n of the plugins. - Enable parallel build of plugins.
(In reply to Tijl Coosemans from comment #11) I like your proposals, Tijl. I'm testing your patch now. ... --Chris
Comment on attachment 251221 [details] patch3 I'm afraid I'm going to have to report that after testing, I found that this patch works as intended. Kindly commit it. Thank you Milan, and Tijl, for all your time and efforts on all this! My name is portmaster (Chris Hutchinson), and I approve this patch. (sorry, you'd probably have to live in the US, to understand the attempted humor in that last statement). ;) --Chris
Well. I put a + (maintainer approval) against your patch. But bugzilla won't/doesn't record it. :( Do we have anything that allows the MAINTAINER to record approval of submitted diff's/patches?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ec694eb958eec07bcac25a19d37a6d6c15a65871 commit ec694eb958eec07bcac25a19d37a6d6c15a65871 Author: Milan Obuch <bsd@dino.sk> AuthorDate: 2024-06-05 14:50:20 +0000 Commit: Tijl Coosemans <tijl@FreeBSD.org> CommitDate: 2024-06-05 14:51:52 +0000 mail/claws-mail: Update to 3.20.0/4.2.0 - Resurrect fancy plugin for the GTK 3 version of Claws Mail. - Clean up dependencies. - Disable GDK deprecation warnings flooding the build log. - Enable i18n of the plugins. - Enable parallel build of plugins. PR: 275236 Approved by: Chris Hutchinson <portmaster@bsdforge.com> (maintainer) mail/Makefile | 1 + mail/claws-mail-fancy/Makefile (new) | 20 ++++++++++++++++++ mail/claws-mail-fancy/pkg-descr (new) | 1 + mail/claws-mail-gdata/Makefile | 2 ++ mail/claws-mail-litehtml_viewer/Makefile | 8 ++++++-- mail/claws-mail-managesieve/Makefile | 2 ++ mail/claws-mail-notification/Makefile | 8 ++++---- mail/claws-mail-pdf_viewer/Makefile | 3 +-- mail/claws-mail-perl/Makefile | 4 ++-- mail/claws-mail-pgp/Makefile | 3 ++- mail/claws-mail-plugins/Makefile | 3 +++ mail/claws-mail-rssyl/Makefile | 3 ++- mail/claws-mail-vcalendar/Makefile | 10 ++++----- mail/claws-mail/Makefile | 35 ++++++-------------------------- mail/claws-mail/Makefile.claws | 31 ++++++++++++++++++---------- mail/claws-mail/Makefile.ver | 4 ++-- mail/claws-mail/distinfo | 11 +++++----- mail/claws-mail/pkg-plist | 2 +- 18 files changed, 86 insertions(+), 65 deletions(-)