Bug 275262 - www/nginx-full: fix package build
Summary: www/nginx-full: fix package build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on: 273930 275161
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-22 14:54 UTC by Koichiro Iwao
Modified: 2023-12-03 11:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
0001-www-nginx-fix-package-build.patch (1.06 KB, application/mbox)
2023-11-22 14:54 UTC, Koichiro Iwao 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2023-11-22 14:54:58 UTC 
Created attachment 246491 [details]
0001-www-nginx-fix-package-build.patch

nginx-full binary package is not built due to a lack of options selection.

The patch enables GSSAPI_MIT option when the port is built on the package build cluster. There's no reason I choose GSSAPI_MIT, GSSAPI_HEIMDAL would also be fine but either of them must be enabled during build.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2023-11-22 14:57:52 UTC 
Also, bug 273930, and bug 275161 need to be closed to build.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-03 09:04:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aa8f9390170e1e4f8470ccd7f03e54ab0ba77e61

commit aa8f9390170e1e4f8470ccd7f03e54ab0ba77e61
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2023-11-22 14:26:25 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-12-03 09:03:15 +0000

    www/nginx-full: fix package build

    nginx-full requires either to enable GSSAPI_MIT or GSSAPI_HEIMDAL but
    none is enabled. As a result, fails to build bibary package on package
    build cluster.

    PR:             275262
    Approved by:    maintainer timeout

 www/nginx-full/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2023-12-03 09:15:23 UTC 
(In reply to commit-hook from comment #2)


Please explain to me why you publish something here as "maintainer timeout" which is not correct.
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2023-12-03 09:39:02 UTC 
i am closing this page, even if this is a breach of policy. I will take over the PR as maintainer again
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-12-03 09:58:44 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e7405313ea7aa68b99aee7cde8bf33bb6fc713d1

commit e7405313ea7aa68b99aee7cde8bf33bb6fc713d1
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2023-11-22 14:26:25 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-12-03 09:03:57 +0000

    www/nginx-full: fix package build

    nginx-full requires either to enable GSSAPI_MIT or GSSAPI_HEIMDAL but
    none is enabled. As a result, fails to build bibary package on package
    build cluster.

    PR:             275262
    Approved by:    maintainer timeout

    (cherry picked from commit aa8f9390170e1e4f8470ccd7f03e54ab0ba77e61)

 www/nginx-full/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2023-12-03 11:35:38 UTC 
Ah, sorry. 

I misunderstood the date I submitted the patch. More than 2 weeks have passed since bug 293930 and 275161 are submitted. I just misremembered I submitted this Nov 18. But Nov 18 is the date when 275161 was submitted. I got it mixed up them.

It's totally my fault, feel free to revert.