Bug 275379 - games/jaggedalliance2: update to 0.21.0
Summary: games/jaggedalliance2: update to 0.21.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://ja2-stracciatella.github.io/2...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 17:09 UTC by Pavel Timofeev
Modified: 2024-01-14 20:40 UTC (History)
1 user (show)

See Also:

Attachments
port patch (96.04 KB, patch)
2023-11-27 17:09 UTC, Pavel Timofeev 		timp87: maintainer-approval+
Details | Diff
Patch for jaggedalliance2 v2 (96.34 KB, patch)
2024-01-14 07:37 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2023-11-27 17:09:33 UTC 
Created attachment 246605 [details]
port patch

- update port to 0.21.0
- rapidjson has been replaced with some rust implementation, so remove it from dependencies
- depend on magic_enum from the ports tree, not on the bundled one
- switch from c++17-lang to c++20-lang as stated by upstream
- remove workaround for fbsd 14 since it's not needed anymore
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 07:37:59 UTC 
Created attachment 247634 [details]
Patch for jaggedalliance2 v2

Slightly more cleaned up Makefile
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 07:39:17 UTC 
Hi,

Can you have a look at rev v2, passes Poudriere and is a bit more in line with Porters Handbook

* CMAKE_OFF and CMAKE_ARGS moved and sorted
bsd.port.*.mk removed

Best regards,
Daniel
Comment 3 Pavel Timofeev 2024-01-14 19:29:25 UTC 
(In reply to Daniel Engberg from comment #2)
Looks good!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-14 20:37:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7a3206d8a0b04dd447d6da6a73a4c20067b4afc

commit d7a3206d8a0b04dd447d6da6a73a4c20067b4afc
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2024-01-14 07:34:18 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-14 20:28:30 +0000

    games/jaggedalliance2: Update to 0.21.0

    Changelog:
    https://ja2-stracciatella.github.io/2023/11/06/release-0.21.0.html

    PR:             275379

 games/jaggedalliance2/Makefile                     | 131 +--
 games/jaggedalliance2/distinfo                     | 200 +++--
 .../files/patch-rust_stracciatella_Cargo.toml      |  20 +-
 .../patch-rust_stracciatella__c__api_Cargo.toml    |  10 +-
 games/jaggedalliance2/pkg-plist                    | 915 +++++++++++----------
 5 files changed, 692 insertions(+), 584 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 20:40:16 UTC 
Committed, thanks for your contribution!