Bug 275399 - irc/anope: fix build error with SASL option enabled
Summary: irc/anope: fix build error with SASL option enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 02:40 UTC by Siva Mahadevan
Modified: 2023-11-30 12:12 UTC (History)
3 users (show)

See Also:
devnull: maintainer-feedback+

Attachments
[PATCH] irc/anope: fix build error with SASL on (1.35 KB, application/mbox)
2023-11-28 02:40 UTC, Siva Mahadevan 		no flags Details
[PATCH] irc/anope: fix build error with SASL on (1.35 KB, patch)
2023-11-28 02:41 UTC, Siva Mahadevan 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Siva Mahadevan freebsd_triage 2023-11-28 02:40:34 UTC 
Created attachment 246625 [details]
[PATCH] irc/anope: fix build error with SASL on

anope 2.0.4 removed[0] the `m_sasl_dh-aes` and `m_sasl_dh-blowfish` extra modules. FreeBSD's port attempts to enable them by symbolically linking to non-existent files when the SASL option is enabled. The attached patch fixes the resulting build error.

[0] https://github.com/anope/anope/blob/2.0/docs/Changes.conf#L50
Comment 1 Siva Mahadevan freebsd_triage 2023-11-28 02:41:17 UTC 
Created attachment 246626 [details]
[PATCH] irc/anope: fix build error with SASL on

Fixed patch attachment
Comment 2 Rafael Grether 2023-11-28 15:40:48 UTC 
Comment on attachment 246626 [details]
[PATCH] irc/anope: fix build error with SASL on

Siva Mahadevan

Thanks for the patch!

Although it is not necessary to select the SASL option, since version 2.0.6 the SASL module is loaded by default.

I'll make this and some adjustments in the next commit.

Thanks!
Comment 3 Rafael Grether 2023-11-28 15:43:44 UTC 
MAINTAINER,

Can you commit the patch without flags set?
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2023-11-30 09:07:44 UTC 
Hi Rafael,

Are you ok to commit this patch as is without the adjustments ?

Regards,
-- Rodrigo
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2023-11-30 10:56:00 UTC 
Patch work as expected. Also did some Makefile format fixes to make linters happy.
PR is ready to land.
Comment 6 Rafael Grether 2023-11-30 11:27:03 UTC 
Hi Rodrigo,

Yes, the patch can be commited.

I will make some adjustments in the another PR to isolate the bug from an improvement.

The patch provided was tested on FreeBSD 13.2 and FreeBSD 14.0 in a poudriere jail.

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-11-30 12:11:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43293f045cc51f73af6262e1603f420425dd9644

commit 43293f045cc51f73af6262e1603f420425dd9644
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2023-11-30 10:56:39 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2023-11-30 12:11:25 +0000

    irc/anope: fix build error with SASL option enabled

    Also did some Makefile cleanup and reordering to make linters happy

    PR:             275399
    Reported by:    Siva Mahadevan <me@svmhdvn.name>
    Approved by:    Rafael Grether <devnull@apt322.org> (maintainer)

 irc/anope/Makefile                   | 25 +++++++++++--------------
 irc/anope/files/patch-CMakeLists.txt |  4 ++--
 irc/anope/pkg-plist                  |  2 --
 3 files changed, 13 insertions(+), 18 deletions(-)
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2023-11-30 12:12:44 UTC 
Committed, thanks.