Bug 275437 - x11-wm/bspwm: Enable CONTRIB option by default
Summary: x11-wm/bspwm: Enable CONTRIB option by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-29 19:41 UTC by Joel Bodenmann
Modified: 2023-11-30 13:19 UTC (History)
1 user (show)

See Also:
o.hushchenkov: maintainer-feedback+


Attachments
patch (1.23 KB, patch)
2023-11-29 19:41 UTC, Joel Bodenmann
jbo: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Bodenmann freebsd_committer freebsd_triage 2023-11-29 19:41:28 UTC
Created attachment 246674 [details]
patch

Upstream ships a .desktop file as part of /contrib. This is "hidden" behind the CONTRIB option of the port. This patch enables the CONTRIB option by default.

The .desktop file allows display managers following the freedesktop.org standards to discover bspwm automatically.

We already enabled the CONTRIB option by default for the x11-wm/bspwm-devel port.

See PR #274567
Comment 1 Oleh Hushchenkov 2023-11-29 20:50:45 UTC
Hi Joel,

I switched to swaywm a few years ago and no longer use X11 or bspwm.
I would be happy to pass this port to you, if you agree to maintain it.
In any case I'm fine with the patch.

Thanks.
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2023-11-30 13:11:24 UTC
Alright, I'll take over maintainership of the port.
Thank you very much for your work on the port! :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-11-30 13:18:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=32186242de61c74bbacd0ec4ba7bb0cbf664e1be

commit 32186242de61c74bbacd0ec4ba7bb0cbf664e1be
Author:     Joel Bodenmann <jbo@FreeBSD.org>
AuthorDate: 2023-11-30 13:14:35 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-11-30 13:14:35 +0000

    x11-wm/bspwm: Enable CONTRIB option by default

    The CONTRIB option ships a bunch of files which the average user might expect
    to just get by default (most notably a .desktop file). The .desktop file
    allows display managers following the freedesktop.org standards to discover
    bspwm automatically.

    PR:             275437
    Approved by:    zirias (mentor)

 x11-wm/bspwm/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-11-30 13:18:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=165d8d5acd5bc32566e148c1e4070c258fc56871

commit 165d8d5acd5bc32566e148c1e4070c258fc56871
Author:     Joel Bodenmann <jbo@FreeBSD.org>
AuthorDate: 2023-11-30 13:11:42 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-11-30 13:11:42 +0000

    x11-wm/bspwm: Take over maintainership

    PR:                     275437
    Approved by:            zirias (mentor)
    Differential Revision:  https://reviews.freebsd.org/D42844

 x11-wm/bspwm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)