Bug 275527 - cad/scotch: Add missing includes in scotch.h
Summary: cad/scotch: Add missing includes in scotch.h
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-04 18:16 UTC by Yuri Victorovich
Modified: 2023-12-04 23:07 UTC (History)
0 users

See Also:
thierry: maintainer-feedback+

Attachments
patch (932 bytes, patch)
2023-12-04 18:16 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-12-04 18:16:02 UTC 
Created attachment 246774 [details]
patch

include/scotch.h uses int64_t without including sys/types.h, and uses FILE without including stdio.h

The attached patch adds the workaround until the upstream would fix it.

This patch fixes the problem that math/freefem++ fails to detect scotch during configure: https://github.com/FreeFem/FreeFem-sources/issues/296


Thanks,
Yuri
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2023-12-04 20:42:05 UTC 
Approved, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-12-04 22:48:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77594feff67cf6792d805e079eb5567c21a125a7

commit 77594feff67cf6792d805e079eb5567c21a125a7
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-12-04 22:45:07 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-12-04 22:48:00 +0000

    cad/scotch: Add missing include statements in include/scotch.h

    Otherwise int64_t and FILE are not found.

    PR:             275527
    Approved by:    thierry@FreeBSD.org (maintainer)

 cad/scotch/Makefile                                  |  2 +-
 cad/scotch/files/patch-src_libscotch_library.h (new) | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-04 22:48:31 UTC 
Committed.

Thanks for the quick approval!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-12-04 23:07:25 UTC 
A commit in branch 2023Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31200877cb24704207a4ddf28a00dd8826e284e4

commit 31200877cb24704207a4ddf28a00dd8826e284e4
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-12-04 22:45:07 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-12-04 23:06:19 +0000

    cad/scotch: Add missing include statements in include/scotch.h

    Otherwise int64_t and FILE are not found.

    PR:             275527
    Approved by:    thierry@FreeBSD.org (maintainer)

    (cherry picked from commit 77594feff67cf6792d805e079eb5567c21a125a7)

 cad/scotch/Makefile                                  |  2 +-
 cad/scotch/files/patch-src_libscotch_library.h (new) | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)