Created attachment 246879 [details] Patch From Release: https://github.com/transmission/transmission/releases/tag/4.0.5 Transmission 4.0.5 This is a bugfix-only release. Everyone's feedback on 4.0.x has been very helpful -- thanks for all the suggestions, bug reports, and pull requests! What's New in 4.0.5 Highlights Fixed 4.0.0 bug where the IP address field in UDP announces were not encoded in network byte order. [BEP-15]. Fixed a bug that incorrectly escaped JSON strings in some locales. Fixed 4.0.4 decreased download speeds for people who set a low upload bandwidth limit. All Platforms Fixed bug that prevented editing trackers on magnet links. Fixed HTTP tracker announces and scrapes sometimes failing after adding a torrent file by HTTPS URL. In RPC responses, change the default sort order of torrents to match Transmission 3.00. Fixed tr_sys_path_copy() behavior on some Synology Devices. Qt Client Fix: only append .added suffix to watchdir files. GTK Client Fixed crash when opening torrent file from "Recently used" section in GTK 4.
Looks like it breaks the web UI. Nevermind probably needs some new dependency.
Created attachment 246881 [details] Patch to 4.0.5 Yep forgot a new file
Created attachment 246882 [details] Patch to 4.0.5
(In reply to Matt from comment #3) Thanks. Please write a commit message and upload a new patch created from git format-patch origin/main. For committer: The submitted patch builds cleanly for all flavors when built on FreeBSD 14 amd64 using poudriere.
Any reason to why we're not using upstreams release archive? https://github.com/transmission/transmission/releases/download/4.0.5/transmission-4.0.5.tar.xz Best regards, Daniel
(In reply to Daniel Engberg from comment #5) It was structured this way when I took over the port earlier this year. I didn't realize that pulling directly from Github was disfavored. In any event, Transmission bundles many third party dependencies in their release archives that we address separately through the Makefile. I imagine the original porter did it this way to avoid having to deal with that.
I have a ~90% complete patch, I'll try to fix the rest during this week.
Created attachment 246993 [details] patch-transmission_4.0.5 Please see a completed and tested patch attached. Your response did not make clear that the use of git was holding up this update. I wish it had as I would have posted this earlier. I had already revised the port to address your comment, but I didn't think this needed to go in this time around.
(In reply to Daniel Engberg from comment #5) I guess reason is that review D37929 not landed yet.
Hi, I'll have a look at this during the weekend Best regards, Daniel
Created attachment 247070 [details] patch-transmission_4.0.5_2 The patch I uploaded no longer compiles due to the update to utf8cpp. I see a bunch of stuff is going on over there. The *.cmake files were dropped from the port and the install location was changed. I have inelegantly worked around this in the attached by patching the location of utf8.h. Why is this necessary is beyond me as I thought the port compiled using a location of the relevant files that was within ${WRKSRC}. In fact, the port builds fine even if I don't provide ${WRKSRC} locations for utf8cpp, fmt, and fast_float—-so long as those directories exist (as they must be found by cmake). Daniel, I see you are involved in the update to utf8cpp. Please don't let me get in the way if you have a preferred way to address this (and perhaps the other dependencies mentioned above). Thank you
Created attachment 247080 [details] Patch for transmission Hi, This cleans up our hacking in transmission-components's Makefile, corrects a few dependencies and some other minor things. I didn't unbundle googletests as that needs more work and I don't have the motivation to do that right now. Builds on 14.0-CURRENT and 13.2-RELEASE using Poudriere. Best regards, Daniel
Comment on attachment 247080 [details] Patch for transmission Please commit at your convenience. Thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d6b1eec0f0d51e4ef3e420cd091505c9beb00e2a commit d6b1eec0f0d51e4ef3e420cd091505c9beb00e2a Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-12-17 08:21:54 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-12-17 19:04:30 +0000 net-p2p/transmission*: Update to 4.0.5 * Use upstream release archive * Unbundle more 3rd party code and reduce i/o during extraction Changelog: https://github.com/transmission/transmission/releases/tag/4.0.5 PR: 275613 Reviewed by: Rafe <mondo.debater_0q@icloud.com> (maintainer) net-p2p/transmission-components/Makefile | 38 ++++++++++++---------- net-p2p/transmission-components/distinfo | 14 ++------ .../files/patch-cmake_FindFastFloat.cmake (new) | 8 +++++ .../files/patch-cmake_FindFmt.cmake (new) | 11 +++++++ .../files/patch-cmake_FindUtfCpp.cmake (new) | 8 +++++ net-p2p/transmission-components/pkg-plist.daemon | 3 +- net-p2p/transmission-components/pkg-plist.docs | 1 + net-p2p/transmission/Makefile | 3 +- 8 files changed, 54 insertions(+), 32 deletions(-)
Committed with some minor text cleanups Thanks!