Bug 275645 - sysutils/cdrkit: remove sbrk usage
Summary: sysutils/cdrkit: remove sbrk usage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-09 00:13 UTC by Brooks Davis
Modified: 2025-02-18 21:19 UTC (History)
2 users (show)

See Also:
jharris: maintainer-feedback+

Attachments
Remove sbrk use in cdrkit and genisoimage (1.85 KB, patch)
2023-12-09 00:13 UTC, Brooks Davis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2023-12-09 00:13:57 UTC 
Created attachment 246919 [details]
Remove sbrk use in cdrkit and genisoimage

The code has fallbacks and when configured with configure presumably used them.  Just remove the HAVE_SBRK define from xconfig.h.in to do the right thing.

This is untested, but compiles on an amd64 world without sbrk.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-12-09 12:16:56 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 2 jharris 2023-12-13 21:06:45 UTC 
Please test thoroughly as my 1 FreeBSD box with a CD is currently not booting...

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-02-18 21:02:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=71866091735cd13883e453ee3576b48fbbd1fbd8

commit 71866091735cd13883e453ee3576b48fbbd1fbd8
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-12-08 21:26:50 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-02-18 21:00:22 +0000

    sysutils/{cdrkit,genisoimage}: remove sbrk use

    The code has fallbacks for a lack of sbrk.  Just remove the HAVE_SBRK
    define from xconfig.h.in to avoid using it needlessly.  I've verified
    basic genisoimage functionality.

    PR:             275645
    Approved by     jharris@widomaker.com (maintainer)

 sysutils/cdrkit/Makefile                               |  2 +-
 sysutils/cdrkit/files/patch-include_xconfig.h.in (new) | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)