Created attachment 248237 [details]
net-mgmt/netdata: Update to v1.44.2

Created attachment 248402 [details]
net-mgmt/netdata: Update to v1.44.3

Working on the CMake switch right now

Comment 4 Daniel Engberg 2024-03-29 13:59:44 UTC

Sounds great, thanks!

Latest patches:

https://dl.nkeor.me/freebsd/0001-net-mgmt-netdata-Update-to-v1.45.2.patch
https://dl.nkeor.me/freebsd/0002-net-mgmt-netdata-Fix-arc-stats-with-recent-OpenZFS.patch
https://dl.nkeor.me/freebsd/0003-net-mgmt-netdata-Depend-on-go-when-building-with-GOP.patch
https://dl.nkeor.me/freebsd/0004-net-mgmt-netdata-Add-PROMETHEUS-option.patch

Last decision is whether to keep go.d.plugin in netdata-go or build it in (upstream does this since 1.45.0) and conflict netdata >1.45.0 with netdata-go

Any update on this?

(In reply to Mohamed Akram from comment #6)

We are still working on final details, see also https://github.com/netdata/netdata/issues/17632

Per that issue looks like it's using c-rbuf and c_rhash through mqtt_websockets. I imagine passing -DENABLE_MQTTWEBSOCKETS=ON fixes it - https://github.com/netdata/netdata/blob/v1.45.4/CMakeLists.txt#L1625 (that's what happens when H2O or ACLK are enabled). Or maybe the rbuf/rhash files can be moved from `MQTT_WEBSOCKETS_FILES` to `ACLK_ALWAYS_BUILD` as a patch in CMakeLists.txt since that's why they're needed if enabling MQTT websockets is not an option.

Waiting on https://github.com/netdata/netdata/pull/17673 now (and potentially a v1.45.5 release)

Created attachment 250991 [details]
net-mgmt/netdata: Update to v1.45.5

I have successful build of 1.45.5 on freebsd stable/14 with small patches of provided diff. 

now I have both go.d and god.d plugins running :( 

Anyway netdata works somehow.

In my situation
14888  -  IN        0:12,70 /usr/local/sbin/netdata -P /var/db/netdata/netdata.pid
14890  -  IN        0:00,03 /usr/local/sbin/netdata --special-spawn-server
14936  -  IN        0:03,47 /usr/local/libexec/netdata/plugins.d/go.d.plugin 1
14938  -  SN        0:00,94 /usr/local/libexec/netdata/plugins.d/apps.plugin 1
14939  -  SN        0:01,35 /usr/local/bin/python3.11 /usr/local/libexec/netdata/plugins.d/pyt
14942  -  IN        0:01,38 /usr/local/libexec/netdata/plugins.d/god.plugin 1


# pkg which /usr/local/libexec/netdata/plugins.d/god.plugin
/usr/local/libexec/netdata/plugins.d/god.plugin was installed by package netdata-go-0.58.1_4

# pkg which /usr/local/libexec/netdata/plugins.d/go.d.plugin
/usr/local/libexec/netdata/plugins.d/go.d.plugin was installed by package netdata-1.45.5


maybe it's time to deinstall netdata-go-0.58.1_4?

new defect of the port:

# /usr/local/libexec/netdata/plugins.d/alarm-notify.sh test

# SENDING TEST WARNING ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK

# SENDING TEST CRITICAL ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK

# SENDING TEST CLEAR ALARM TO ROLE: sysadmin
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
/usr/local/libexec/netdata/plugins.d/alarm-notify.sh: line 144: systemd-cat-native: command not found
# OK

Created attachment 251553 [details]
net-mgmt/netdata: Update to v1.45.6

Added back systemd-cat-native as it seems to be required by some modules.
Updated to v1.45.6, runtime looks OK

Created attachment 251609 [details]
net-mgmt/netdata: Update to v1.46.1

Anything blocking this?

Created attachment 252085 [details]
net-mgmt/netdata: Update to v1.46.2

Waiting on a review from Daniel, but he is currently busy.

(In reply to Namkhai B. from comment #17)
Hi,
I will be really grateful to your work. Can you suggest to me fastest way to test your proposed change inside my ports tree? 
Currently I'm running metadata 1.46.1 which was your previous patch, but with new version after git restore net-mgmt/netdata I can't apply with patch -p1 < {your-patch} correctly.

Created attachment 252110 [details]
net-mgmt/netdata: Update to v1.46.2

Rebased patch over the latest ports tree

(In reply to Namkhai B. from comment #20)
I confirm that provided patch was applied fine on main /usr/ports tree.

(In reply to Namkhai B. from comment #20)
I confirm that provided patch was applied fine on main /usr/ports tree.

Created attachment 252282 [details]
net-mgmt/netdata: Update to v1.46.3

(In reply to Namkhai B. from comment #23)
I confirm that provided patch was applied fine on main /usr/ports tree.

(In reply to Namkhai B. from comment #23)
I confirm that provided patch was applied fine on main /usr/ports tree.

anything developed for 1.47.0?

Created attachment 253063 [details]
net-mgmt/netdata: Update to v1.47.0

Preliminary v1.47.0 patch, runtime looks OK so far

Created attachment 253314 [details]
net-mgmt/netdata: Update to v1.47.0

Added setuid bit needed by freeipmi.plugin

1.47.2 is now available.

Created attachment 253965 [details]
net-mgmt/netdata: Update to v1.47.3

is it really needs lang/go122 or it can work also with lang/go123?

I have DEFAULT_VERSIONS+=go=1.23 in /etc/make.conf already.

(In reply to Jordan Ostreff from comment #31)

I'll test with 1.23, but go.d.plugin needs at least v1.22 and lang/go is at 1.21. So I have to make a choice to either depend on 1.22 or 1.23

I have played with Makefile just to not strictly require 1.22.x go version, but the result I have is not promising, but I'm not good in general with makefiles. My result is:
-- Determining minimum required version of Go for this build
-- Minimum required Go version determined to be 1.22.0
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Go (missing: GO_EXECUTABLE GO_ROOT) (Required is at least
  version "1.22.0")
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  packaging/cmake/Modules/FindGo.cmake:64 (find_package_handle_standard_args)
  CMakeLists.txt:212 (find_package)


-- Configuring incomplete, errors occurred!

Meanwhile I have following result:
# go version
go version go1.23.1 freebsd/amd64

Same result also from 
# go version
go version go1.23.2 freebsd/amd64


===>  Cleaning for netdata-1.47.3
===>  License GPLv3 accepted by the user
===>   netdata-1.47.3 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by netdata-1.47.3 for building
===>  Extracting for netdata-1.47.3
=> SHA256 Checksum OK for netdata-v1.47.3.tar.gz.
===>  Patching for netdata-1.47.3
===>  Applying FreeBSD patches for netdata-1.47.3 from /usr/ports/net-mgmt/netdata/files
====>   IGNORING patchfile patch-CMakeLists.txt.orig
====>   IGNORING patchfile patch-Makefile.am.orig
====>   IGNORING patchfile patch-collectors_python.d.plugin_Makefile.am.orig
====>   IGNORING patchfile patch-collectors_python.d.plugin_python.d.plugin.in.orig
====>   IGNORING patchfile patch-collectors_python.d.plugin_python__modules_bases_loaders.py.orig
====>   IGNORING patchfile patch-configure.ac.orig
====>   IGNORING patchfile patch-daemon_analytics.c.orig
====>   IGNORING patchfile patch-daemon_main.c.orig
====>   IGNORING patchfile patch-packaging_cmake_Modules_FindGo.cmake.orig
====>   IGNORING patchfile patch-packaging_cmake_Modules_NetdataVersion.cmake.orig
====>   IGNORING patchfile patch-src_collectors_freebsd.plugin_freebsd_kstat_zfs.c.orig
====>   IGNORING patchfile patch-src_collectors_proc.plugin_zfs_common.c.orig
====>   IGNORING patchfile patch-src_collectors_proc.plugin_zfs_common.h.orig
====>   IGNORING patchfile patch-src_collectors_python.d.plugin_python.d.plugin.in.orig
====>   IGNORING patchfile patch-src_ml_ml-private.h.orig
====>   IGNORING patchfile patch-src_ml_ml.cc.orig
===>   netdata-1.47.3 depends on file: /usr/local/bin/mmv - found
===>   netdata-1.47.3 depends on package: go>=1.22 - found
===>   netdata-1.47.3 depends on file: /usr/local/include/dlib/matrix.h - found
===>   netdata-1.47.3 depends on file: /usr/local/bin/cmake - found
===>   netdata-1.47.3 depends on executable: ninja - found
===>   netdata-1.47.3 depends on package: pkgconf>=1.3.0_1 - found
===>   netdata-1.47.3 depends on file: /usr/local/bin/python3.11 - found
===>   netdata-1.47.3 depends on shared library: libbrotlicommon.so - found (/usr/local/lib/libbrotlicommon.so)
===>   netdata-1.47.3 depends on shared library: libjson-c.so - found (/usr/local/lib/libjson-c.so)
===>   netdata-1.47.3 depends on shared library: libpcre2-8.so - found (/usr/local/lib/libpcre2-8.so)
===>   netdata-1.47.3 depends on shared library: libuuid.so - found (/usr/local/lib/libuuid.so)
===>   netdata-1.47.3 depends on shared library: libuv.so - found (/usr/local/lib/libuv.so)
===>   netdata-1.47.3 depends on shared library: libyaml.so - found (/usr/local/lib/libyaml.so)
===>   netdata-1.47.3 depends on shared library: libzstd.so - found (/usr/local/lib/libzstd.so)
===>   netdata-1.47.3 depends on shared library: libabsl_base.so - found (/usr/local/lib/libabsl_base.so)
===>   netdata-1.47.3 depends on shared library: libprotobuf.so - found (/usr/local/lib/libprotobuf.so)
===>   netdata-1.47.3 depends on shared library: libcups.so - found (/usr/local/lib/libcups.so)
===>   netdata-1.47.3 depends on shared library: liblz4.so - found (/usr/local/lib/liblz4.so)
===>   netdata-1.47.3 depends on shared library: libfreeipmi.so - found (/usr/local/lib/libfreeipmi.so)
===>   netdata-1.47.3 depends on shared library: libsnappy.so - found (/usr/local/lib/libsnappy.so)
===>   netdata-1.47.3 depends on shared library: libabsl_base.so - found (/usr/local/lib/libabsl_base.so)
===>   netdata-1.47.3 depends on shared library: libprotobuf.so - found (/usr/local/lib/libprotobuf.so)
===>  Configuring for netdata-1.47.3
===>  Performing out-of-source build
/bin/mkdir -p /usr/ports/net-mgmt/netdata/work/.build
-- The C compiler identification is Clang 18.1.6
-- The CXX compiler identification is Clang 18.1.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/local/bin/pkgconf (found version "2.3.0")
-- Performing Test HAVE_C__ffunction_sections
-- Performing Test HAVE_C__ffunction_sections - Success
-- Performing Test HAVE_CXX__ffunction_sections
-- Performing Test HAVE_CXX__ffunction_sections - Success
-- Performing Test HAVE_C__fdata_sections
-- Performing Test HAVE_C__fdata_sections - Success
-- Performing Test HAVE_CXX__fdata_sections
-- Performing Test HAVE_CXX__fdata_sections - Success
-- Performing Test HAVE_C__Wno_builtin_macro_redefined
-- Performing Test HAVE_C__Wno_builtin_macro_redefined - Success
-- Performing Test HAVE_CXX__Wno_builtin_macro_redefined
-- Performing Test HAVE_CXX__Wno_builtin_macro_redefined - Success
-- Performing Test HAVE_C__fexceptions
-- Performing Test HAVE_C__fexceptions - Success
-- Performing Test HAVE_CXX__fexceptions
-- Performing Test HAVE_CXX__fexceptions - Success
-- Searching for MOLD linker
-- Searching for MOLD linker - failed
--  Compiling for FreeBSD... 
-- Determining minimum required version of Go for this build
-- Minimum required Go version determined to be 1.22.0
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find Go (missing: GO_EXECUTABLE GO_ROOT) (Required is at least
  version "1.22.0")
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  packaging/cmake/Modules/FindGo.cmake:64 (find_package_handle_standard_args)
  CMakeLists.txt:212 (find_package)


-- Configuring incomplete, errors occurred!
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/net-mgmt/netdata
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netdata

I have found that inside files/patch-packaging_cmake_Modules_FindGo.cmake the go version is hardcoded to be go122. I removed this patch on my ports tree.

Also inside Makefile this line must look like main I believe:
GOPLUGIN_BUILD_DEPENDS= go>=1.22:lang/go123

I think the safe choice will be to wait for bug #281773 and depend on lang/go.
I'll post a patch with USES=go, it won't build unless DEFAULT_VERSIONS includes go=1.22 or higher in /etc/make.conf

Created attachment 254164 [details]
net-mgmt/netdata: Update to v1.47.4

This patch USES=go, and as go.d.plugin needs go>1.21, it won't build with port's default go version.

(In reply to Namkhai B. from comment #37)
It doesn't work for me with my system which has go default to be go123. 


So in Makefile I have:
#GOPLUGIN_USES=         go>=go122,no_targets
GOPLUGIN_BUILD_DEPENDS= go>=1.22:lang/go122

in files/patch-packaging_cmake_Modules_FindGo.cmake I have:
@@ -29,9 +29,9 @@
     find_program(GO_EXECUTABLE go PATHS /c/go/bin "/c/Program Files/go/bin" /mingw64/lib/go/bin /ucrt64/lib/go/bin /clang64/lib/go/bin DOC "Go toolchain" NO_DEFAULT_PATH)
   endif()
 else()
-  find_program(GO_EXECUTABLE go PATHS /usr/local/go/bin DOC "Go toolchain" NO_DEFAULT_PATH)
+  find_program(GO_EXECUTABLE go PATHS /usr/local/go/bin DOC "Go toolchain" NO_DEFAULT_PATH)
 endif()
-find_program(GO_EXECUTABLE go DOC "Go toolchain")
+find_program(GO_EXECUTABLE go DOC "Go toolchain")
 
 if (GO_EXECUTABLE)
   execute_process(

and it works fine for me if I have only go123 or if I have both go122 and go123.

Created attachment 254484 [details]
net-mgmt/netdata: Update to v1.47.5

Now depending on go 1.23 until it's the port's default.
v1.47.5 will also fix bug #278066.

(In reply to Namkhai B. from comment #39)
From my point of view the port works as expected on all my machines. Including the places where go123 is missing.

Thanks!

Comment 41 Daniel Engberg 2024-10-26 20:16:36 UTC

GOPLUGIN option fails in poudriere because it tried to download during build,
https://pdr2.bofh.network/data/133-diizzy/2024-10-26_15h00m54s/logs/errors/netdata-1.47.5.log

Thanks for all your work and effort put into this port!

I'm looking into the go build issue and also netdata v2.0, unfortunately I'm away from home until the 18th so progress will be slow until then.

(In reply to Namkhai B. from comment #42)
netdata 2.0 released. So we are expecting port for freebsd too :)

Is there some ongoing development for netadata 2.0 port?

(In reply to Jordan Ostreff from comment #44)

Yes, unfortunately I've encountered some issues.

I still have to figure out how to make go.d not download deps when building, and netdata v2 bundles the dashboard at build time (cmake downloads a proprietary agent.gz file).

This file is not versioned, so every build could have a different agent with different files.

Created attachment 255719 [details]
net-mgmt/netdata: Update to v2.0.3

Initial v2.0.3 patch.

I believe the go build issue is fixed, but I would like some feedback on how to handle the new dashboard.
With DASHBOARD=on, netdata will download the proprietary v3 agent dashboard from http://app.netdata.cloud/agent.tar.gz and install it (at build time). This presents three problems:

1. the proprietary dashboard is licensed under the NCUL1 license and not GPLv3: https://app.netdata.cloud/LICENSE.txt
2. this file is not versioned, so pkg-plist can become outdated at any time
3. cmake will download this file at build time (fixable by patching the cmake build process and manually downloading the dashboard as a distfile)

Created attachment 255720 [details]
net-mgmt/netdata: Update to v2.0.3

uploaded the latest patch

(In reply to Namkhai B. from comment #47)
For me on my system provided patch works perfectly.

New 2.1 is out. With improvements in streaming.

(In reply to Jordan Ostreff from comment #49)

Seen. I'm traveling until the 23rd, so that'll be the earliest timeline for a new patch.

Created attachment 256272 [details]
net-mgmt/netdata: Update to v2.1.0

Update to v2.1.0.
Tested on 14.2-RELEASE, runtime looks OK

(In reply to Namkhai B. from comment #51)
Thanks, it works perfect also for me on 14-STABLE.


Merry Christmas and Happy New 2025 Year!

(In reply to Jordan Ostreff from comment #52)
I've found following problem - if building system has access to internet only via proxy, cmake doesn't respect http_proxy/https_proxy environment variables, and generates following error:

-- Checking for module 'libmongoc-1.0>=1.7'
--   Found libmongoc-1.0, version 1.25.4
-- Checking for module 'snappy'
--   Found snappy, version 1.2.1
-- Checking for module 'libpcre2-8'
--   Found libpcre2-8, version 10.43
-- Preparing local agent dashboard code
--   Fetching https://app.netdata.cloud/agent.tar.gz
CMake Error at packaging/cmake/Modules/NetdataDashboard.cmake:46 (message):
  Failed to fetch dashboard code
Call Stack (most recent call first):
  CMakeLists.txt:3368 (bundle_dashboard)


-- Configuring incomplete, errors occurred!
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/net-mgmt/netdata
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netdata


Also it looks that check for go123 doesn't work well too.

have opened https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283745 regarding http_proxy && cmake .

I'm working on fetching the agent via a extra DISTFILE and either patching cmake or manually extracting the dashboard in the port Makefile.

The other issue is that the dashboard is fetched from http://app.netdata.cloud/agent.tar.gz. This *will* break the port every time netdata updates their agent.

The only workaround I see at the moment is hosting the agent code at a different MASTER_SITE.
I'd be willing to host it at dl.nkeor.me/freebsd/netdata if that's a possibility the port committers agree with.
Otherwise, I'm open to suggestions.

Another possibility is either dropping OPTION=DASHBOARD or marking it as broken.

Created attachment 256350 [details]
net-mgmt/netdata: Update to v2.1.0

Initial patch fetching and building the dashboard with the port system.
As stated previously, it's fetched from dl.nkeor.me/freebsd/netdata, subject to change if there's a better option.

Also ran portlint and portclippy, so it looks a bit bigger than previous patches.

(In reply to Namkhai B. from comment #56)
it build fine on machine which doesn't have internet connectivity without proxy.

Created attachment 256591 [details]
net-mgmt/netdata: Update to v2.1.1

Created attachment 256923 [details]
net-mgmt/netdata: Update to v2.2.0

(In reply to Namkhai B. from comment #59)

Poudriere build failed with:

=======================<phase: fetch          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
=> netdata-v2.2.0.tar.gz doesn't seem to exist in /portdistfiles/netdata.
=> Attempting to fetch https://github.com/netdata/netdata/releases/download/v2.2.0/netdata-v2.2.0.tar.gz
netdata-v2.2.0.tar.gz                                   48 MB   18 MBps    03s
=> go.mod doesn't seem to exist in /portdistfiles/netdata.
=> Attempting to fetch https://raw.githubusercontent.com/netdata/netdata/refs/tags/v2.2.0/src/go/go.mod
go.mod                                                7534  B   32 MBps    00s
===> Fetching all distfiles required by netdata-2.2.0 for building
env: /usr/local/bin/go123: No such file or directory
*** Error code 127

Stop.
make: stopped in /usr/ports/net-mgmt/netdata
build of net-mgmt/netdata | netdata-2.2.0 ended at 2025-01-24T00:18:25+01:00


It did build go123 just before this port:
build of lang/go123 | go123-1.23.5 ended at 2025-01-24T00:18:20+01:00

Seems to also be missing a build dependency: curl>0:ftp/curl


=======================<phase: configure      >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Configuring for netdata-2.2.0
===>  Performing out-of-source build
/bin/mkdir -p /wrkdirs/usr/ports/net-mgmt/netdata/work/.build
-- The C compiler identification is Clang 18.1.6
-- The CXX compiler identification is Clang 18.1.6
-----8<-------SNIP------->8-------

-- Checking for module 'libcurl>=7.21'
--   Package 'libcurl' not found
CMake Error at /usr/local/share/cmake/Modules/FindPkgConfig.cmake:645 (message):
  The following required packages were not found:

   - libcurl>=7.21

Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal)
  CMakeLists.txt:321 (pkg_check_modules)


-- Configuring incomplete, errors occurred!
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netdata
=>> Cleaning up wrkdir
===>  Cleaning for netdata-2.2.0
build of net-mgmt/netdata | netdata-2.2.0 ended at 2025-01-24T00:40:02+01:00

Also, seems horribly angry about me not building the go plugin?

=======================<phase: package        >============================
===== env: 'PKG_NOTES=build_timestamp ports_top_git_hash ports_top_checkout_unclean port_git_hash port_checkout_unclean built_by' 'PKG_NOTE_build_timestamp=2025-01-23T23:47:24+00:00' 'PKG_NOTE_ports_top_git_hash=66808f308f5' 'PKG_NOTE_ports_top_checkout_unclean=yes' 'PKG_NOTE_port_git_hash=94829e74ad8' 'PKG_NOTE_port_checkout_unclean=yes' 'PKG_NOTE_built_by=poudriere-git-3.4.99.20250115' PKG_NO_VERSION_FOR_DEPS=1 NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Building packages for netdata-2.2.0
===>   Building netdata-2.2.0
pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/netdata/work/stage/usr/local/libexec/netdata/plugins.d/ndsudo:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-mgmt/netdata/work/stage/usr/local/etc/netdata/go.d/:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/net-mgmt/netdata
=>> Cleaning up wrkdir
===>  Cleaning for netdata-2.2.0
build of net-mgmt/netdata | netdata-2.2.0 ended at 2025-01-24T00:48:30+01:00

Created attachment 256948 [details]
net-mgmt/netdata: Update to v2.2.0

* Added %%GOPLUGIN%% prefix to libexec/netdata/plugins.d/ndsudo and %%ETCDIR%%/go.d
* moved curl dependency from RUN_DEPENDS to LIB_DEPENDS

Not sure what's going on with go and poudriere, the makefile depends on go with GOPLUGIN_USES=go:1.23
We could rewrite it to just USES=go:1.23 but then go would be a dependency whether go.d is enabled or not.

(In reply to Namkhai B. from comment #63)

with the following in the Makefile:

GOPLUGIN_FETCH_DEPENDS= go123:lang/go123

as an additional line around the GOPLUGIN lines, poudriere does indeed build and install go123 for fetching the related go-files if GOPLUGIN is enabled..

if only go123 could stop being rebuilt due to the following:
[00:00:15] [02] [00:00:00] Warning: go123-1.23.5 will be rebuilt as it misses libc.so.6:32

*every* time I build a package, I would be pretty happy..

Created attachment 257107 [details]
net-mgmt/netdata: Update to v2.2.1

Updated patch to v2.2.1 & agent to 20250129

Comment 66 Daniel Engberg 2025-02-01 19:41:11 UTC

(In reply to Namkhai B. from comment #63)
Go is only a build dependency and while not optimal its better than nothing?

(In reply to Daniel Engberg from comment #66)

That's a solved issue with GOPLUGIN_FETCH_DEPENDS= go123:lang/go123 (already in the latest patch)

Comment 68 Daniel Engberg 2025-02-02 17:55:42 UTC

Looks good and tests fine in Poudriere on my end, bump it to 2.2.3 before committing?

Fedora seems to do some stuff with the web frontend which might be of interest?

https://src.fedoraproject.org/rpms/netdata/blob/rawhide/f/netdata.spec#_228
https://src.fedoraproject.org/rpms/netdata/blob/rawhide/f/netdata.spec#_357

Great work!

(In reply to Daniel Engberg from comment #68)

Updating the patch to 2.2.3 at the moment.

What I understand from fedora's build is they [1] completely disable the proprietary v3 dashboard; and instead link v1 as the default [2]

Right now the port bundles the v3 dashboard only when DASHBOARD is enabled (default)

I'll add the necessary steps to use dashboard v1 when DASHBOARD=off 
I could also disable DASHBOARD by default

[1]: https://src.fedoraproject.org/rpms/netdata/blob/rawhide/f/netdata-remove-web-v2.patch
[2]: https://src.fedoraproject.org/rpms/netdata/blob/rawhide/f/netdata.spec#_357

Comment 70 Daniel Engberg 2025-02-02 18:56:58 UTC

Sounds great, thanks! :-)

Created attachment 257188 [details]
net-mgmt/netdata: Update to v2.2.3


Renamed DASHBOARD to CLOUD_DASHBOARD.
Now using the v1 dashboard when CLOUD_DASHBOARD is off (fedora's approach).

I'm open to suggestions on the naming scheme.

Comment 72 Daniel Engberg 2025-02-02 20:28:11 UTC

Fixed a typo, awesome work and thanks for all contributors too!

Comment 73 commit-hook 2025-02-02 20:28:15 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07cc225b4106ac0eb09b92ff4e9ebf6d16643817

commit 07cc225b4106ac0eb09b92ff4e9ebf6d16643817
Author:     Namkhai Bourquin <nk@nkeor.me>
AuthorDate: 2025-02-02 20:21:55 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2025-02-02 20:27:22 +0000

    net-mgmt/netdata: Update to 2.2.3

    Changelog: https://github.com/netdata/netdata/releases/tag/v2.2.3

    Thanks to Namkhai and contributors for the time consuming effort to
    make it suitable for packaging and testing

    PR:             275792

 net-mgmt/netdata/Makefile                          | 163 ++--
 net-mgmt/netdata/distinfo                          |  10 +-
 net-mgmt/netdata/files/netdata.conf.sample.in      |   1 +
 net-mgmt/netdata/files/patch-CMakeLists.txt (new)  | 105 +++
 net-mgmt/netdata/files/patch-Makefile.am (gone)    |  29 -
 ...h-collectors_python.d.plugin_Makefile.am (gone) | 111 ---
 ...ctors_python.d.plugin_python.d.plugin.in (gone) |  10 -
 ....plugin_python__modules_bases_loaders.py (gone) |  14 -
 net-mgmt/netdata/files/patch-configure.ac (gone)   |  81 --
 .../netdata/files/patch-daemon_analytics.c (gone)  |  15 -
 net-mgmt/netdata/files/patch-daemon_main.c (gone)  |  12 -
 ...kaging_cmake_Modules_NetdataGoTools.cmake (new) |  11 +
 ...kaging_cmake_Modules_NetdataVersion.cmake (new) |  40 +
 ...ectors_python.d.plugin_python.d.plugin.in (new) |  10 +
 .../patch-src_ml_ml__calculated__number.h (new)    |  11 +
 .../netdata/files/patch-src_ml_ml__kmeans.cc (new) |  11 +
 net-mgmt/netdata/pkg-plist                         | 886 +++++++++++----------
 17 files changed, 772 insertions(+), 748 deletions(-)