Created attachment 247537 [details] OPTION'ify rendering engines textproc/py-sphinxcontrib-svg2pdfconverter: OPTION'ify runtime renderers Some Port housekeeping, move the three different runtime renderers to OPTIONs: a lighter weight Cairo based renderer, the default Inkscape (was not originally listed as a dependency) renderer, and the current Rust implementation of libsvg2.
I tried install inkscape, will require 512 Mib more space. If a user (without inkscape) use py-sphinxcontrib-svg2pdfconverter and upgrade the packages should install hundreds of megabytes. I suggest remove the inkscape option from default options.
(In reply to Zsolt Udvari from comment #1) Good idea. What are your thoughts on removing the Rust SVG renderer from the default too? I only use the Python Cairo renderer on my workstation.
(In reply to Alastair Hogge from comment #2) I don't use this software but checking the dependencies: the librsvg port is dependency of gtk30 which is a widely used port so I think the librsvg port is probably installed already (check pkg info --required-by librsvg2\*) and maybe can a simple dependency (without option). Python-cairo-svg: on my desktop doesn't require many plus space, can be default. Another idea: forget the options, only the librsvg will be dependency. And create a pkg-message which informs user about liferea and py-cairosvg: can install and use them as renderer.
I am not a position at the moment to investigate this. From memory, I was favouring the Cairo renderer because of the reduced amount of dependencies, and space as you mention. I agree with making that the default, as I prefer not to assume on GTK be common, or anything else in general really, it is a terrible habit. My reason for the adding all the options was because it enables an automatic concrete dependency, which alleviates the user from managing the dependencies, thus it keeps package and dependency management as a task for pkg, not the user. If you are OK with that, I will upload a new patch when I am able. Thanks for your interest in the problem report.
I think should drop inkscape from options and dependencies and inform user in pkg-message: if he/she wants use inkscape as renderer should install it manually.
(In reply to Zsolt Udvari from comment #5) I still do not understand your reasoning for this. Surely inkscape could be left as an option, defaulted to off, than the mechanisms of the Ports Framework are still there, enabling the user to make the choice, not you or I.
(In reply to Alastair Hogge from comment #6) "defaulted to off" Okay, I think it's good. I forgot it :)
Could you please provide an updated patch?
And the 1.2.3 is out :)
(In reply to Zsolt Udvari from comment #8) Will do when replacement HBA, SFF cables, and some disks arrive from overseas.
Comment on attachment 247537 [details] OPTION'ify rendering engines Patch is outdated, and requires more work.
Friendly ping.
(In reply to Zsolt Udvari from comment #12) Hello, I think I have all my hardware now to rebuild the NAS. I hope to get started on the weekend.
Testing updated patch.
Created attachment 257614 [details] textproc/py-sphinxcontrib-svg2pdfconverter: Update to 1.2.3; OPTION renderers * Update to 1.2.3 * Add Port OPTIONs for all three PDF renderers, making Cairo the default poudriere-testport textproc/py-sphinxcontrib-svg2pdfconverter: main-amd64-current: Pass main-i386-current: Pass 13_4-amd64-release: Pass 13_4-i386-release: Pass 14_1-amd64-release: Pass 14_1-i386-release: Pass 14_2-amd64-release: Pass 14_2-i386-release: Pass
Thanks for your work! Committed.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b47799212b488e1ec07ad3cb9dc52dde471dc805 commit b47799212b488e1ec07ad3cb9dc52dde471dc805 Author: Alastair Hogge <agh@riseup.net> AuthorDate: 2025-02-27 19:21:22 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2025-02-27 19:24:39 +0000 textproc/py-sphinxcontrib-svg2pdfconverter: Update to 1.2.3 Add Port OPTIONs for all three PDF renderers, making Cairo the default. PR: 276210 Approved by: submitter is maintainer textproc/py-sphinxcontrib-svg2pdfconverter/Makefile | 19 +++++++++++++++++-- textproc/py-sphinxcontrib-svg2pdfconverter/distinfo | 6 +++--- 2 files changed, 20 insertions(+), 5 deletions(-)
Thanks