Bug 276222 - www/ladybird: should only optionally depend on pulseaudio
Summary: www/ladybird: should only optionally depend on pulseaudio
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-09 17:37 UTC by Benjamin Takacs
Modified: 2024-01-16 16:20 UTC (History)
0 users

See Also:
fuz: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Takacs 2024-01-09 17:37:09 UTC 
Ladybird can work without pulseaudio, so that dependency should be behind a PULSEAUDIO option.

As upstream does autodetection at least in [0] there is currently no way to disable pulseaudio in case it is installed for some reason. For clean build environments with PULSEAUDIO option disabled for all ports just removing the dependency would work fine, but for example qt6-multimedia depends on pulseaudio with default options, so mixed settings of a PULSAUDIO option wouldn't work without support in ladybirds build system.

[0]: https://github.com/SerenityOS/serenity/blob/343d6b001fa94d9707d443f00d295fdfcc4f1511/Meta/Lagom/CMakeLists.txt#L136
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-01-10 12:11:44 UTC 
I have a patch prepared for this purpose which I plan to commit this weekend.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-16 16:19:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c2216387ee48a80e4aaffe994baf9e5dad8f3227

commit c2216387ee48a80e4aaffe994baf9e5dad8f3227
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2024-01-09 19:33:53 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-01-16 16:18:22 +0000

    www/ladybird: update to g20240109

     - add PULSEAUDIO option to disable use of Pulseaudio
     - remove upstreamed distribution patches

    PR:             276222

 www/ladybird/Makefile                              | 10 ++++++---
 www/ladybird/distinfo                              | 26 +++++++++++-----------
 www/ladybird/files/patch-AK_Format.cpp (gone)      | 20 -----------------
 ...land_Libraries_LibCore_StandardPaths.cpp (gone) | 21 -----------------
 4 files changed, 20 insertions(+), 57 deletions(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-01-16 16:20:45 UTC 
Thank you for the request.