Bug 276263 - graphics/py-python-poppler-qt5: fix build on FreeBSD 13
Summary: graphics/py-python-poppler-qt5: fix build on FreeBSD 13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rodrigo Osorio
URL: https://github.com/frescobaldi/python...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-11 20:19 UTC by Martin Neubauer
Modified: 2024-04-02 08:38 UTC (History)
2 users (show)

See Also:
m.ne: maintainer-feedback+
rodrigo: merge-quarterly+

Attachments
Patch picked from upstream repo (562 bytes, patch)
2024-01-11 20:19 UTC, Martin Neubauer 		m.ne: maintainer-approval+
Details | Diff
alternative patch (4.25 KB, patch)
2024-02-08 19:23 UTC, Tijl Coosemans 		no flags Details | Diff
Modified version of patch by Tijl Coosemans (3.70 KB, patch)
2024-02-10 21:20 UTC, Martin Neubauer 		m.ne: maintainer-approval+
Details | Diff
updated patch created against current ports tree (3.70 KB, patch)
2024-03-16 12:47 UTC, Martin Neubauer 		m.ne: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2024-01-11 20:19:15 UTC 
Created attachment 247600 [details]
Patch picked from upstream repo

Fix the build failures on older FreeBSD versions due to the recently updated graphics/poppler port.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2024-02-08 19:23:48 UTC 
Created attachment 248267 [details]
alternative patch

I saw the build failure in an exp-run and worked out a patch before finding this bug report.  This patch also cleans up the Makefile a bit so I'm uploading it anyway in case you find this useful.

Changes:
- Recent Poppler requires C++17.
- Simplify port by using pep517 infrastructure from USES=python.
- Respect CXXFLAGS and LDFLAGS.
- Enable parallel build.
Comment 2 Martin Neubauer 2024-02-08 23:20:19 UTC 
Comment on attachment 248267 [details]
alternative patch

Does look good to me. Many thanks.
Comment 3 Martin Neubauer 2024-02-08 23:20:21 UTC 
Comment on attachment 248267 [details]
alternative patch

Does look good to me. Many thanks.
Comment 4 Martin Neubauer 2024-02-10 21:20:43 UTC 
Created attachment 248337 [details]
Modified version of patch by Tijl Coosemans

This is a somewhat less aggressive patch to pacify `poudriere testport` a little.
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2024-03-16 12:01:14 UTC 
Looks like I wait a little too much and the port was now fixed. Sorry for that.

The patch submitted here doesn't apply anymore and the changes where partially
committed in the port so I mark this PR close as overcome by events but don't
hesitate to reopen it if I was wrong.

Cheers
Comment 6 Martin Neubauer 2024-03-16 12:47:55 UTC 
Created attachment 249215 [details]
updated patch created against current ports tree

PORTREVISION was bumped resulting in the previous patch not applying any more. The new one should work again with the current ports tree.
Comment 7 Martin Neubauer 2024-03-16 12:49:47 UTC 
The previous change to the port merely was a consumer bump unrelated to this issue.
Comment 8 Martin Neubauer 2024-03-16 12:51:11 UTC 
Bugzilla didn't apply the status change together with the comment.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-04-01 18:31:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d826246f8a360246c1f8c8fdbed1618f9dbbfe9

commit 5d826246f8a360246c1f8c8fdbed1618f9dbbfe9
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-04-01 18:26:00 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-04-01 18:29:38 +0000

    graphics/py-python-poppler-qt5: fix build on FreeBSD 13

    Patch picked from upstream repo

    Fix the build failures on older FreeBSD versions due
    to the recently updated graphics/poppler port.

    PR:             276263
    Reported by:     Martin Neubauer <m.ne@gmx.net> (maintainer)

 graphics/py-python-poppler-qt5/Makefile         | 28 ++++++++++---------------
 graphics/py-python-poppler-qt5/pkg-plist (gone) | 26 -----------------------
 2 files changed, 11 insertions(+), 43 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-04-02 08:37:09 UTC 
A commit in branch 2024Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d39e65d2bc620a75947d947d346211593f02a054

commit d39e65d2bc620a75947d947d346211593f02a054
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-04-01 18:26:00 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-04-02 08:33:01 +0000

    graphics/py-python-poppler-qt5: fix build on FreeBSD 13

    Patch picked from upstream repo

    Fix the build failures on older FreeBSD versions due
    to the recently updated graphics/poppler port.

    PR:             276263
    Reported by:     Martin Neubauer <m.ne@gmx.net> (maintainer)

    (cherry picked from commit 5d826246f8a360246c1f8c8fdbed1618f9dbbfe9)

 graphics/py-python-poppler-qt5/Makefile         | 26 +++++++++++--------------
 graphics/py-python-poppler-qt5/pkg-plist (gone) | 26 -------------------------
 2 files changed, 11 insertions(+), 41 deletions(-)
Comment 11 Rodrigo Osorio freebsd_committer freebsd_triage 2024-04-02 08:38:13 UTC 
Committed, thanks