Bug 276289 - devel/pcsc-lite: Make polkit support optional
Summary: devel/pcsc-lite: Make polkit support optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-13 08:09 UTC by Daniel Engberg
Modified: 2024-01-14 09:03 UTC (History)
0 users

See Also:
delphij: maintainer-feedback+

Attachments
Patch for pcsc-lite (1.24 KB, patch)
2024-01-13 08:09 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-13 08:09:37 UTC 
Created attachment 247614 [details]
Patch for pcsc-lite

There are scenarios where you don't want to pull in dbus and friends so make polkit support optional

Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Xin LI freebsd_committer freebsd_triage 2024-01-13 21:23:52 UTC 
The patch looks fine to me, please feel free to push (and take maintainership if you like; I don't mind taking care of the port, but I no longer actively use it so please consider).
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-13 23:31:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8633b2706862e0c80c9c85a20f318244853246f6

commit 8633b2706862e0c80c9c85a20f318244853246f6
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-01-13 23:18:44 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-01-13 23:30:23 +0000

    devel/pcsc-lite: Make polkit support optional

    There are scenarios where you don't want to pull in dbus and friends
    so make polkit support optional
    Replace PYTHON_NO_DEPENDS= yes with USES= python:env

    PR:             276289
    Reviewed by:    delphij (maintainer)

 devel/pcsc-lite/Makefile | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
Comment 3 Xin LI freebsd_committer freebsd_triage 2024-01-14 05:09:23 UTC 
Thanks!
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 09:03:48 UTC 
Just wanted to add that I also use it very sparsely these days so I think either of us are just as good in that regard.

Thanks for closing the ticket!