Bug 276333 - net/frr9: startup script tries to run staticd with -C option (not available)
Summary: net/frr9: startup script tries to run staticd with -C option (not available)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-14 16:42 UTC by Kurt Jaeger
Modified: 2024-03-20 22:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (olivier)
john: merge-quarterly?

Attachments
patch for frr9 startup (412 bytes, patch)
2024-01-14 16:48 UTC, Kurt Jaeger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2024-01-14 16:42:40 UTC 

    


    


      



        
          Comment 1
        

        
          Kurt Jaeger

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-14 16:48:33 UTC
        

      






Created attachment 247654 [details]
patch for frr9 startup

    


    


      



        
          Comment 2
        

        
          Kurt Jaeger

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-14 16:51:29 UTC
        

      






During frr9 start, the /usr/local/etc/rc.d/frr script calls
check_config(), which calls each daemon listed in
/etc/rc.conf:frr_daemons except pimd with option -C.

staticd does not know that option, either, so it fails to start.

The patch skips over staticd as well.

    


    


      



        
          Comment 3
        

        
          commit-hook

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-14 17:25:00 UTC
        

      






A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9684f42bbe0a2951c1327a5619734a753dc3e64d

commit 9684f42bbe0a2951c1327a5619734a753dc3e64d
Author:     Olivier Cochard <olivier@FreeBSD.org>
AuthorDate: 2024-01-14 17:20:54 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2024-01-14 17:23:19 +0000

    net/frr9: Fix rc script with staticd

    PR:             276333
    Reported by:    pi

 net/frr9/Makefile     | 1 +
 net/frr9/files/frr.in | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

    


    


      



        
          Comment 4
        

        
          Olivier Cochard

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-14 20:51:32 UTC
        

      






Thanks!

    


    


      



        
          Comment 5
        

        
          John W. O'Brien

        

        
        

        
          2024-03-20 22:21:07 UTC
        

      






Please merge to the quarterly branch.