Bug 276346 - devel/libunwind: Update to 1.8.0
Summary: devel/libunwind: Update to 1.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-15 08:37 UTC by Dmitry Chagin
Modified: 2024-02-19 05:53 UTC (History)
3 users (show)

See Also:
linimon: merge-quarterly?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Chagin freebsd_committer freebsd_triage 2024-01-15 08:37:43 UTC 
1.8.0 released: https://github.com/libunwind/libunwind/releases
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-01-18 06:02:03 UTC 
Patch is available here:  https://github.com/freebsd/freebsd-ports/pull/215
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-29 09:07:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1c7a06b4e3a4f1e4bb91d4f048680021fd793ff1

commit 1c7a06b4e3a4f1e4bb91d4f048680021fd793ff1
Author:     awoonya <mzhyneva@gmail.com>
AuthorDate: 2024-01-15 19:56:27 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-01-29 09:04:15 +0000

    devel/libunwind: update to 1.8.0

    PR:     276346

    Approved by:    sunpoet (maintainer timeout)
    Co-authored-by: Gleb Popov <arrowd@FreeBSD.org>

    Pull Request:   https://github.com/freebsd/freebsd-ports/pull/215

 devel/libunwind/Makefile                           |  5 ++--
 devel/libunwind/distinfo                           |  6 ++---
 devel/libunwind/files/patch-armv7 (gone)           | 29 ----------------------
 devel/libunwind/files/patch-i386 (gone)            | 13 ----------
 ...atch-include_tdep-x86__64_libunwind__i.h (gone) | 13 ----------
 .../files/patch-src_setjmp_siglongjmp.c (gone)     | 11 --------
 devel/libunwind/pkg-plist                          |  9 +++++--
 7 files changed, 12 insertions(+), 74 deletions(-)
Comment 3 John F. Carr 2024-02-02 10:50:31 UTC 
libunwind 1.8 does not build on 32 bit ARM.

libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include/tdep-arm -I. -D_GNU_SOURCE -DNDEBUG -O2 -pipe -mcpu=cortex-a57 -fstack-protector-strong -fno-strict-aliasing -fexceptions -Wall -Wsign-compare -D__EXTENSIONS__ -MT arm/Ltrace.lo -MD -MP -MF arm/.deps/Ltrace.Tpo -c arm/Ltrace.c  -fPIC -DPIC -o arm/.libs/Ltrace.o
In file included from arm/Ltrace.c:4:
arm/Gtrace.c:517:8: error: implement UNW_ARM_FRAME_SIGRETURN on FreeBSD
  517 |       #error implement UNW_ARM_FRAME_SIGRETURN on FreeBSD
      |        ^
1 error generated.
*** Error code 1

The #error is new in 1.8.  It used to be printf("XXX\n").

Both git and ruby depend on libunwind.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-02-03 18:54:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=663a5a08daebb7563af762e032c9776d4b2846aa

commit 663a5a08daebb7563af762e032c9776d4b2846aa
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2024-02-03 07:48:07 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-02-03 18:53:01 +0000

    devel/libunwind: Unbreak build on 32-bit ARM.

    PR:             276346
    Reported by:    John F. Carr <jfc@mit.edu>

 devel/libunwind/files/patch-src_arm_Gtrace.c (new) | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2024-02-08 02:48:19 UTC 
^Triage: assign to committer.