Bug 276373 - devel/root: Re-enable MathMore for release 6.30/02 and fix debug build
Summary: devel/root: Re-enable MathMore for release 6.30/02 and fix debug build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-16 12:03 UTC by Erik Jensen
Modified: 2024-01-20 12:53 UTC (History)
1 user (show)

See Also:


Attachments
Port patch (10.92 KB, patch)
2024-01-16 12:03 UTC, Erik Jensen
erik: maintainer-approval+
Details | Diff
Port patch, openblas dep added (10.87 KB, patch)
2024-01-19 10:49 UTC, Erik Jensen
erik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Jensen 2024-01-16 12:03:19 UTC
Created attachment 247699 [details]
Port patch

I overlooked a dependency change in the source code of the latest release and, 
as a result, the MathMore option was mistakenly auto-disabled at the configure 
stage in the latest port revision.

I also noticed a failure to build with debug symbols enabled.

The attached patch fixes both issues.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-01-18 16:56:20 UTC
Ready to commit. Tested on amd64 and aarch64

Q/A check could be fixed:

====> Running Q/A tests (stage-qa)
Warning: you may not need USES=desktop-file-utils
Error: /usr/local/lib/root/libTMVA.so.6.30.02 is linked to /usr/local/lib/libopenblas.so.0 from math/openblas but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libopenblas.so:math/openblas
Warning: you might not need LIB_DEPENDS on libpango-1.0.so
Comment 2 Erik Jensen 2024-01-19 10:49:43 UTC
Created attachment 247778 [details]
Port patch, openblas dep added

Somehow I overlooked the openblas error.
It has been added now.

The other two warnings I have tried accommodating previously whereupon the 
warnings turned into errors, as those dependencies are actually needed.

Cheers,
Erik
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-01-20 12:51:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d6ffd622a326012a592c6c5d1b8f413a9c245735

commit d6ffd622a326012a592c6c5d1b8f413a9c245735
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2024-01-20 12:49:21 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-01-20 12:50:52 +0000

    devel/root: Re-enable MathMore for release 6.30/02 and fix debug build

    I overlooked a dependency change in the source code of the latest release and,
    as a result, the MathMore option was mistakenly auto-disabled at the configure
    stage in the latest port revision.

    I also noticed a failure to build with debug symbols enabled.

    PR:             276373

 devel/root/Makefile                                |  4 +-
 ...ect_clang_lib_Serialization_ASTWriter.cpp (new) | 13 +++++
 devel/root/pkg-plist                               | 57 ++++++++++++++++++++++
 3 files changed, 73 insertions(+), 1 deletion(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2024-01-20 12:53:03 UTC
Committed, thanks!